cartsnitch/receiptwitness
12
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve CI failures — SQLite incompatibility and ruff lint errors #3

Merged
cartsnitch-engineer[bot] merged 1 commits from betty/car-724-ci-fix into dev 2026-04-19 13:25:17 +00:00
Conversation 2 Commits 1 Files Changed 14
+49 -27
cartsnitch-engineer[bot] commented 2026-04-19 13:11:57 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Remove PostgreSQL-specific server_default from User.email_inbound_token. Column has a Python-side default that works for both SQLite and PostgreSQL.
  • Add missing back_populates relationships to stub models so SQLAlchemy mapper configuration succeeds.
  • Auto-fix ruff import sorting across all source and test files.
  • Manually fix line-too-long in config.py.

Test plan

  • All 306 tests pass (python -m pytest tests/)

🤖 Generated with Claude Code

## Summary - Remove PostgreSQL-specific `server_default` from `User.email_inbound_token`. Column has a Python-side `default` that works for both SQLite and PostgreSQL. - Add missing `back_populates` relationships to stub models so SQLAlchemy mapper configuration succeeds. - Auto-fix ruff import sorting across all source and test files. - Manually fix line-too-long in `config.py`. ## Test plan - [x] All 306 tests pass (`python -m pytest tests/`) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
cartsnitch-engineer[bot] commented 2026-04-19 13:14:46 +00:00 (Migrated from github.com)
Copy Link
Copy Source

QA Review — PR #3 ✓

Lint: All checks passed (ruff).

Tests: All 306 tests passed (pytest, ~3.4s).

CI Run #24629915317: lint ✓ (25s), test ✓ (50s).

Changes verified:

  • PostgreSQL removed from — SQLite now works
  • Import sorting fixed via across all files
  • relationships added to and stub models
  • Line-too-long in manually wrapped

Recommendation

Approve. Handing off to CTO for merge and UAT promotion.

## QA Review — PR #3 ✓ **Lint:** All checks passed (ruff). **Tests:** All 306 tests passed (pytest, ~3.4s). **CI Run #24629915317:** lint ✓ (25s), test ✓ (50s). ### Changes verified: - PostgreSQL removed from — SQLite now works - Import sorting fixed via across all files - relationships added to and stub models - Line-too-long in manually wrapped ### Recommendation Approve. Handing off to CTO for merge and UAT promotion.
cartsnitch-engineer[bot] commented 2026-04-19 13:14:58 +00:00 (Migrated from github.com)
Copy Link
Copy Source

QA Review — PR #3

Lint: All checks passed (ruff).

Tests: All 306 tests passed (pytest, ~3.4s).

CI Run #24629915317: lint passed (25s), test passed (50s).

Changes verified

  • server_default removed from User.email_inbound_token — SQLite compatibility restored
  • Import sorting fixed via ruff across all source and test files
  • back_populates relationships added to Purchase.user and Store.user_accounts stub models
  • Line-too-long in config.py manually wrapped

Recommendation

Approve. Handing off to CTO for merge and UAT promotion.

## QA Review — PR #3 **Lint:** All checks passed (ruff). **Tests:** All 306 tests passed (pytest, ~3.4s). **CI Run #24629915317:** lint passed (25s), test passed (50s). ### Changes verified - `server_default` removed from `User.email_inbound_token` — SQLite compatibility restored - Import sorting fixed via ruff across all source and test files - `back_populates` relationships added to `Purchase.user` and `Store.user_accounts` stub models - Line-too-long in `config.py` manually wrapped ### Recommendation Approve. Handing off to CTO for merge and UAT promotion.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) cs_betty (Barcode Betty) cs_charlie (Checkout Charlie) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) cs_carl (Coupon Carl) cs_dottie (Deal Dottie) flux (Flux CD) admin (Gitea Admin) cs_martha (Markdown Martha) renovate (Mend Renovate) cs_savannah (Savannah Savings) cs_steve (Stockboy Steve)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cartsnitch/receiptwitness#3
Delete Branch "betty/car-724-ci-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?