Merge pull request #91 from cartsnitch/fix/registration-redirect

fix(auth): wait for session confirmation before post-auth redirect
Merge commit '8af7b37b38f3d5c5cb13b3e98530ec4d6127b755' into fix/registration-redirect
2026-03-31 23:14:04 +00:00 · 2026-03-31 23:08:22 +00:00 · 2026-03-31 22:30:05 +00:00 · 2026-03-31 22:11:20 +00:00 · 2026-03-31 21:55:00 +00:00
3 changed files with 18 additions and 5 deletions
@@ -30,4 +30,4 @@ EXPOSE 8000
 HEALTHCHECK --interval=30s --timeout=3s \
    CMD python -c "import urllib.request; urllib.request.urlopen('http://localhost:8000/health')"

-CMD ["uvicorn", "cartsnitch_api.main:app", "--host", "0.0.0.0", "--port", "8000"]
+CMD ["sh", "-c", "python -m alembic upgrade head && uvicorn cartsnitch_api.main:app --host 0.0.0.0 --port 8000"]
@@ -31,8 +31,14 @@ export function Login() {
        throw new Error(authError.message ?? 'Sign in failed')
      }

-      setAuthenticated(true)
-      navigate('/')
+      // After successful signIn, force a session fetch to confirm the cookie is set
+      // before navigating to the protected route
+      const sessionResult = await authClient.getSession()
+      if (sessionResult.data) {
+        navigate('/')
+      } else {
+        setError('Sign in failed. Please try again.')
+      }
    } catch {
      if (import.meta.env.VITE_MOCK_AUTH === 'true') {
        setAuthenticated(true)
@@ -38,8 +38,15 @@ export function Register() {
        throw new Error(authError.message ?? 'Registration failed')
      }

-      setAuthenticated(true)
-      navigate('/')
+      // After successful signUp, force a session fetch to confirm the cookie is set
+      // before navigating to the protected route
+      const sessionResult = await authClient.getSession()
+      if (sessionResult.data) {
+        navigate('/')
+      } else {
+        // Session not established — show success message and link to login
+        setError('Account created! Please sign in.')
+      }
    } catch {
      if (import.meta.env.VITE_MOCK_AUTH === 'true') {
        setAuthenticated(true)
Author	SHA1	Message	Date
cartsnitch-ceo[bot]	78b7831d43	Merge pull request #91 from cartsnitch/fix/registration-redirect fix(auth): wait for session confirmation before post-auth redirect	2026-03-31 23:14:04 +00:00
CartSnitch Engineer Bot	e45b510519	Merge commit '8af7b37b38f3d5c5cb13b3e98530ec4d6127b755' into fix/registration-redirect	2026-03-31 23:08:22 +00:00
CartSnitch Engineer Bot	f25044ea7e	fix(auth): restore setAuthenticated in mock-auth catch block The try-block getSession() pattern is correct for real auth mode. The mock-auth catch block (VITE_MOCK_AUTH) still needs to set the Zustand flag so ProtectedRoute respects the authenticated state. Co-Authored-By: Paperclip <noreply@paperclip.ing>	2026-03-31 22:30:05 +00:00
CartSnitch Engineer Bot	b637fd9c11	fix(auth): wait for session confirmation before post-auth redirect Race condition between signUp/signIn completion and ProtectedRoute's useSession() call caused redirect loops — Better-Auth's session cookie is not immediately visible to useSession() after signUp/signIn resolves. Fix: call authClient.getSession() explicitly after signUp/signIn to synchronize before navigating to protected routes. Fall back to error message if session not confirmed. Also removes dead setAuthenticated() calls that only work in mock mode. Co-Authored-By: Paperclip <noreply@paperclip.ing>	2026-03-31 22:11:20 +00:00
cartsnitch-engineer[bot]	8af7b37b38	fix(api): run Alembic migrations on startup (#90 ) Merged by Coupon Carl (CEO). QA approved, CTO approved. CI green (lighthouse failure is known/tracked). cc @cpfarhood	2026-03-31 21:55:00 +00:00