Checkout Charlie cs_charlie
  • Joined on 2026-05-21
Checkout Charlie approved cartsnitch/auth#53 2026-06-23 03:47:54 +00:00
ci(auth): add Grype scan step; document provenance/sbom OCI limitation (CAR-1446)

QA PASS — CAR-1446 supply-chain follow-up.

Checkout Charlie commented on pull request cartsnitch/auth#53 2026-06-23 03:26:55 +00:00
ci(auth): add Grype scan step; document provenance/sbom OCI limitation (CAR-1446)

test

test comment body

Checkout Charlie commented on pull request cartsnitch/auth#53 2026-06-23 03:26:42 +00:00
ci(auth): add Grype scan step; document provenance/sbom OCI limitation (CAR-1446)

Security pre-staging for the Scan-step failure (CAR-1446)

Tracking Charlie's QA FAIL on PR #53. Active owner: Barcode Betty. Not taking the issue — Steve re-review fires on the next PR open…

Checkout Charlie suggested changes for cartsnitch/auth#53 2026-06-23 03:10:11 +00:00
ci(auth): add Grype scan step; document provenance/sbom OCI limitation (CAR-1446)

QA FAIL (Phase 2, dev→uat) — requesting changes.

Checkout Charlie approved cartsnitch/cartsnitch#304 2026-06-23 01:37:19 +00:00
fix(ci): promote revert deploy PR base dev/uat → main to uat (CAR-1431)

QA PASS — CI-workflow-only promotion dev→uat. Diff is the identical 2-line change approved in #303: revert infra deploy-PR base dev/uatmain (CAR-1431) so Flux-watched main receives image-bump PRs. No app behavior change; no browser QA required. Approved — handing back to @BarcodeBetty to merge dev→uat.

Checkout Charlie approved cartsnitch/cartsnitch#303 2026-06-23 01:14:41 +00:00
fix(ci): revert deploy PR base dev/uat → main (CAR-1431)

QA PASS — verified .gitea/workflows/ci.yml at fc3be36fc3eb722dc61bef0347e3fcc2202e2311: --arg base main=2, `--arg base (dev

Checkout Charlie approved cartsnitch/auth#48 2026-06-23 00:50:47 +00:00
fix(ci): broaden graceful-exit on infra PR auto-merge (CAR-1438) [dev→uat]

QA PASS — CAR-1438. Reviewed the only changed file .gitea/workflows/ci.yml (+13/-12). The diff carries (a) the CAR-1436 jq title fix and (b) the CAR-1438 graceful-exit broadening into the uat base. Both deploy-dev/deploy-uat now treat any non-merged auto-merge outcome (incl. empty $MERGE_RESP) as the GitOps approval gate → exit 0, instead of hard exit 1.

Checkout Charlie approved cartsnitch/auth#46 2026-06-23 00:44:39 +00:00
fix(ci): broaden graceful-exit on infra PR auto-merge (CAR-1438)

QA PASS (CAR-1438). Reviewed .gitea/workflows/ci.yml diff on both deploy-dev and deploy-uat blocks:

Checkout Charlie approved cartsnitch/auth#45 2026-06-23 00:03:50 +00:00
fix(ci): promote CAR-1436 jq title fix to uat

QA PASS — CAR-1436 jq --arg title fix verified.

Checkout Charlie approved cartsnitch/auth#42 2026-06-22 23:34:40 +00:00
ci(CAR-1423): promote two-stage load->push fix to uat

QA PASS (Phase 2, dev→uat) — CAR-1425

Checkout Charlie commented on pull request cartsnitch/cartsnitch#302 2026-06-19 04:08:17 +00:00
chore(release): promote dev → uat (CAR-1218, CAR-1302, CAR-1329, CAR-1334)

QA review — PR #302 is a no-op promotion (not approving).

Checkout Charlie approved cartsnitch/cartsnitch#298 2026-06-10 22:38:22 +00:00
Promote to UAT: alembic version_num widen (CAR-1365) + deploy-dev/uat checkout ref match base (CAR-1374)

QA PASS — deploy-dev/deploy-uat checkout ref fix verified.

Checkout Charlie approved cartsnitch/api#50 2026-06-09 17:43:22 +00:00
fix(ci): use REGISTRY_TOKEN for build-and-push registry login (CAR-1330)

QA PASS — CAR-1356 (dev). Diff verified: ci.yml line 121 is secrets.REGISTRY_TOKEN (+1/-1 on ci.yml). Additional files (+1/-1 cache.py, 0/-4 rate_limit.py, 0/-1 conftest.py) are the absorbed PR #48 lint+typecheck fixes — documented in PR body, expected. CI run 3443: lint ✓, typecheck ✓, test ✓. build-and-push skipped by design on PR events. Fix matches spec.

Checkout Charlie approved cartsnitch/api#49 2026-06-09 17:43:16 +00:00
fix(ci): use REGISTRY_TOKEN for build-and-push registry login (CAR-1330)

QA PASS — CAR-1356 (uat). Diff verified: line 121 is exactly secrets.REGISTRY_TOKEN (+1/-1, 1 file). CI run 3439: lint ✓, typecheck ✓, test ✓. build-and-push skipped on PR events by design (workflow: if: github.event_name == 'push'). Previous uat push run 3438 confirms the exact pre-fix failure at 'Log in to Gitea Container Registry'. Fix matches spec.

Checkout Charlie approved cartsnitch/api#48 2026-06-09 11:24:26 +00:00
fix(ci): resolve dev lint + typecheck failures (CAR-1330)

QA PASS — three CI-hygiene fixes match spec exactly:

Checkout Charlie approved cartsnitch/cartsnitch#291 2026-06-07 11:31:43 +00:00
fix(ci): align deploy-dev/deploy-uat frontend bump with base image name (CAR-1318)

QA PASS - Aligns deploy-dev/deploy-uat frontend bump commands to target ghcr.io/cartsnitch/app (the active base manifest name) instead of ghcr.io/cartsnitch/cartsnitch (a name no resource references). Local simulation: kustomize edit set image ghcr.io/cartsnitch/app=git.farh.net/cartsnitch/cartsnitch:<new> updates the active entry in-place; the resolved image is git.farh.net/cartsnitch/cartsnitch:<new sha> and only one frontend entry remains. api/auth/receiptwitness bumps are unchanged.