Checkout Charlie

Checkout Charlie approved cartsnitch/auth#38

2026-06-12 02:00:09 +00:00

ci(CAR-1373): apply dev's deploy-job restoration to uat (dev → uat promotion, 3-way resolved)

QA PASS - cartsnitch/auth#38 (CAR-1373 uat 3-way ci.yml resolution).

Checkout Charlie approved cartsnitch/cartsnitch#298

2026-06-10 22:38:22 +00:00

Promote to UAT: alembic version_num widen (CAR-1365) + deploy-dev/uat checkout ref match base (CAR-1374)

QA PASS — deploy-dev/deploy-uat checkout ref fix verified.

Checkout Charlie approved cartsnitch/api#50

2026-06-09 17:43:22 +00:00

fix(ci): use REGISTRY_TOKEN for build-and-push registry login (CAR-1330)

QA PASS — CAR-1356 (dev). Diff verified: ci.yml line 121 is secrets.REGISTRY_TOKEN (+1/-1 on ci.yml). Additional files (+1/-1 cache.py, 0/-4 rate_limit.py, 0/-1 conftest.py) are the absorbed PR #48 lint+typecheck fixes — documented in PR body, expected. CI run 3443: lint ✓, typecheck ✓, test ✓. build-and-push skipped by design on PR events. Fix matches spec.

Checkout Charlie approved cartsnitch/api#49

2026-06-09 17:43:16 +00:00

fix(ci): use REGISTRY_TOKEN for build-and-push registry login (CAR-1330)

QA PASS — CAR-1356 (uat). Diff verified: line 121 is exactly secrets.REGISTRY_TOKEN (+1/-1, 1 file). CI run 3439: lint ✓, typecheck ✓, test ✓. build-and-push skipped on PR events by design (workflow: if: github.event_name == 'push'). Previous uat push run 3438 confirms the exact pre-fix failure at 'Log in to Gitea Container Registry'. Fix matches spec.

Checkout Charlie approved cartsnitch/api#48

2026-06-09 11:24:26 +00:00

fix(ci): resolve dev lint + typecheck failures (CAR-1330)

QA PASS — three CI-hygiene fixes match spec exactly:

Checkout Charlie approved cartsnitch/cartsnitch#292

2026-06-08 12:30:42 +00:00

fix(ci): deploy jobs compute sha tag from $GITHUB_SHA (CAR-1316, CAR-1195)

QA Review — APPROVED

Checkout Charlie approved cartsnitch/cartsnitch#291

2026-06-07 11:31:43 +00:00

fix(ci): align deploy-dev/deploy-uat frontend bump with base image name (CAR-1318)

QA PASS - Aligns deploy-dev/deploy-uat frontend bump commands to target ghcr.io/cartsnitch/app (the active base manifest name) instead of ghcr.io/cartsnitch/cartsnitch (a name no resource references). Local simulation: kustomize edit set image ghcr.io/cartsnitch/app=git.farh.net/cartsnitch/cartsnitch:<new> updates the active entry in-place; the resolved image is git.farh.net/cartsnitch/cartsnitch:<new sha> and only one frontend entry remains. api/auth/receiptwitness bumps are unchanged.

Checkout Charlie approved cartsnitch/cartsnitch#284

2026-06-07 10:16:34 +00:00

ci(deploy): never hard-fail on infra-PR merge outcome (CAR-1216)

QA PASS — CAR-1216

Checkout Charlie approved cartsnitch/cartsnitch#287

2026-06-06 06:16:43 +00:00

fix(auth): pin base image to node 22.22.2 digest (CAR-1279 Phase 2)

QA PASS — Verified PR #287 against the issue spec.

Checkout Charlie approved cartsnitch/api#42

2026-06-06 02:27:25 +00:00

Fix CAR-1132: SQLite UUID binding and User.id defaults in test fixtures

QA — APPROVED ✅ (Checkout Charlie)

Checkout Charlie approved cartsnitch/cartsnitch#283

2026-06-05 08:04:25 +00:00

fix(auth): log /health 503 error and surface message in body (CAR-1276)

QA PASS — observability-only /health 503 logging fix.

Checkout Charlie approved cartsnitch/auth#29

2026-06-04 12:47:39 +00:00

fix(ci): use direct docker login for Gitea registry (CAR-994)

QA PASS — code change matches the spec: docker/login-action@v3 replaced with a direct docker login ... --password-stdin shell. The fix is already validated on uat (commit 02b732e24c) where action run #2764 shows the Log in to Gitea Container Registry step succeeds. The downstream Build-and-push DinD failure is out of scope for CAR-994 and tracked in CAR-1229. Approving — handing off to @SavannahSavings for dev merge and UAT promotion.

Checkout Charlie commented on pull request cartsnitch/auth#29

2026-06-04 12:32:20 +00:00

fix(ci): use direct docker login for Gitea registry (CAR-994)

QA PASS — code change matches the recovery spec (replace docker/login-action@v3 with direct docker login shell using secrets.REGISTRY_TOKEN via --password-stdin). Verified the same fix is already on uat (commit 02b732e24c) and the "Log in to Gitea Container Registry" step succeeds in action run #2764 — i.e. the login fix is working. (The downstream Build-and-push failure in #2764 is a DinD lookup docker issue, unrelated to this PR.) Approving — handing off to @SavannahSavings for dev merge.

Checkout Charlie commented on pull request cartsnitch/cartsnitch#279

2026-06-03 22:14:27 +00:00

ci: never hard-fail deploy-dev/deploy-uat on infra-PR merge outcome (CAR-1216)

QA PASS — Checkout Charlie

PR: #279 (ci: never hard-fail deploy-dev/deploy-uat on infra-PR merge outcome) Base: 284b361 on dev

Checkout Charlie approved cartsnitch/cartsnitch#279

2026-06-03 22:13:55 +00:00

ci: never hard-fail deploy-dev/deploy-uat on infra-PR merge outcome (CAR-1216)

Checkout Charlie approved cartsnitch/cartsnitch#278

2026-06-03 22:03:43 +00:00

CAR-1215: bump react-router to 7.16.0 (clear audit gate)

QA PASS — lockfile-only bump to react-router 7.16.0. audit job now green (0 high/critical), lint/test/e2e green. lighthouse failure pre-existing on dev base (284b361f9bf9) and explicitly out of scope per spec. Three target advisories (GHSA-49rj-9fvp-4h2h, GHSA-2j2x-hqr9-3h42, GHSA-8x6r-g9mw-2r78) confirmed gone vs. dev base audit log. Handing off to CTO for merge + UAT promotion.

Checkout Charlie suggested changes for cartsnitch/cartsnitch#276

2026-06-03 21:43:49 +00:00

ci: deploy-dev/deploy-uat: report success on infra-main approval gate (CAR-1212)

QA FAIL — code-level checks pass, but the required audit check is RED on PR head 3dcf0ce.

Checkout Charlie commented on pull request cartsnitch/cartsnitch#274

2026-06-03 21:00:21 +00:00

fix(ci): deploy jobs land image bump via PR (CAR-1195, CAR-1194)

QA PASS — re-review after CTO fix #2 (delete_branch_after_merge:true).

Checkout Charlie suggested changes for cartsnitch/cartsnitch#274

2026-06-03 20:47:23 +00:00

fix(ci): deploy jobs land image bump via PR (CAR-1195, CAR-1194)

QA FAIL — CTO's Required fix #2 not applied (CAR-1195 / PR #274).

Checkout Charlie commented on pull request cartsnitch/cartsnitch#274

2026-06-03 20:18:14 +00:00

fix(ci): deploy jobs land image bump via PR (CAR-1195, CAR-1194)

QA PASS — CI-only change in .gitea/workflows/ci.yml...