897cc322c7
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies. > - Agent creation can happen through local runtimes, managed runtimes, and external agents that onboard through invites. > - The old OpenClaw-oriented invite UX lived under company settings/invites and made a gateway-specific path look like a company access setting. > - That hid the broader bring-your-own-agent flow and forced operators to leave the add-agent modal when adding an external agent. > - This pull request moves external agent invite generation into the add-agent modal and makes the copy agent-oriented instead of OpenClaw-only. > - The benefit is a clearer agent-first onboarding path while company invites stay focused on human access. ## What Changed - Added an external-agent invite branch to the add-agent modal, including a dedicated prompt result view with Back navigation. - Added a shared agent onboarding prompt builder and focused modal coverage for prompt replacement/back navigation. - Removed the agent invite prompt UI from Company Settings and Company Invites, leaving Company Invites focused on human access links and invite history. - Updated the hidden OpenClaw Gateway runtime hint to direct operators to the add-agent invite flow instead of presenting it as a blocked runtime card. - Updated invite/onboarding docs, storybook coverage, and server-side onboarding copy toward generic agent language while preserving existing gateway compatibility. ## Verification - `pnpm -r typecheck` - `pnpm build` - `FAKE_BIN="$(mktemp -d)/bin"; mkdir -p "$FAKE_BIN"; printf '#!/bin/sh\nexit 1\n' > "$FAKE_BIN/tailscale"; chmod +x "$FAKE_BIN/tailscale"; PATH="$FAKE_BIN:$PATH" pnpm test:run` - `pnpm test:run` without the fake `tailscale` shim was also attempted; it failed only in two pre-existing CLI tailnet fallback tests because this host has a real Tailscale address (`100.125.202.3`) where those tests expect no Tailscale. - Focused confirmation for that host-env issue: `FAKE_BIN=... PATH="$FAKE_BIN:$PATH" pnpm exec vitest run --project paperclipai cli/src/__tests__/network-bind.test.ts cli/src/__tests__/onboard.test.ts` - Manual UI verification: served UI locally in light mode, opened add-agent modal, generated external agent prompt, verified the generated prompt replaces the form and Back returns to the form. ### Screenshots    ## Risks - Existing OpenClaw gateway compatibility remains, but operators now discover external agent onboarding from the add-agent modal instead of company settings. - Agent invites still appear in the invite history table, so that page may show agent-scoped invite rows even though it no longer creates agent onboarding prompts. - Low migration risk: no schema changes. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent in Codex desktop; tool-enabled repository, shell, browser, and GitHub workflow. Context window size was not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge
183 lines
6.1 KiB
TypeScript
183 lines
6.1 KiB
TypeScript
import os from "node:os";
|
|
import { describe, expect, it } from "vitest";
|
|
import { vi } from "vitest";
|
|
import type { Request } from "express";
|
|
import { buildInviteOnboardingTextDocument } from "../routes/access.js";
|
|
|
|
function buildReq(host: string): Request {
|
|
return {
|
|
protocol: "http",
|
|
header(name: string) {
|
|
if (name.toLowerCase() === "host") return host;
|
|
return undefined;
|
|
},
|
|
} as unknown as Request;
|
|
}
|
|
|
|
describe("buildInviteOnboardingTextDocument", () => {
|
|
it("renders a plain-text onboarding doc with expected endpoint references", () => {
|
|
const req = buildReq("localhost:3100");
|
|
const invite = {
|
|
id: "invite-1",
|
|
companyId: "company-1",
|
|
inviteType: "company_join",
|
|
allowedJoinTypes: "agent",
|
|
tokenHash: "hash",
|
|
defaultsPayload: null,
|
|
expiresAt: new Date("2026-03-05T00:00:00.000Z"),
|
|
invitedByUserId: null,
|
|
revokedAt: null,
|
|
acceptedAt: null,
|
|
createdAt: new Date("2026-03-04T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-04T00:00:00.000Z"),
|
|
} as const;
|
|
|
|
const text = buildInviteOnboardingTextDocument(req, "token-123", invite as any, {
|
|
deploymentMode: "local_trusted",
|
|
deploymentExposure: "private",
|
|
bindHost: "127.0.0.1",
|
|
allowedHostnames: [],
|
|
});
|
|
|
|
expect(text).toContain("Paperclip Agent Onboarding");
|
|
expect(text).toContain("/api/invites/token-123/accept");
|
|
expect(text).toContain("/api/join-requests/{requestId}/claim-api-key");
|
|
expect(text).toContain("/api/invites/token-123/onboarding.txt");
|
|
expect(text).toContain("/api/invites/token-123/skills/paperclip");
|
|
expect(text).toContain("Suggested Paperclip base URLs to try");
|
|
expect(text).toContain("http://localhost:3100");
|
|
expect(text).toContain("host.docker.internal");
|
|
expect(text).toContain("paperclipApiUrl");
|
|
expect(text).toContain('"adapterType": "openclaw_gateway"');
|
|
expect(text).toContain("headers.x-openclaw-token");
|
|
expect(text).toContain("Do NOT use /v1/responses or /hooks/*");
|
|
expect(text).toContain("set the first reachable candidate as agentDefaultsPayload.paperclipApiUrl");
|
|
expect(text).toContain("PAPERCLIP_API_KEY");
|
|
expect(text).toContain("Use your runtime's normal skill or instruction installation path.");
|
|
expect(text).toContain("Decide which Paperclip adapter type matches your runtime.");
|
|
});
|
|
|
|
it("includes loopback diagnostics for authenticated/private onboarding", () => {
|
|
const req = buildReq("localhost:3100");
|
|
const invite = {
|
|
id: "invite-2",
|
|
companyId: "company-1",
|
|
inviteType: "company_join",
|
|
allowedJoinTypes: "both",
|
|
tokenHash: "hash",
|
|
defaultsPayload: null,
|
|
expiresAt: new Date("2026-03-05T00:00:00.000Z"),
|
|
invitedByUserId: null,
|
|
revokedAt: null,
|
|
acceptedAt: null,
|
|
createdAt: new Date("2026-03-04T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-04T00:00:00.000Z"),
|
|
} as const;
|
|
|
|
const text = buildInviteOnboardingTextDocument(req, "token-456", invite as any, {
|
|
deploymentMode: "authenticated",
|
|
deploymentExposure: "private",
|
|
bindHost: "127.0.0.1",
|
|
allowedHostnames: [],
|
|
});
|
|
|
|
expect(text).toContain("Connectivity diagnostics");
|
|
expect(text).toContain("loopback hostname");
|
|
expect(text).toContain("If none are reachable");
|
|
});
|
|
|
|
it("includes inviter message in the onboarding text when provided", () => {
|
|
const req = buildReq("localhost:3100");
|
|
const invite = {
|
|
id: "invite-3",
|
|
companyId: "company-1",
|
|
inviteType: "company_join",
|
|
allowedJoinTypes: "agent",
|
|
tokenHash: "hash",
|
|
defaultsPayload: {
|
|
agentMessage: "Please join as our QA lead and prioritize flaky test triage first.",
|
|
},
|
|
expiresAt: new Date("2026-03-05T00:00:00.000Z"),
|
|
invitedByUserId: null,
|
|
revokedAt: null,
|
|
acceptedAt: null,
|
|
createdAt: new Date("2026-03-04T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-04T00:00:00.000Z"),
|
|
} as const;
|
|
|
|
const text = buildInviteOnboardingTextDocument(req, "token-789", invite as any, {
|
|
deploymentMode: "local_trusted",
|
|
deploymentExposure: "private",
|
|
bindHost: "127.0.0.1",
|
|
allowedHostnames: [],
|
|
});
|
|
|
|
expect(text).toContain("Message from inviter");
|
|
expect(text).toContain("prioritize flaky test triage first");
|
|
});
|
|
|
|
it("includes LAN candidates when the advertised host is tailnet-only", () => {
|
|
const networkSpy = vi.spyOn(os, "networkInterfaces").mockReturnValue({
|
|
en0: [
|
|
{
|
|
address: "fe80::1",
|
|
family: "IPv6",
|
|
internal: false,
|
|
netmask: "ffff:ffff:ffff:ffff::",
|
|
cidr: "fe80::1/64",
|
|
mac: "00:00:00:00:00:00",
|
|
scopeid: 1,
|
|
},
|
|
{
|
|
address: "192.168.6.178",
|
|
family: "IPv4",
|
|
internal: false,
|
|
netmask: "255.255.252.0",
|
|
cidr: "192.168.6.178/22",
|
|
mac: "00:00:00:00:00:00",
|
|
},
|
|
],
|
|
utun0: [
|
|
{
|
|
address: "203.0.113.42",
|
|
family: "IPv4",
|
|
internal: false,
|
|
netmask: "255.255.255.255",
|
|
cidr: "203.0.113.42/32",
|
|
mac: "00:00:00:00:00:00",
|
|
},
|
|
],
|
|
});
|
|
|
|
try {
|
|
const req = buildReq("paperclip.example.test:3103");
|
|
const invite = {
|
|
id: "invite-4",
|
|
companyId: "company-1",
|
|
inviteType: "company_join",
|
|
allowedJoinTypes: "agent",
|
|
tokenHash: "hash",
|
|
defaultsPayload: null,
|
|
expiresAt: new Date("2026-03-05T00:00:00.000Z"),
|
|
invitedByUserId: null,
|
|
revokedAt: null,
|
|
acceptedAt: null,
|
|
createdAt: new Date("2026-03-04T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-04T00:00:00.000Z"),
|
|
} as const;
|
|
|
|
const text = buildInviteOnboardingTextDocument(req, "token-999", invite as any, {
|
|
deploymentMode: "authenticated",
|
|
deploymentExposure: "private",
|
|
bindHost: "0.0.0.0",
|
|
allowedHostnames: ["paperclip.example.test", "203.0.113.42"],
|
|
});
|
|
|
|
expect(text).toContain("http://192.168.6.178:3103");
|
|
expect(text).not.toContain("http://[fe80::1]:3103");
|
|
} finally {
|
|
networkSpy.mockRestore();
|
|
}
|
|
});
|
|
});
|