forked from farhoodlabs/paperclip
1f70fd9a22
## Thinking Path > - Paperclip orchestrates AI agents across isolated execution workspaces; the local cwd is the only persistence boundary between runs. > - Workspace lifecycle (worktree_prepare → execute → workspace_finalize) and the wake/accept flow are what guarantee that dependent issues see a consistent worktree. > - PAPA-380 / PAPA-431 / PAPA-432 / PAPA-440 surfaced three holes in that contract: silent env reuse across assignees, dependent wakes firing before finalize, and `issue.interaction.accept` advancing before finalize landed. > - PAPA-441 / PAPA-442 then needed to document the "no remote git" contract and prevent future adapter/runtime code from quietly reintroducing `git push` as a backdoor sync. > - This pull request lands those server fixes, the static `check-no-git-push` enforcement, the AUTHORING.md cross-link, and the Cody-review follow-ups on the PAPA-430 thread. > - The benefit is that finalize is a real barrier — board accepts, dependent wakes, and operator-set env all respect it — and adapter code can't bypass it via raw `git push`. ## What Changed - **server (PAPA-380, PAPA-431):** `execution-workspace-policy` refuses silent env reuse when the assignee's resolved env disagrees with the workspace it would inherit. The inheritance protection is now scoped to the actual inheritance signal — explicit issue-level `environmentId` is honored even when the agent's default env is `null`. - **server (PAPA-432):** `heartbeat.ts` gates dependent wakes on `listUnfinalizedExecutionWorkspaceIds`, and writes a `workspace_finalize` row on the succeeded path. Write failures now surface instead of being swallowed so dependents aren't silently stranded behind a missing row. - **server (PAPA-440):** `issue-thread-interactions.acceptInteraction` adds a workspace_finalize precondition for `request_confirmation` (not `suggest_tasks`). Accept returns 409 if finalize hasn't succeeded for the latest workspace operation. - **ci (PAPA-442):** new `scripts/check-no-git-push.mjs` static check scans `packages/adapters/`, `packages/adapter-utils/`, `server/src/`, and `cli/src/` for any `git push` invocation (string or args-array). Wired into the `policy` PR job and `test:release-registry`. Operators can opt in per-call with `// paperclip:allow-git-push: <reason>`. Release scripts are out of scope by design. - **docs (PAPA-441):** `AUTHORING.md` documents the no-remote-git contract and cross-links the static check so adapter authors learn the rule and the enforcement together. - **review follow-up (PAPA-430, Cody):** three fixes — env resolver bug, accept-gate scope (request_confirmation only), and finalize record write on the succeeded path. ## Verification - `pnpm exec vitest run server/src/__tests__/execution-workspace-policy.test.ts server/src/__tests__/issue-thread-interactions-service.test.ts` → 33/33 pass - `node scripts/check-no-git-push.test.mjs` → check covers string form, args-array form, comment exclusions, and per-line allow-comment. - Manual: server compiles; the policy job runs the check in <1s before heavier jobs. ## Risks - **Behavioral shift in accept:** boards accepting `request_confirmation` while finalize is in-flight now get 409s. This is intentional — they can retry — but it changes timing on a hot path. `suggest_tasks` is unaffected. - **Workspace policy:** the env-reuse refusal is a new error path. Issues that previously silently reused an env from a different-assignee workspace will now fail-loud; the resolver still honors explicit issue-level `executionWorkspaceSettings.environmentId`. - **CI rule:** any future legitimate `git push` in scoped dirs must be marked with the allow-comment, which is the intended ergonomic. ## Model Used - Claude Opus 4.7 (`claude-opus-4-7`, extended thinking), via Claude Code in the Paperclip executor adapter. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots (N/A — server/CI/docs only) - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge Closes related issues: PAPA-430, PAPA-380, PAPA-431, PAPA-432, PAPA-440, PAPA-441, PAPA-442 --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
577 lines
23 KiB
TypeScript
577 lines
23 KiB
TypeScript
import { execFile } from "node:child_process";
|
|
import { mkdir, mkdtemp, readFile, rm, symlink, writeFile } from "node:fs/promises";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { afterEach, describe, expect, it } from "vitest";
|
|
import {
|
|
buildSshSpawnTarget,
|
|
buildSshEnvLabFixtureConfig,
|
|
getSshEnvLabSupport,
|
|
prepareWorkspaceForSshExecution,
|
|
readSshEnvLabFixtureStatus,
|
|
restoreWorkspaceFromSshExecution,
|
|
runSshCommand,
|
|
syncDirectoryToSsh,
|
|
startSshEnvLabFixture,
|
|
stopSshEnvLabFixture,
|
|
} from "./ssh.js";
|
|
import { prepareRemoteManagedRuntime } from "./remote-managed-runtime.js";
|
|
|
|
const SSH_FIXTURE_TEST_TIMEOUT_MS = 30_000;
|
|
let sshEnvLabUnsupportedReason: string | null = null;
|
|
|
|
async function git(cwd: string, args: string[]): Promise<string> {
|
|
return await new Promise((resolve, reject) => {
|
|
execFile("git", ["-C", cwd, ...args], (error, stdout, stderr) => {
|
|
if (error) {
|
|
reject(new Error((stderr || stdout || error.message).trim()));
|
|
return;
|
|
}
|
|
resolve(stdout.trim());
|
|
});
|
|
});
|
|
}
|
|
|
|
async function startSshEnvLabFixtureOrSkip(statePath: string, label: string) {
|
|
if (sshEnvLabUnsupportedReason) {
|
|
console.warn(`Skipping ${label}: ${sshEnvLabUnsupportedReason}`);
|
|
return null;
|
|
}
|
|
|
|
const support = await getSshEnvLabSupport();
|
|
if (!support.supported) {
|
|
sshEnvLabUnsupportedReason = support.reason ?? "unsupported environment";
|
|
console.warn(`Skipping ${label}: ${sshEnvLabUnsupportedReason}`);
|
|
return null;
|
|
}
|
|
|
|
try {
|
|
return await startSshEnvLabFixture({ statePath });
|
|
} catch (error) {
|
|
sshEnvLabUnsupportedReason = error instanceof Error ? error.message : String(error);
|
|
console.warn(`Skipping ${label}: ${sshEnvLabUnsupportedReason}`);
|
|
return null;
|
|
}
|
|
}
|
|
|
|
describe("ssh env-lab fixture", () => {
|
|
const cleanupDirs: string[] = [];
|
|
|
|
afterEach(async () => {
|
|
while (cleanupDirs.length > 0) {
|
|
const dir = cleanupDirs.pop();
|
|
if (!dir) continue;
|
|
await rm(dir, { recursive: true, force: true }).catch(() => undefined);
|
|
}
|
|
});
|
|
|
|
it("starts an isolated sshd fixture and executes commands through it", async () => {
|
|
const rootDir = await mkdtemp(path.join(os.tmpdir(), "paperclip-ssh-fixture-"));
|
|
cleanupDirs.push(rootDir);
|
|
const statePath = path.join(rootDir, "state.json");
|
|
|
|
const started = await startSshEnvLabFixtureOrSkip(statePath, "SSH env-lab fixture test");
|
|
if (!started) return;
|
|
const config = await buildSshEnvLabFixtureConfig(started);
|
|
const quotedWorkspace = JSON.stringify(started.workspaceDir);
|
|
const result = await runSshCommand(
|
|
config,
|
|
`cd ${quotedWorkspace} && pwd`,
|
|
);
|
|
|
|
expect(result.stdout.trim()).toBe(started.workspaceDir);
|
|
const status = await readSshEnvLabFixtureStatus(statePath);
|
|
expect(status.running).toBe(true);
|
|
|
|
await stopSshEnvLabFixture(statePath);
|
|
|
|
const stopped = await readSshEnvLabFixtureStatus(statePath);
|
|
expect(stopped.running).toBe(false);
|
|
}, SSH_FIXTURE_TEST_TIMEOUT_MS);
|
|
|
|
it("forwards stdin to remote SSH commands", async () => {
|
|
const rootDir = await mkdtemp(path.join(os.tmpdir(), "paperclip-ssh-fixture-"));
|
|
cleanupDirs.push(rootDir);
|
|
const statePath = path.join(rootDir, "state.json");
|
|
|
|
const started = await startSshEnvLabFixtureOrSkip(statePath, "SSH stdin forwarding test");
|
|
if (!started) return;
|
|
const config = await buildSshEnvLabFixtureConfig(started);
|
|
const remotePath = path.posix.join(started.workspaceDir, "stdin-forwarded.txt");
|
|
|
|
await runSshCommand(
|
|
config,
|
|
`cat > ${JSON.stringify(remotePath)}`,
|
|
{
|
|
stdin: "hello over ssh stdin\n",
|
|
timeoutMs: 30_000,
|
|
maxBuffer: 256 * 1024,
|
|
},
|
|
);
|
|
|
|
const result = await runSshCommand(
|
|
config,
|
|
`cat ${JSON.stringify(remotePath)}`,
|
|
{ timeoutMs: 30_000, maxBuffer: 256 * 1024 },
|
|
);
|
|
|
|
expect(result.stdout).toBe("hello over ssh stdin\n");
|
|
}, SSH_FIXTURE_TEST_TIMEOUT_MS);
|
|
|
|
it("does not treat an unrelated reused pid as the running fixture", async () => {
|
|
const rootDir = await mkdtemp(path.join(os.tmpdir(), "paperclip-ssh-fixture-"));
|
|
cleanupDirs.push(rootDir);
|
|
const statePath = path.join(rootDir, "state.json");
|
|
|
|
const started = await startSshEnvLabFixtureOrSkip(statePath, "SSH env-lab fixture test");
|
|
if (!started) return;
|
|
await stopSshEnvLabFixture(statePath);
|
|
await mkdir(path.dirname(statePath), { recursive: true });
|
|
|
|
await writeFile(
|
|
statePath,
|
|
JSON.stringify({ ...started, pid: process.pid }, null, 2),
|
|
{ mode: 0o600 },
|
|
);
|
|
|
|
const staleStatus = await readSshEnvLabFixtureStatus(statePath);
|
|
expect(staleStatus.running).toBe(false);
|
|
|
|
const restarted = await startSshEnvLabFixtureOrSkip(statePath, "SSH env-lab fixture restart test");
|
|
if (!restarted) return;
|
|
expect(restarted.pid).not.toBe(process.pid);
|
|
|
|
await stopSshEnvLabFixture(statePath);
|
|
}, SSH_FIXTURE_TEST_TIMEOUT_MS);
|
|
|
|
it("rejects invalid environment variable keys when constructing SSH spawn targets", async () => {
|
|
await expect(
|
|
buildSshSpawnTarget({
|
|
spec: {
|
|
host: "ssh.example.test",
|
|
port: 22,
|
|
username: "ssh-user",
|
|
remoteCwd: "/srv/paperclip/workspace",
|
|
remoteWorkspacePath: "/srv/paperclip/workspace",
|
|
privateKey: null,
|
|
knownHosts: null,
|
|
strictHostKeyChecking: true,
|
|
},
|
|
command: "env",
|
|
args: [],
|
|
env: {
|
|
"BAD KEY": "value",
|
|
},
|
|
}),
|
|
).rejects.toThrow("Invalid SSH environment variable key: BAD KEY");
|
|
});
|
|
|
|
it("syncs a local directory into the remote fixture workspace", async () => {
|
|
const rootDir = await mkdtemp(path.join(os.tmpdir(), "paperclip-ssh-fixture-"));
|
|
cleanupDirs.push(rootDir);
|
|
const statePath = path.join(rootDir, "state.json");
|
|
const localDir = path.join(rootDir, "local-overlay");
|
|
|
|
await mkdir(localDir, { recursive: true });
|
|
await writeFile(path.join(localDir, "message.txt"), "hello from paperclip\n", "utf8");
|
|
await writeFile(path.join(localDir, "._message.txt"), "should never sync\n", "utf8");
|
|
|
|
const started = await startSshEnvLabFixtureOrSkip(statePath, "SSH env-lab fixture test");
|
|
if (!started) return;
|
|
const config = await buildSshEnvLabFixtureConfig(started);
|
|
const remoteDir = path.posix.join(started.workspaceDir, "overlay");
|
|
|
|
await syncDirectoryToSsh({
|
|
spec: {
|
|
...config,
|
|
remoteCwd: started.workspaceDir,
|
|
},
|
|
localDir,
|
|
remoteDir,
|
|
});
|
|
|
|
const result = await runSshCommand(
|
|
config,
|
|
`cat ${JSON.stringify(path.posix.join(remoteDir, "message.txt"))} && if [ -e ${JSON.stringify(path.posix.join(remoteDir, "._message.txt"))} ]; then echo appledouble-present; fi`,
|
|
);
|
|
|
|
expect(result.stdout).toContain("hello from paperclip");
|
|
expect(result.stdout).not.toContain("appledouble-present");
|
|
}, SSH_FIXTURE_TEST_TIMEOUT_MS);
|
|
|
|
it("can dereference local symlinks while syncing to the remote fixture", async () => {
|
|
const rootDir = await mkdtemp(path.join(os.tmpdir(), "paperclip-ssh-fixture-"));
|
|
cleanupDirs.push(rootDir);
|
|
const statePath = path.join(rootDir, "state.json");
|
|
const sourceDir = path.join(rootDir, "source");
|
|
const localDir = path.join(rootDir, "local-overlay");
|
|
|
|
await mkdir(sourceDir, { recursive: true });
|
|
await mkdir(localDir, { recursive: true });
|
|
await writeFile(path.join(sourceDir, "auth.json"), "{\"token\":\"secret\"}\n", "utf8");
|
|
await symlink(path.join(sourceDir, "auth.json"), path.join(localDir, "auth.json"));
|
|
|
|
const started = await startSshEnvLabFixtureOrSkip(statePath, "SSH symlink sync test");
|
|
if (!started) return;
|
|
const config = await buildSshEnvLabFixtureConfig(started);
|
|
const remoteDir = path.posix.join(started.workspaceDir, "overlay-follow-links");
|
|
|
|
await syncDirectoryToSsh({
|
|
spec: {
|
|
...config,
|
|
remoteCwd: started.workspaceDir,
|
|
},
|
|
localDir,
|
|
remoteDir,
|
|
followSymlinks: true,
|
|
});
|
|
|
|
const result = await runSshCommand(
|
|
config,
|
|
`if [ -L ${JSON.stringify(path.posix.join(remoteDir, "auth.json"))} ]; then echo symlink; else echo regular; fi && cat ${JSON.stringify(path.posix.join(remoteDir, "auth.json"))}`,
|
|
);
|
|
|
|
expect(result.stdout).toContain("regular");
|
|
expect(result.stdout).toContain("{\"token\":\"secret\"}");
|
|
}, SSH_FIXTURE_TEST_TIMEOUT_MS);
|
|
|
|
it("round-trips a git workspace through the SSH fixture", async () => {
|
|
const rootDir = await mkdtemp(path.join(os.tmpdir(), "paperclip-ssh-fixture-"));
|
|
cleanupDirs.push(rootDir);
|
|
const statePath = path.join(rootDir, "state.json");
|
|
const localRepo = path.join(rootDir, "local-workspace");
|
|
|
|
await mkdir(localRepo, { recursive: true });
|
|
await git(localRepo, ["init"]);
|
|
await git(localRepo, ["checkout", "-b", "main"]);
|
|
await git(localRepo, ["config", "user.name", "Paperclip Test"]);
|
|
await git(localRepo, ["config", "user.email", "test@paperclip.dev"]);
|
|
await writeFile(path.join(localRepo, "tracked.txt"), "base\n", "utf8");
|
|
await writeFile(path.join(localRepo, "._tracked.txt"), "should stay local only\n", "utf8");
|
|
await git(localRepo, ["add", "tracked.txt"]);
|
|
await git(localRepo, ["commit", "-m", "initial"]);
|
|
const originalHead = await git(localRepo, ["rev-parse", "HEAD"]);
|
|
await writeFile(path.join(localRepo, "tracked.txt"), "dirty local\n", "utf8");
|
|
await writeFile(path.join(localRepo, "untracked.txt"), "from local\n", "utf8");
|
|
|
|
const started = await startSshEnvLabFixtureOrSkip(statePath, "SSH workspace round-trip test");
|
|
if (!started) return;
|
|
const config = await buildSshEnvLabFixtureConfig(started);
|
|
const spec = {
|
|
...config,
|
|
remoteCwd: started.workspaceDir,
|
|
} as const;
|
|
|
|
await prepareWorkspaceForSshExecution({
|
|
spec,
|
|
localDir: localRepo,
|
|
remoteDir: started.workspaceDir,
|
|
});
|
|
|
|
const remoteStatus = await runSshCommand(
|
|
config,
|
|
`cd ${JSON.stringify(started.workspaceDir)} && git status --short`,
|
|
);
|
|
expect(remoteStatus.stdout).toContain("M tracked.txt");
|
|
expect(remoteStatus.stdout).toContain("?? untracked.txt");
|
|
expect(remoteStatus.stdout).not.toContain("._tracked.txt");
|
|
|
|
await runSshCommand(
|
|
config,
|
|
`cd ${JSON.stringify(started.workspaceDir)} && git config user.name "Paperclip SSH" && git config user.email "ssh@paperclip.dev" && git add tracked.txt untracked.txt && git commit -m "remote update" >/dev/null && printf "remote dirty\\n" > tracked.txt && printf "remote extra\\n" > remote-only.txt`,
|
|
{ timeoutMs: 30_000, maxBuffer: 256 * 1024 },
|
|
);
|
|
|
|
await restoreWorkspaceFromSshExecution({
|
|
spec,
|
|
localDir: localRepo,
|
|
remoteDir: started.workspaceDir,
|
|
});
|
|
|
|
const restoredHead = await git(localRepo, ["rev-parse", "HEAD"]);
|
|
expect(restoredHead).not.toBe(originalHead);
|
|
expect(await git(localRepo, ["log", "-1", "--pretty=%s"])).toBe("remote update");
|
|
expect(await git(localRepo, ["status", "--short"])).toContain("M tracked.txt");
|
|
expect(await git(localRepo, ["status", "--short"])).not.toContain("._tracked.txt");
|
|
}, SSH_FIXTURE_TEST_TIMEOUT_MS);
|
|
|
|
it("preserves both concurrent SSH restores in a shared git workspace", async () => {
|
|
const rootDir = await mkdtemp(path.join(os.tmpdir(), "paperclip-ssh-fixture-"));
|
|
cleanupDirs.push(rootDir);
|
|
const statePath = path.join(rootDir, "state.json");
|
|
const localRepo = path.join(rootDir, "local-workspace");
|
|
|
|
await mkdir(localRepo, { recursive: true });
|
|
await git(localRepo, ["init"]);
|
|
await git(localRepo, ["checkout", "-b", "main"]);
|
|
await git(localRepo, ["config", "user.name", "Paperclip Test"]);
|
|
await git(localRepo, ["config", "user.email", "test@paperclip.dev"]);
|
|
await writeFile(path.join(localRepo, "tracked.txt"), "base\n", "utf8");
|
|
await git(localRepo, ["add", "tracked.txt"]);
|
|
await git(localRepo, ["commit", "-m", "initial"]);
|
|
|
|
const started = await startSshEnvLabFixtureOrSkip(statePath, "concurrent SSH restore test");
|
|
if (!started) return;
|
|
const config = await buildSshEnvLabFixtureConfig(started);
|
|
const spec = {
|
|
...config,
|
|
remoteCwd: started.workspaceDir,
|
|
} as const;
|
|
|
|
const preparedA = await prepareRemoteManagedRuntime({
|
|
spec,
|
|
runId: "run-a",
|
|
adapterKey: "test-adapter",
|
|
workspaceLocalDir: localRepo,
|
|
});
|
|
const preparedB = await prepareRemoteManagedRuntime({
|
|
spec,
|
|
runId: "run-b",
|
|
adapterKey: "test-adapter",
|
|
workspaceLocalDir: localRepo,
|
|
});
|
|
|
|
expect(preparedA.workspaceRemoteDir).not.toBe(preparedB.workspaceRemoteDir);
|
|
|
|
await runSshCommand(
|
|
config,
|
|
`printf "from run a\\n" > ${JSON.stringify(path.posix.join(preparedA.workspaceRemoteDir, "run-a.txt"))}`,
|
|
{ timeoutMs: 30_000, maxBuffer: 256 * 1024 },
|
|
);
|
|
await runSshCommand(
|
|
config,
|
|
`printf "from run b\\n" > ${JSON.stringify(path.posix.join(preparedB.workspaceRemoteDir, "run-b.txt"))}`,
|
|
{ timeoutMs: 30_000, maxBuffer: 256 * 1024 },
|
|
);
|
|
|
|
await Promise.all([
|
|
preparedA.restoreWorkspace(),
|
|
preparedB.restoreWorkspace(),
|
|
]);
|
|
|
|
await expect(readFile(path.join(localRepo, "run-a.txt"), "utf8")).resolves.toBe("from run a\n");
|
|
await expect(readFile(path.join(localRepo, "run-b.txt"), "utf8")).resolves.toBe("from run b\n");
|
|
}, SSH_FIXTURE_TEST_TIMEOUT_MS);
|
|
|
|
it("preserves nested per-run files across sequential SSH restores with stale baselines", async () => {
|
|
const rootDir = await mkdtemp(path.join(os.tmpdir(), "paperclip-ssh-fixture-"));
|
|
cleanupDirs.push(rootDir);
|
|
const statePath = path.join(rootDir, "state.json");
|
|
const localRepo = path.join(rootDir, "local-workspace");
|
|
|
|
await mkdir(localRepo, { recursive: true });
|
|
await git(localRepo, ["init"]);
|
|
await git(localRepo, ["checkout", "-b", "main"]);
|
|
await git(localRepo, ["config", "user.name", "Paperclip Test"]);
|
|
await git(localRepo, ["config", "user.email", "test@paperclip.dev"]);
|
|
await writeFile(path.join(localRepo, "tracked.txt"), "base\n", "utf8");
|
|
await git(localRepo, ["add", "tracked.txt"]);
|
|
await git(localRepo, ["commit", "-m", "initial"]);
|
|
|
|
const started = await startSshEnvLabFixtureOrSkip(statePath, "sequential nested SSH restore test");
|
|
if (!started) return;
|
|
const config = await buildSshEnvLabFixtureConfig(started);
|
|
const spec = {
|
|
...config,
|
|
remoteCwd: started.workspaceDir,
|
|
} as const;
|
|
|
|
const preparedA = await prepareRemoteManagedRuntime({
|
|
spec,
|
|
runId: "run-a",
|
|
adapterKey: "test-adapter",
|
|
workspaceLocalDir: localRepo,
|
|
});
|
|
const preparedB = await prepareRemoteManagedRuntime({
|
|
spec,
|
|
runId: "run-b",
|
|
adapterKey: "test-adapter",
|
|
workspaceLocalDir: localRepo,
|
|
});
|
|
|
|
await runSshCommand(
|
|
config,
|
|
`mkdir -p ${JSON.stringify(path.posix.join(preparedA.workspaceRemoteDir, "manual-qa/environment-matrix/ssh"))} && printf "from run a\\n" > ${JSON.stringify(path.posix.join(preparedA.workspaceRemoteDir, "manual-qa/environment-matrix/ssh/claude_local.md"))}`,
|
|
{ timeoutMs: 30_000, maxBuffer: 256 * 1024 },
|
|
);
|
|
await runSshCommand(
|
|
config,
|
|
`mkdir -p ${JSON.stringify(path.posix.join(preparedB.workspaceRemoteDir, "manual-qa/environment-matrix/ssh"))} && printf "from run b\\n" > ${JSON.stringify(path.posix.join(preparedB.workspaceRemoteDir, "manual-qa/environment-matrix/ssh/codex_local.md"))}`,
|
|
{ timeoutMs: 30_000, maxBuffer: 256 * 1024 },
|
|
);
|
|
|
|
await preparedA.restoreWorkspace();
|
|
await preparedB.restoreWorkspace();
|
|
|
|
await expect(readFile(path.join(localRepo, "manual-qa/environment-matrix/ssh/claude_local.md"), "utf8")).resolves
|
|
.toBe("from run a\n");
|
|
await expect(readFile(path.join(localRepo, "manual-qa/environment-matrix/ssh/codex_local.md"), "utf8")).resolves
|
|
.toBe("from run b\n");
|
|
}, SSH_FIXTURE_TEST_TIMEOUT_MS);
|
|
|
|
it("round-trips remote git commits through the managed runtime restore path", async () => {
|
|
const rootDir = await mkdtemp(path.join(os.tmpdir(), "paperclip-ssh-fixture-"));
|
|
cleanupDirs.push(rootDir);
|
|
const statePath = path.join(rootDir, "state.json");
|
|
const localRepo = path.join(rootDir, "local-workspace");
|
|
|
|
await mkdir(localRepo, { recursive: true });
|
|
await git(localRepo, ["init"]);
|
|
await git(localRepo, ["checkout", "-b", "main"]);
|
|
await git(localRepo, ["config", "user.name", "Paperclip Test"]);
|
|
await git(localRepo, ["config", "user.email", "test@paperclip.dev"]);
|
|
await writeFile(path.join(localRepo, "tracked.txt"), "base\n", "utf8");
|
|
await git(localRepo, ["add", "tracked.txt"]);
|
|
await git(localRepo, ["commit", "-m", "initial"]);
|
|
|
|
const started = await startSshEnvLabFixtureOrSkip(statePath, "managed-runtime SSH git round-trip test");
|
|
if (!started) return;
|
|
const config = await buildSshEnvLabFixtureConfig(started);
|
|
const spec = {
|
|
...config,
|
|
remoteCwd: started.workspaceDir,
|
|
} as const;
|
|
|
|
const prepared = await prepareRemoteManagedRuntime({
|
|
spec,
|
|
runId: "run-commit",
|
|
adapterKey: "test-adapter",
|
|
workspaceLocalDir: localRepo,
|
|
});
|
|
|
|
await runSshCommand(
|
|
config,
|
|
`cd ${JSON.stringify(prepared.workspaceRemoteDir)} && git config user.name "Paperclip SSH" && git config user.email "ssh@paperclip.dev" && printf "committed\\n" > tracked.txt && git add tracked.txt && git commit -m "remote update" >/dev/null && printf "dirty remote\\n" > tracked.txt`,
|
|
{ timeoutMs: 30_000, maxBuffer: 256 * 1024 },
|
|
);
|
|
|
|
await prepared.restoreWorkspace();
|
|
|
|
expect(await git(localRepo, ["log", "-1", "--pretty=%s"])).toBe("remote update");
|
|
await expect(readFile(path.join(localRepo, "tracked.txt"), "utf8")).resolves.toBe("dirty remote\n");
|
|
}, SSH_FIXTURE_TEST_TIMEOUT_MS);
|
|
|
|
it("propagates remote commits to the local worktree with no git remote configured (no-remote-git contract)", async () => {
|
|
// Locks in the architectural contract documented in
|
|
// packages/adapter-utils/README.md and packages/adapters/AUTHORING.md:
|
|
// the local execution-workspace cwd is the only persistence boundary
|
|
// across runs. No adapter may depend on a git remote for cross-run state.
|
|
const rootDir = await mkdtemp(path.join(os.tmpdir(), "paperclip-ssh-fixture-"));
|
|
cleanupDirs.push(rootDir);
|
|
const statePath = path.join(rootDir, "state.json");
|
|
const localRepo = path.join(rootDir, "local-workspace");
|
|
|
|
await mkdir(localRepo, { recursive: true });
|
|
await git(localRepo, ["init"]);
|
|
await git(localRepo, ["checkout", "-b", "main"]);
|
|
await git(localRepo, ["config", "user.name", "Paperclip Test"]);
|
|
await git(localRepo, ["config", "user.email", "test@paperclip.dev"]);
|
|
await writeFile(path.join(localRepo, "tracked.txt"), "base\n", "utf8");
|
|
await git(localRepo, ["add", "tracked.txt"]);
|
|
await git(localRepo, ["commit", "-m", "initial"]);
|
|
|
|
// Assert there is no git remote configured before we begin, and verify
|
|
// that no point in the round-trip introduces one. `git remote` returns an
|
|
// empty string when no remotes exist (and exit code 0).
|
|
expect(await git(localRepo, ["remote"])).toBe("");
|
|
|
|
const started = await startSshEnvLabFixtureOrSkip(
|
|
statePath,
|
|
"no-remote-git contract test",
|
|
);
|
|
if (!started) return;
|
|
const config = await buildSshEnvLabFixtureConfig(started);
|
|
const spec = {
|
|
...config,
|
|
remoteCwd: started.workspaceDir,
|
|
} as const;
|
|
|
|
const prepared = await prepareRemoteManagedRuntime({
|
|
spec,
|
|
runId: "run-no-remote",
|
|
adapterKey: "test-adapter",
|
|
workspaceLocalDir: localRepo,
|
|
});
|
|
|
|
// Remote commit lands a deliverable that must show up locally via
|
|
// sync-back alone — no `git push`, no fetch from any origin.
|
|
await runSshCommand(
|
|
config,
|
|
`cd ${JSON.stringify(prepared.workspaceRemoteDir)} && git config user.name "Paperclip SSH" && git config user.email "ssh@paperclip.dev" && printf "deliverable\\n" > tracked.txt && git add tracked.txt && git commit -m "remote-only commit" >/dev/null`,
|
|
{ timeoutMs: 30_000, maxBuffer: 256 * 1024 },
|
|
);
|
|
|
|
await prepared.restoreWorkspace();
|
|
|
|
expect(await git(localRepo, ["log", "-1", "--pretty=%s"])).toBe(
|
|
"remote-only commit",
|
|
);
|
|
expect(await readFile(path.join(localRepo, "tracked.txt"), "utf8")).toBe(
|
|
"deliverable\n",
|
|
);
|
|
// Final assertion: still no git remote — restore did not silently add one.
|
|
expect(await git(localRepo, ["remote"])).toBe("");
|
|
}, SSH_FIXTURE_TEST_TIMEOUT_MS);
|
|
|
|
it("merges concurrent remote commits through the managed runtime restore path", async () => {
|
|
const rootDir = await mkdtemp(path.join(os.tmpdir(), "paperclip-ssh-fixture-"));
|
|
cleanupDirs.push(rootDir);
|
|
const statePath = path.join(rootDir, "state.json");
|
|
const localRepo = path.join(rootDir, "local-workspace");
|
|
|
|
await mkdir(localRepo, { recursive: true });
|
|
await git(localRepo, ["init"]);
|
|
await git(localRepo, ["checkout", "-b", "main"]);
|
|
await git(localRepo, ["config", "user.name", "Paperclip Test"]);
|
|
await git(localRepo, ["config", "user.email", "test@paperclip.dev"]);
|
|
await writeFile(path.join(localRepo, "tracked.txt"), "base\n", "utf8");
|
|
await git(localRepo, ["add", "tracked.txt"]);
|
|
await git(localRepo, ["commit", "-m", "initial"]);
|
|
|
|
const started = await startSshEnvLabFixtureOrSkip(statePath, "concurrent managed-runtime SSH git merge test");
|
|
if (!started) return;
|
|
const config = await buildSshEnvLabFixtureConfig(started);
|
|
const spec = {
|
|
...config,
|
|
remoteCwd: started.workspaceDir,
|
|
} as const;
|
|
|
|
const preparedA = await prepareRemoteManagedRuntime({
|
|
spec,
|
|
runId: "run-commit-a",
|
|
adapterKey: "test-adapter",
|
|
workspaceLocalDir: localRepo,
|
|
});
|
|
const preparedB = await prepareRemoteManagedRuntime({
|
|
spec,
|
|
runId: "run-commit-b",
|
|
adapterKey: "test-adapter",
|
|
workspaceLocalDir: localRepo,
|
|
});
|
|
|
|
await runSshCommand(
|
|
config,
|
|
`cd ${JSON.stringify(preparedA.workspaceRemoteDir)} && git config user.name "Paperclip SSH" && git config user.email "ssh@paperclip.dev" && printf "from run a\\n" > run-a.txt && git add run-a.txt && git commit -m "remote update a" >/dev/null`,
|
|
{ timeoutMs: 30_000, maxBuffer: 256 * 1024 },
|
|
);
|
|
await runSshCommand(
|
|
config,
|
|
`cd ${JSON.stringify(preparedB.workspaceRemoteDir)} && git config user.name "Paperclip SSH" && git config user.email "ssh@paperclip.dev" && printf "from run b\\n" > run-b.txt && git add run-b.txt && git commit -m "remote update b" >/dev/null`,
|
|
{ timeoutMs: 30_000, maxBuffer: 256 * 1024 },
|
|
);
|
|
|
|
await Promise.all([
|
|
preparedA.restoreWorkspace(),
|
|
preparedB.restoreWorkspace(),
|
|
]);
|
|
|
|
await expect(readFile(path.join(localRepo, "run-a.txt"), "utf8")).resolves.toBe("from run a\n");
|
|
await expect(readFile(path.join(localRepo, "run-b.txt"), "utf8")).resolves.toBe("from run b\n");
|
|
expect(await git(localRepo, ["log", "-1", "--pretty=%s"])).toContain("Paperclip SSH sync merge");
|
|
|
|
const recentSubjects = await git(localRepo, ["log", "--pretty=%s", "-3"]);
|
|
expect(recentSubjects).toContain("remote update a");
|
|
expect(recentSubjects).toContain("remote update b");
|
|
}, SSH_FIXTURE_TEST_TIMEOUT_MS);
|
|
});
|