forked from farhoodlabs/paperclip
6b7f6ce4b8
## Thinking Path > - Paperclip orchestrates AI agents through a company-scoped control plane. > - The affected surface is the board UI for issue threads, issue lists, routines, dialogs, navigation, and issue review indicators. > - Closed PR #4692 bundled backend, schema, docs, workflow, and UI/QoL work into one oversized change set. > - Greptile could not keep reviewing that broad PR because it exceeded the 100-file review limit and mixed unrelated concerns. > - This pull request extracts the UI/QoL slice into a fresh branch under the review limit while leaving workflow and lockfile churn out. > - The benefit is a focused review path for the board UI performance and workflow improvements without reopening the oversized PR. ## What Changed - Added long issue-thread virtualization, scroll-container binding, anchor preservation, latest-comment jump targeting, and related regression/perf fixtures. - Improved issue list scalability with scroll-based loading, server offset parameters, and pagination-focused UI tests. - Reduced new issue dialog typing churn and split dialog action subscriptions so broad layout/nav surfaces avoid unnecessary renders. - Added routine variables help and routine description mention options for users, agents, and projects. - Added productivity review badge/link UI and fixed the badge to use Paperclip's company-prefixed router link. - Kept the split PR below Greptile's review limit and excluded `.github/workflows/pr.yml` and `pnpm-lock.yaml`. ## Verification - `pnpm install --no-frozen-lockfile` in the clean worktree to install `@tanstack/react-virtual` locally without committing lockfile churn. - `pnpm --filter @paperclipai/ui exec vitest run --config vitest.config.ts src/components/IssueChatThread.test.tsx src/components/IssuesList.test.tsx src/components/NewIssueDialog.test.tsx src/pages/Routines.test.tsx src/pages/Issues.test.tsx` passed: 5 files, 83 tests. - `pnpm --filter @paperclipai/ui typecheck` passed. - `git diff --check origin/master..HEAD` passed. - Split-scope checks: 53 changed files; no `.github/workflows/pr.yml`; no `pnpm-lock.yaml`. - Screenshots were not captured in this heartbeat; the changes are primarily virtualization, routing, pagination, and editor behavior covered by focused regression tests. ## Risks - Moderate UI risk because issue-thread virtualization changes scroll behavior on long conversations; regression tests cover anchor jumps, latest-comment targeting, row metadata, and short-thread fallback. - Moderate integration risk because the issue-list offset parameter and productivity review field depend on matching API behavior. - Dependency risk: the UI package adds `@tanstack/react-virtual` while repository policy keeps `pnpm-lock.yaml` out of PRs, so CI must resolve dependency changes through the repo's normal lockfile policy. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent, tool-enabled local repository and GitHub workflow. Exact runtime context window was not exposed by the harness. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
214 lines
8.8 KiB
TypeScript
214 lines
8.8 KiB
TypeScript
import { Profiler, useEffect, useLayoutEffect, useMemo, useRef, useState, type ProfilerOnRenderCallback } from "react";
|
|
import { Badge } from "@/components/ui/badge";
|
|
import { Card, CardContent, CardHeader, CardTitle } from "@/components/ui/card";
|
|
import { IssueChatThread } from "../components/IssueChatThread";
|
|
import {
|
|
issueChatLongThreadAgentMap,
|
|
issueChatLongThreadComments,
|
|
issueChatLongThreadEvents,
|
|
issueChatLongThreadFixtureContext,
|
|
issueChatLongThreadLinkedRuns,
|
|
issueChatLongThreadLiveRuns,
|
|
issueChatLongThreadMarkdownCommentIds,
|
|
issueChatLongThreadTranscriptsByRunId,
|
|
LONG_THREAD_COMMENT_COUNT,
|
|
LONG_THREAD_MARKDOWN_COMMENT_COUNT,
|
|
} from "../fixtures/issueChatLongThreadFixture";
|
|
|
|
const noop = async () => {};
|
|
|
|
type RenderMetrics = {
|
|
commitCount: number;
|
|
mountActualDuration: number | null;
|
|
latestActualDuration: number | null;
|
|
maxActualDuration: number;
|
|
totalActualDuration: number;
|
|
};
|
|
|
|
const initialMetrics: RenderMetrics = {
|
|
commitCount: 0,
|
|
mountActualDuration: null,
|
|
latestActualDuration: null,
|
|
maxActualDuration: 0,
|
|
totalActualDuration: 0,
|
|
};
|
|
|
|
function formatMs(value: number | null) {
|
|
if (value === null || !Number.isFinite(value)) return "pending";
|
|
return `${value.toFixed(1)} ms`;
|
|
}
|
|
|
|
function MetricTile({ label, value, testId }: { label: string; value: string; testId: string }) {
|
|
return (
|
|
<div className="rounded-md border border-border bg-background px-3 py-2">
|
|
<div className="text-[11px] font-medium uppercase tracking-[0.14em] text-muted-foreground">
|
|
{label}
|
|
</div>
|
|
<div data-testid={testId} className="mt-1 font-mono text-sm text-foreground">
|
|
{value}
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
export function IssueChatLongThreadPerf() {
|
|
const [metrics, setMetrics] = useState<RenderMetrics>(initialMetrics);
|
|
const metricsRef = useRef<RenderMetrics>(initialMetrics);
|
|
const renderStartedAtRef = useRef(performance.now());
|
|
const publishTimerRef = useRef<number | null>(null);
|
|
const publishedRef = useRef(false);
|
|
const fixture = issueChatLongThreadFixtureContext;
|
|
const rowTarget = useMemo(
|
|
() => LONG_THREAD_COMMENT_COUNT + issueChatLongThreadEvents.length + issueChatLongThreadLinkedRuns.length,
|
|
[],
|
|
);
|
|
|
|
useEffect(() => () => {
|
|
if (publishTimerRef.current !== null) {
|
|
window.clearTimeout(publishTimerRef.current);
|
|
}
|
|
}, []);
|
|
|
|
useLayoutEffect(() => {
|
|
if (publishedRef.current || metricsRef.current.commitCount > 0) return;
|
|
const mountDuration = performance.now() - renderStartedAtRef.current;
|
|
const next = {
|
|
commitCount: 1,
|
|
mountActualDuration: mountDuration,
|
|
latestActualDuration: mountDuration,
|
|
maxActualDuration: mountDuration,
|
|
totalActualDuration: mountDuration,
|
|
};
|
|
metricsRef.current = next;
|
|
publishedRef.current = true;
|
|
setMetrics(next);
|
|
}, []);
|
|
|
|
const handleRender: ProfilerOnRenderCallback = (_id, phase, actualDuration) => {
|
|
const current = metricsRef.current;
|
|
metricsRef.current = {
|
|
commitCount: current.commitCount + 1,
|
|
mountActualDuration: phase === "mount" && current.mountActualDuration === null
|
|
? actualDuration
|
|
: current.mountActualDuration,
|
|
latestActualDuration: actualDuration,
|
|
maxActualDuration: Math.max(current.maxActualDuration, actualDuration),
|
|
totalActualDuration: current.totalActualDuration + actualDuration,
|
|
};
|
|
|
|
if (publishedRef.current || publishTimerRef.current !== null) return;
|
|
publishTimerRef.current = window.setTimeout(() => {
|
|
publishTimerRef.current = null;
|
|
publishedRef.current = true;
|
|
setMetrics(metricsRef.current);
|
|
}, 0);
|
|
};
|
|
|
|
return (
|
|
<div data-testid="issue-chat-long-thread-perf" className="space-y-5">
|
|
<div className="flex flex-col gap-3 border-b border-border pb-5 lg:flex-row lg:items-end lg:justify-between">
|
|
<div className="min-w-0">
|
|
<div className="flex flex-wrap items-center gap-2">
|
|
<Badge variant="outline" className="font-mono text-[11px]">
|
|
{fixture.issue.identifier}
|
|
</Badge>
|
|
<Badge variant="secondary">{fixture.issue.status.replace(/_/g, " ")}</Badge>
|
|
<Badge variant="outline">{fixture.issue.projectName}</Badge>
|
|
</div>
|
|
<h1 className="mt-3 text-2xl font-semibold tracking-tight">{fixture.issue.title}</h1>
|
|
<p className="mt-2 max-w-3xl text-sm leading-6 text-muted-foreground">
|
|
Deterministic local fixture for measuring the current direct-render issue chat path with
|
|
hundreds of merged thread rows, markdown-heavy assistant bodies, linked runs, documents,
|
|
sub-issues, and sidebar context.
|
|
</p>
|
|
</div>
|
|
<div className="grid min-w-[280px] grid-cols-2 gap-2">
|
|
<MetricTile label="Fixture rows" value={String(rowTarget)} testId="perf-fixture-row-target" />
|
|
<MetricTile label="Markdown rows" value={String(LONG_THREAD_MARKDOWN_COMMENT_COUNT)} testId="perf-fixture-markdown-rows" />
|
|
</div>
|
|
</div>
|
|
|
|
<div className="grid gap-4 xl:grid-cols-[minmax(0,1fr)_320px]">
|
|
<main className="min-w-0 space-y-4">
|
|
<Card className="border-border/70">
|
|
<CardHeader className="pb-2">
|
|
<CardTitle className="text-base">Issue documents</CardTitle>
|
|
</CardHeader>
|
|
<CardContent className="grid gap-2 sm:grid-cols-2">
|
|
{fixture.documents.map((document) => (
|
|
<div key={document} className="rounded-md border border-border bg-muted/30 px-3 py-2 text-sm">
|
|
{document}
|
|
</div>
|
|
))}
|
|
</CardContent>
|
|
</Card>
|
|
|
|
<Card className="border-border/70">
|
|
<CardHeader className="pb-2">
|
|
<CardTitle className="text-base">Sub-issues</CardTitle>
|
|
</CardHeader>
|
|
<CardContent className="space-y-2">
|
|
{fixture.subIssues.map((subIssue, index) => (
|
|
<div key={subIssue} className="flex items-center gap-3 rounded-md border border-border bg-background px-3 py-2 text-sm">
|
|
<span className="font-mono text-xs text-muted-foreground">#{index + 1}</span>
|
|
<span>{subIssue}</span>
|
|
</div>
|
|
))}
|
|
</CardContent>
|
|
</Card>
|
|
|
|
<Profiler id="issue-chat-long-thread" onRender={handleRender}>
|
|
<IssueChatThread
|
|
comments={issueChatLongThreadComments}
|
|
linkedRuns={issueChatLongThreadLinkedRuns}
|
|
timelineEvents={issueChatLongThreadEvents}
|
|
liveRuns={issueChatLongThreadLiveRuns}
|
|
issueStatus="in_progress"
|
|
agentMap={issueChatLongThreadAgentMap}
|
|
currentUserId="user-board"
|
|
onAdd={noop}
|
|
showComposer={false}
|
|
showJumpToLatest={false}
|
|
enableLiveTranscriptPolling={false}
|
|
transcriptsByRunId={issueChatLongThreadTranscriptsByRunId}
|
|
hasOutputForRun={(runId) => issueChatLongThreadTranscriptsByRunId.has(runId)}
|
|
/>
|
|
</Profiler>
|
|
</main>
|
|
|
|
<aside className="space-y-4 xl:sticky xl:top-4 xl:self-start">
|
|
<Card className="border-border/70">
|
|
<CardHeader className="pb-2">
|
|
<CardTitle className="text-base">Baseline metrics</CardTitle>
|
|
</CardHeader>
|
|
<CardContent className="grid gap-2">
|
|
<MetricTile label="Profiler commits" value={String(metrics.commitCount)} testId="perf-commit-count" />
|
|
<MetricTile label="Mount duration" value={formatMs(metrics.mountActualDuration)} testId="perf-mount-duration" />
|
|
<MetricTile label="Latest duration" value={formatMs(metrics.latestActualDuration)} testId="perf-latest-duration" />
|
|
<MetricTile label="Max duration" value={formatMs(metrics.maxActualDuration)} testId="perf-max-duration" />
|
|
<MetricTile label="Total duration" value={formatMs(metrics.totalActualDuration)} testId="perf-total-duration" />
|
|
</CardContent>
|
|
</Card>
|
|
|
|
<Card className="border-border/70">
|
|
<CardHeader className="pb-2">
|
|
<CardTitle className="text-base">Fixture shape</CardTitle>
|
|
</CardHeader>
|
|
<CardContent className="space-y-2">
|
|
{fixture.sidebarStats.map(([label, value]) => (
|
|
<div key={label} className="flex items-center justify-between gap-3 text-sm">
|
|
<span className="text-muted-foreground">{label}</span>
|
|
<span className="font-mono">{value}</span>
|
|
</div>
|
|
))}
|
|
<div className="hidden" data-testid="perf-markdown-comment-id-sample">
|
|
{[...issueChatLongThreadMarkdownCommentIds].slice(0, 3).join(",")}
|
|
</div>
|
|
</CardContent>
|
|
</Card>
|
|
</aside>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|