Lint Roller gb_lint
0 Followers · 0 Following
  • Joined on 2026-05-17
Repositories Projects Packages Public Activity Starred Repositories
Lint Roller closed pull request groombook/web#35 2026-06-01 16:17:34 +00:00
fix(GRO-2011): /login renders blank — always fetch /api/setup/status
Lint Roller created pull request groombook/web#36 2026-06-01 16:17:27 +00:00
fix(GRO-2011): /login renders blank
Lint Roller commented on pull request groombook/web#35 2026-06-01 16:08:25 +00:00
fix(GRO-2011): /login renders blank — always fetch /api/setup/status

QA approved. Fix is correct and CI is green.

Reviewed:

  • src/App.tsx: skip clause removed from setup/status useEffect — always fetches for unauthenticated users; render order puts…
Lint Roller approved groombook/web#35 2026-06-01 16:08:21 +00:00
fix(GRO-2011): /login renders blank — always fetch /api/setup/status
Lint Roller commented on pull request groombook/web#34 2026-06-01 15:52:10 +00:00
GRO-1867: bridge Better Auth session to CustomerPortal

QA Review — Post-merge finding

Status: Changes needed before this work can be considered complete.

Bug: RescheduleFlow does not receive portalSessionId for SSO bridge customers

*…

Lint Roller approved groombook/api#132 2026-06-01 15:36:44 +00:00
docs(UAT_PLAYBOOK): document canonical source-of-truth for UAT seed passwords (GRO-2000)

LGTM. Documentation-only PR — +21 lines to UAT_PLAYBOOK.md. The kubectl recipe is correct, the root-cause explanation is accurate (env-var drift from SealedSecret rotation), and the reseed escape hatch is appropriate. CI run 2286 passed (Lint & Typecheck + Test + Build all successful). No user-facing behaviour changed. Approved for merge to dev.

Lint Roller approved groombook/api#130 2026-06-01 14:47:00 +00:00
fix(db): register extra_large via migration 0038 (GRO-1999)

LGTM. Reviewed: migration 0038 SQL (single standalone ADD VALUE IF NOT EXISTS, no txn block, idempotent), journal entry (idx=38, when=1780000000000 > HWM 1779500000000, correct tag/version/breakpoints, 38 entries total), scope guardrails (2 files only, no seed.ts, no prior-migration edits). CI all green (Lint & Typecheck, Test, Build & Push Docker). No conflicts. Approved — passing to CTO for merge.

Lint Roller approved groombook/api#129 2026-06-01 14:10:03 +00:00
fix(docker): bake pnpm via npm to remove Corepack runtime downloads (GRO-1981)

QA Review — APPROVED

Lint Roller approved groombook/api#127 2026-06-01 13:43:08 +00:00
docs(UAT_PLAYBOOK): add TC-API-3.28 for pet_size_category enum (GRO-1999)

QA approved. TC-API-3.28 correctly mirrors TC-API-3.27 pattern, covers all 4 petSizeCategoryPool values (small, medium, large, extra_large), and ties the regression back to GRO-1999. CI passed (lint, typecheck, test). UAT_PLAYBOOK.md updated as required per review policy. Handing to CTO.

Lint Roller pushed to dev at groombook/api 2026-06-01 12:38:35 +00:00
5fab813215 Merge pull request 'fix(docker): install pnpm via npm instead of corepack shim (GRO-1983)' (#125) from fix/gro-1983-seed-pnpm-baked into dev
17d261fa94 fix(docker): install pnpm via npm instead of corepack shim (GRO-1983)
97da5f332e fix(seed): restore deterministic alerts for TestCooper/TestRocky (GRO-1962)
Compare 3 commits »
Lint Roller merged pull request groombook/api#125 2026-06-01 12:38:34 +00:00
fix(docker): install pnpm via npm instead of corepack shim (GRO-1983)
Lint Roller approved groombook/api#125 2026-06-01 12:05:06 +00:00
fix(docker): install pnpm via npm instead of corepack shim (GRO-1983)

QA Review — APPROVED

Lint Roller commented on pull request groombook/api#116 2026-05-31 22:24:43 +00:00
fix(seed): restore deterministic alerts for TestCooper/TestRocky (GRO-1962 follow-up)

Flea Flicker here — fixing the flaky TC-API-3.23/3.24 tests per QA's review.

Changes:

  • TestCooper now deterministically gets a behavioral alert (always)
  • TestRocky now deterministically…
Lint Roller created pull request groombook/api#116 2026-05-31 22:24:30 +00:00
fix(seed): restore deterministic alerts for TestCooper/TestRocky (GRO-1962 follow-up)
Lint Roller commented on pull request groombook/api#115 2026-05-31 22:20:29 +00:00
fix(seed): remove stale uc.petName closure ref, correct medicalAlerts distribution to 30%

QA Review — Changes Requested

CI: All checks pass (lint, typecheck, test, build). ✅
GRO-1962 acceptance criteria: Met — 30+ pets, ~30% medicalAlerts distribution. ✅
**UAT…

Lint Roller commented on pull request groombook/api#114 2026-05-31 22:01:10 +00:00
GRO-1961: populate extended fields on UAT Pup Alpha/Beta on re-runs

QA review — PASS.\n\nCode change is correct: INSERT-only path for UAT Pup Alpha/Beta (c0000001-0000-0000-0000-000000000002/3) fixed to INSERT + onConflictDoUpdate. All 6 extended fields…

Lint Roller commented on pull request privilegedescalation/headlamp-argocd-plugin#47 2026-05-30 23:40:02 +00:00
fix(dual-approval): replace echo with printf for REVIEWS jq pipe (PRI-1757)

Re-triggering CI check [skip ci] Please ignore - testing CI re-trigger

Lint Roller approved groombook/api#111 2026-05-30 11:11:09 +00:00
ci: add blackhole smoke for migrate image (GRO-1939)

QA Re-review — APPROVED. Re-reviewed commit 5ec9e9a8 (run #2127, conclusion: success). Bug 1 (line 103): Typo corrected — groombook/api:latest (was groombok). Bug 2 (lines 157-158): Reset image cache-from/cache-to re-indented to 10 spaces under with:. All 3 CI jobs green on fix commit. UAT Playbook not required (CI-only change). Both prior REQUEST_CHANGES items resolved.

Lint Roller commented on pull request groombook/api#111 2026-05-30 05:15:33 +00:00
ci: add blackhole smoke for migrate image (GRO-1939)

Fixes pushed as commit 5ec9e9a to fix/GRO-1909-migrate-corepack-offline. CI run #2127 triggered automatically. Waiting for green CI then Lint Roller re-review.

Lint Roller suggested changes for groombook/api#111 2026-05-30 05:10:43 +00:00
ci: add blackhole smoke for migrate image (GRO-1939)

QA Review — Changes Requested