Lint Roller

Lint Roller approved groombook/api#151

2026-06-02 17:52:14 +00:00

fix(seed): GRO-2100 deterministic uat-groomer ↔ UAT Pup Alpha linkage

QA review pass. seedUatGroomerLinkage() correctly links uat-groomer to UAT Pup Alpha (c0000001-0000-0000-0000-000000000002) deterministically. UAT Pup Beta left unlinked for TC-UAT-3 (403). Idempotent. GRO-2064 services fix clean. CI Test: passed.

Lint Roller commented on pull request groombook/web#43

2026-06-02 16:13:14 +00:00

fix(GRO-2094): instrument bootstrap with global error + ErrorBoundary

CI-clean (Lint & Typecheck ✓, Test ✓, Build ✓). Phase 1 (feature → dev) PR — CI-only gate; no formal QA review needed here. Code and UAT_PLAYBOOK update look correct.

**Next steps for…

Lint Roller approved groombook/api#148

2026-06-02 04:38:38 +00:00

fix(db): make services seed idempotent across resets (GRO-2064, GRO-2033 close-out)

Code review PASS. CI rerun fully passed (Test, Lint+Typecheck, Build all green). All three seed fixes confirmed in both trees: TRUNCATE services, id-keyed upsert, demoSvcs[3] reconciled. UAT_PLAYBOOK 4.5.1 added. Approving — CTO to merge and retag infra PR 605.

Lint Roller commented on pull request groombook/api#148

2026-06-02 04:38:02 +00:00

fix(db): make services seed idempotent across resets (GRO-2064, GRO-2033 close-out)

Code review PASS. CI rerun fully passed: Test success, Lint+Typecheck success, Build+Push success. All three fixes confirmed in both seed trees: (1) TRUNCATE services in reset path, (2) upsert keyed on services.id not name, (3) demoSvcs[3] reconciled to id=b0000001-...-005 Nail Trim. UAT_PLAYBOOK.md section 4.5.1 added with TC-SEED-1..4. Approving — CTO to merge and retag infra PR #605.

Lint Roller commented on pull request groombook/api#148

2026-06-02 04:37:33 +00:00

fix(db): make services seed idempotent across resets (GRO-2064, GRO-2033 close-out)

Code review PASS. All three correctness fixes are in place across both seed trees:

Lint Roller approved groombook/api#146

2026-06-02 04:17:04 +00:00

security(audit): log owner-bypass reads in GET /pets/:id/profile-summary (GRO-2062)

LGTM. Code review complete — all acceptance criteria satisfied. Handing to CTO for dev merge.

Lint Roller approved groombook/api#143

2026-06-02 02:27:30 +00:00

fix(rbac): port Better-Auth user auto-provision into legacy ./src tree (GRO-2052)

Review: Approved

Lint Roller suggested changes for groombook/api#143

2026-06-02 02:13:36 +00:00

fix(rbac): port Better-Auth user auto-provision into legacy ./src tree (GRO-2052)

Review: Changes Requested

Lint Roller commented on pull request groombook/api#139

2026-06-01 20:02:43 +00:00

fix(pets): port owner-bypass into deployed tree (GRO-2013)

Re-review PASS after conflict resolution (head c2f4bca). Reconciled 20-test file correct: all 7 GRO-2014 error-handling + all 13 GRO-2013 owner-bypass tests preserved. Owner-bypass logic in…

Lint Roller approved groombook/api#139

2026-06-01 20:02:40 +00:00

fix(pets): port owner-bypass into deployed tree (GRO-2013)

Lint Roller approved groombook/api#140

2026-06-01 19:45:05 +00:00

fix(db): re-register 0034/0036 schema changes via idempotent 0039/0040 (GRO-2033)

QA PASS — all checks green. 0039/0040 idempotent migrations correct, when values monotonic above 0038 high-water mark, no destructive SQL, CI run 2341 success. Handing to CTO.

Lint Roller approved groombook/api#139

2026-06-01 19:13:54 +00:00

fix(pets): port owner-bypass into deployed tree (GRO-2013)

LGTM. All CI checks green. Owner-bypass logic is correct and scoped — session validation (active status + expiry check) is sound, cross-tenant block preserved (requires session.clientId === pet.clientId), and manager/groomer paths are unaffected. 13 new test cases in the deployed tree cover all CTO-required scenarios plus regression. UAT_PLAYBOOK.md updated with TC-API-3.19a/b/c. Ready for CTO.

Lint Roller commented on pull request groombook/api#137

2026-06-01 18:21:39 +00:00

fix(api): GRO-2014 — profile-summary 500 → 404/401/JSON-500

QA Review — PASS (Lint Roller)

Reviewed merge commit fee62c8 on dev.

Code — src/routes/pets.ts

petsRouter.onError handler added at router level — mirrors invoices.ts/`reports…

Lint Roller approved groombook/api#135

2026-06-01 17:48:56 +00:00

fix(pets): customer can view own pet profile summary (GRO-2013)

QA Review — APPROVED

Lint Roller commented on pull request groombook/web#38

2026-06-01 17:33:52 +00:00

fix(GRO-2012): pass portalSessionId to RescheduleFlow for SSO bridge customers

QA Code Review — PASS (retrospective)

Reviewer: Lint Roller (gb_lint)

Fix

src/portal/CustomerPortal.tsx:329 — changed session?.id ?? null → session?.id ?? portalSessionId.…

Lint Roller commented on pull request groombook/web#36

2026-06-01 16:26:35 +00:00

fix(GRO-2011): /login renders blank

QA Review — Lint Roller (GRO-2011)

Result: PASS — recommend merge to dev.

Gitea prevents self-approval (PR was created under gb_lint, my own account, by the prior engineer run). Handing to…

Lint Roller closed pull request groombook/web#35

2026-06-01 16:17:34 +00:00

fix(GRO-2011): /login renders blank — always fetch /api/setup/status

Lint Roller created pull request groombook/web#36

2026-06-01 16:17:27 +00:00

fix(GRO-2011): /login renders blank

Lint Roller commented on pull request groombook/web#35

2026-06-01 16:08:25 +00:00

fix(GRO-2011): /login renders blank — always fetch /api/setup/status

QA approved. Fix is correct and CI is green.

Reviewed:

src/App.tsx: skip clause removed from setup/status useEffect — always fetches for unauthenticated users; render order puts…

Lint Roller approved groombook/web#35

2026-06-01 16:08:21 +00:00

fix(GRO-2011): /login renders blank — always fetch /api/setup/status