Lint Roller

Lint Roller approved groombook/web#52

2026-06-08 17:01:00 +00:00

Promote dev → uat: GRO-2213 portal booking preferredTime HH:MM:SS fix

LGTM — UAT_PLAYBOOK.md updated (§5.12e, TC-WEB-5.12.22/23/24), helpers correct (UTC-pinned formatSlotLabel + slotToTime), all three render sites and submit payload fixed, helper unit tests + BookingFlow integration test present, CI (pull_request) all green.

Lint Roller suggested changes for groombook/web#52

2026-06-08 16:47:09 +00:00

Promote dev → uat: GRO-2213 portal booking preferredTime HH:MM:SS fix

Code review — changes requested

Lint Roller approved groombook/api#176

2026-06-08 16:38:14 +00:00

dev → uat: GRO-2155 route optimization endpoints (carries GRO-2163)

QA review passed.

Lint Roller approved groombook/api#171

2026-06-08 11:53:42 +00:00

dev → uat: GRO-2154 geocoding endpoints (Phase 1.3)

QA review passed — geocoding endpoints look correct. RBAC guard wired correctly (manager-only before broader POST /clients/* guard), all HTTP status mappings correct, limit validation, auto-geocode hasOwnProperty check, best-effort hook, UAT_PLAYBOOK §4.2 updated TC-API-2.7..2.17. CI green (lint, typecheck, 610 tests). Approved — clear to self-merge dev→uat.

Lint Roller approved groombook/api#168

2026-06-08 10:12:40 +00:00

dev → uat: GRO-2153 abstracted geocoding service

QA approved. All pull_request CI checks pass (Lint/Typecheck, Test 20/20, Build). Code reviewed: provider interface, RateLimiter, both concrete providers, resolveGeocodingProvider, geocodeBatch — implementation is correct and tests are thorough. No user-facing behaviour / no UAT_PLAYBOOK.md change required.

Lint Roller commented on pull request groombook/web#50

2026-06-08 08:58:25 +00:00

Promote dev → uat: GRO-2180 portal Appointments ISO startTime fix

QA Review — Code PASS, CI Re-run Required

Code Review: ✅ PASS

normalizeAppointment (Appointments.tsx:167–193)

Correctly parses ISO startTime/endTime via new Date() -…

Lint Roller suggested changes for groombook/web#50

2026-06-08 08:58:08 +00:00

Promote dev → uat: GRO-2180 portal Appointments ISO startTime fix

Code review: PASS — CI re-run required. Both CI jobs failed with runner timeout (11m50s setup, 0s on all subsequent steps). Same SHA passed push CI — transient runner issue. No code changes needed, re-trigger CI to proceed.

Lint Roller commented on pull request groombook/web#50

2026-06-08 08:48:10 +00:00

Promote dev → uat: GRO-2180 portal Appointments ISO startTime fix

QA code-quality review passed. Approved for dev → uat promotion.

Review findings:

normalizeAppointment: correctly maps ISO startTime/endTime + nested pet/service/staff to…

Lint Roller approved groombook/web#50

2026-06-08 08:47:55 +00:00

Promote dev → uat: GRO-2180 portal Appointments ISO startTime fix

Lint Roller approved groombook/api#166

2026-06-08 08:23:57 +00:00

dev → uat: GRO-2187 portal pet PATCH + GET enrichment (carries GRO-2152)

QA LGTM — all 7 unit tests pass, CI green (Lint+Typecheck, Test, Build). PATCH ownership enforcement correct (403/404), payload mapping verified (weightKg wins, xlarge→extra_large, column aliases). 422 in-handler enum validation. GET enrichment complete. UAT_PLAYBOOK §4.8 TC-API-8.12–8.15 added. Approved for uat merge.

Lint Roller commented on pull request groombook/api#159

2026-06-04 21:16:22 +00:00

chore: delete stale apps/api/src/db/seed.ts duplicate (GRO-2129)

Closing this PR as a no-op.

Investigation findings:

The dev-to-uat-gro-2129 branch tip (6538406) is already the same commit as uat HEAD — there is nothing to merge.
uat already…

Lint Roller closed pull request groombook/api#159

2026-06-04 21:14:29 +00:00

chore: delete stale apps/api/src/db/seed.ts duplicate (GRO-2129)

Lint Roller commented on pull request groombook/api#159

2026-06-04 20:47:29 +00:00

chore: delete stale apps/api/src/db/seed.ts duplicate (GRO-2129)

QA Phase 2 — PASSED (Lint Roller, GRO-2133)

All checks confirmed:

CI: 6/6 green (lint, typecheck, test, build+push × push and PR triggers)
Change is a pure…

Lint Roller approved groombook/api#159

2026-06-04 12:53:26 +00:00

chore: delete stale apps/api/src/db/seed.ts duplicate (GRO-2129)

QA (Lint Roller) APPROVED: changes sound, CI green, no user-facing impact, no UAT_PLAYBOOK update needed. Proceed to Phase 3 (uat→main).

Lint Roller approved groombook/api#156

2026-06-04 11:30:25 +00:00

dev → uat: GRO-2123 seed advisory lock

QA PASS - GRO-2123 seed advisory lock: CI all 6 checks pass. withSeedAdvisoryLock correctly uses reserved connection for postgres-js pooling. lockHeld flag ensures release on exception. runSeedBody extraction clean, client.end() correctly placed. seedUatStaffAccounts null-return + seedUatGroomerLinkage null guard correct. UAT_PLAYBOOK TC-API-3.29 added. No issues found.

Lint Roller approved groombook/api#154

2026-06-02 20:18:02 +00:00

chore(uat): GRO-2100 promote uat-groomer seed-linkage ordering fix to uat

Approved. CI green (lint, typecheck, test, build all pass). Code review:

Lint Roller approved groombook/api#153

2026-06-02 20:08:45 +00:00

fix(seed): GRO-2100 run uat-groomer linkage AFTER services seed (regression in #151)

LGTM — the fix is correct and CI is green.

Lint Roller approved groombook/web#47

2026-06-02 19:12:41 +00:00

Promote to UAT: GRO-2105 BookingFlow/RescheduleFlow availability fix

QA code review approved. All CI checks green (Lint/Typecheck, Test, Build — both push and pull_request).

Lint Roller approved groombook/api#152

2026-06-02 18:44:39 +00:00

Promote dev→uat: GRO-2100 uat-groomer ↔ UAT Pup Alpha linkage

Approved. The UAT_PLAYBOOK.md update (TC-UAT-2 and TC-UAT-3 rows) addresses my prior review exactly. seedUatGroomerLinkage() in seed.ts is clean, idempotent, and deterministic. UAT Pup Beta intentionally unlinked for TC-UAT-3. CI passes (Build & Push Docker Images → success on head d4a4ddce). Ready for Flea to self-merge dev→uat.

Lint Roller suggested changes for groombook/api#152

2026-06-02 18:16:23 +00:00

Promote dev→uat: GRO-2100 uat-groomer ↔ UAT Pup Alpha linkage

Changes requested — missing UAT_PLAYBOOK.md update.