groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(seed): remove stale uc.petName closure ref, correct medicalAlerts distribution to 30% #115

Merged
Scrubs McBarkley merged 2 commits from fix/GRO-1962-uat-seed-pet-medicalalerts into dev 2026-05-31 22:14:33 +00:00
Conversation 1 Commits 2 Files Changed 2
+17 -8

2 Commits

Author SHA1 Message Date
Paperclip 20d44faec8 docs(UAT_PLAYBOOK): add TC-API-3.25 and TC-API-3.26 for pet count and medicalAlerts distribution
CI / Test (pull_request) Successful in 14s
Details
CI / Lint & Typecheck (pull_request) Successful in 14s
Details
CI / Build & Push Docker Images (pull_request) Successful in 1m1s
Details 
Updated UAT_PLAYBOOK.md §3.2 — new test cases for GRO-1962:
- TC-API-3.25: Verify 30+ total pets in UAT DB
- TC-API-3.26: Verify 25-35% medicalAlerts distribution

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-31 22:14:13 +00:00
Paperclip 5d6fb4b43c fix(seed): remove stale uc.petName closure ref, correct medicalAlerts distribution to 30% 
Fixes GRO-1962:
- Random pet loop (lines 968-982): removed stale uc.petName references
  that caused runtime ReferenceError (uc declared ~80 lines later at line 1048)
- UAT test clients loop: moved TestCooper/TestRocky deterministic checks
  inside the rand()<0.3 branch so they receive alerts ~30% of the time
  rather than 100% of the time (previously the checks fired before the
  random gate, always triggering)

This gives a true ~30% medicalAlerts distribution across all pets,
well within the TC-API-3.22 acceptance criteria band of 25-35%.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-31 22:14:13 +00:00