groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(GRO-1272): auto-provision staff record on first OIDC login #18

Closed
groombook-engineer[bot] wants to merge 1 commits from fleaflicker/gro-1272-v2 into main
pull from: fleaflicker/gro-1272-v2
merge into: groombook:main
Conversation 1 Commits 1 Files Changed 1
+25 -1
groombook-engineer[bot] commented 2026-05-14 19:00:39 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Fixes the UAT regression where all authenticated API routes return HTTP 403 after GRO-1207 promotion.

Root cause: seedKnownUsers() creates staff records with oidcSub set to Authentik integer PKs ("235", "236") or email strings — never the actual Authentik OIDC sub (a UUID). resolveStaffMiddleware has three lookup paths, all of which fail:

Lookup Fails because
staff.userId = jwt.sub userId is NULL for all seeded UAT staff
staff.oidcSub = jwt.sub oidcSub is "235" but jwt.sub is a UUID
staff.email = jwt.email AND userId IS NULL Authentik email ≠ seed email

Fix: After the three lookup paths fail, add a fourth path that checks for a Better-Auth user record by jwt.sub and auto-creates a minimal groomer staff record on first login. This bridges the gap without requiring changes to Terraform user creation or the seed data.

Changes

  • src/middleware/rbac.ts: Import user table, add auto-provision block after email auto-link path. When no staff record exists but a Better-Auth user is found by jwt.sub, create a minimal groomer staff record with correct userId.

Test plan

  • Run UAT Playbook §4.9 (Communication tab) as uat-groomer, uat-super
  • Run UAT Playbook §4.20 (Staff Messages) as uat-groomer, uat-super
  • Smoke: portal login, navigation, appointments as all three UAT personas

Refs: GRO-1272, GRO-1257, GRO-1215

## Summary Fixes the UAT regression where all authenticated API routes return HTTP 403 after GRO-1207 promotion. **Root cause:** `seedKnownUsers()` creates staff records with `oidcSub` set to Authentik integer PKs (`"235"`, `"236"`) or email strings — never the actual Authentik OIDC `sub` (a UUID). `resolveStaffMiddleware` has three lookup paths, all of which fail: | Lookup | Fails because | |--------|--------------| | `staff.userId = jwt.sub` | `userId` is NULL for all seeded UAT staff | | `staff.oidcSub = jwt.sub` | `oidcSub` is `"235"` but `jwt.sub` is a UUID | | `staff.email = jwt.email AND userId IS NULL` | Authentik email ≠ seed email | **Fix:** After the three lookup paths fail, add a fourth path that checks for a Better-Auth `user` record by `jwt.sub` and auto-creates a minimal groomer staff record on first login. This bridges the gap without requiring changes to Terraform user creation or the seed data. ## Changes - `src/middleware/rbac.ts`: Import `user` table, add auto-provision block after email auto-link path. When no staff record exists but a Better-Auth user is found by `jwt.sub`, create a minimal `groomer` staff record with correct `userId`. ## Test plan - [ ] Run UAT Playbook §4.9 (Communication tab) as uat-groomer, uat-super - [ ] Run UAT Playbook §4.20 (Staff Messages) as uat-groomer, uat-super - [ ] Smoke: portal login, navigation, appointments as all three UAT personas Refs: [GRO-1272](/GRO/issues/GRO-1272), [GRO-1257](/GRO/issues/GRO-1257), [GRO-1215](/GRO/issues/GRO-1215)
Scrubs McBarkley commented 2026-05-20 12:10:45 +00:00
Owner
Copy Link
Copy Source

Closing as an SDLC violation and superseded. This PR targets main directly from a feature branch, bypassing the dev→uat→main promotion flow. The same fix (GRO-1272 auto-provision staff on OIDC login) is correctly targeted at dev in PR #19. Closing per org-wide PR backlog cleanup (GRO-1355).

Closing as an SDLC violation and superseded. This PR targets `main` directly from a feature branch, bypassing the dev→uat→main promotion flow. The same fix (GRO-1272 auto-provision staff on OIDC login) is correctly targeted at `dev` in PR #19. Closing per org-wide PR backlog cleanup ([GRO-1355](/GRO/issues/GRO-1355)).
Scrubs McBarkley closed this pull request 2026-05-20 12:10:45 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#18
Delete Branch "fleaflicker/gro-1272-v2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?