groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(e2e): resolve E2E test failures

Browse Source 
- Update fixture mock user IDs to match test expectations (client-1, client-2)
- Fix admin-reports strict mode violation: replace .or() with combined regex
- Ensure services endpoint is mocked before navigation in beforeEach
- Tests now expect UUIDs to be replaced with predictable IDs in mocks

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
groombook-engineer[bot]
2026-04-02 14:38:27 +00:00
parent aedf3b5265
commit 328cc9cc74
3 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/e2e/tests/admin-reports.spec.ts
+2 -2
View File
@@ -73,8 +73,8 @@ test.describe("Admin Reports Data", () => {
await page.waitForTimeout(2_000);
// Revenue card should show non-zero value (check dollar amount or Revenue heading)
const revenueCard = page.locator("text=/\\$1,250/").first();
await expect(revenueCard.or(page.locator("text=/Revenue/"))).toBeVisible();
const revenueCard = page.locator("text=/\\$1,250|Revenue/i").first();
await expect(revenueCard).toBeVisible();
// Appointments card should show non-zero
const appointmentsCard = page.locator("text=/25/").first();
apps/e2e/tests/admin-services.spec.ts
+5 -5
View File
@@ -14,15 +14,15 @@ const MOCK_SERVICES = [
test.describe("Services Deduplication", () => {
test.beforeEach(async ({ page }) => {
// Mock services endpoint FIRST before navigation
await page.route("**/api/services**", (route) =>
route.fulfill({ json: MOCK_SERVICES })
);
// Login as staff
await page.goto("/login");
await page.getByText("Alice Groomer").click();
await expect(page).toHaveURL("/admin");
// Mock services endpoint
await page.route("**/api/services**", (route) =>
route.fulfill({ json: MOCK_SERVICES })
);
});
test("admin services page shows no duplicate service names", async ({ page }) => {
apps/e2e/tests/fixtures.ts
+2 -2
View File
@@ -16,8 +16,8 @@ const MOCK_DEV_USERS = {
{ id: "staff-2", name: "Bob Manager", email: "bob@groombook.dev", role: "manager" },
],
clients: [
{ id: "00000000-0000-0000-0000-000000000002", name: "Carol Client", email: "carol@example.com", petCount: 2 },
{ id: "00000000-0000-0000-0000-000000000003", name: "Dave Client", email: null, petCount: 1 },
{ id: "client-1", name: "Carol Client", email: "carol@example.com", petCount: 2 },
{ id: "client-2", name: "Dave Client", email: null, petCount: 1 },
],
};