groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(GRO-566): add SKIP_OOBE env var to bypass setup wizard #267

Closed
groombook-engineer[bot] wants to merge 3 commits from fix/gro-566-skip-oobe into main
pull from: fix/gro-566-skip-oobe
merge into: groombook:main
Conversation 3 Commits 3 Files Changed 7
+165 -33
groombook-engineer[bot] commented 2026-04-12 02:36:59 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

SKIP_OOBE=true|1|yes causes GET /api/setup/status to return needsSetup: false regardless of DB state. Useful in dev/test environments where the DB has data but the OOBE would block access.

Changes

  • apps/api/src/routes/setup.ts: SKIP_OOBE check added to GET /status handler
  • .env.example: document SKIP_OOBE=false
  • apps/api/src/__tests__/setup.test.ts: cover SKIP_OOBE=true|1|yes

cc @cpfarhood

## Summary SKIP_OOBE=true|1|yes causes `GET /api/setup/status` to return `needsSetup: false` regardless of DB state. Useful in dev/test environments where the DB has data but the OOBE would block access. ## Changes - `apps/api/src/routes/setup.ts`: SKIP_OOBE check added to `GET /status` handler - `.env.example`: document `SKIP_OOBE=false` - `apps/api/src/__tests__/setup.test.ts`: cover SKIP_OOBE=true|1|yes cc @cpfarhood
github-actions[bot] commented 2026-04-12 02:43:10 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-267
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-267` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-12 02:45:12 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment

QA Approved: SKIP_OOBE implementation verified. All CI checks pass (lint, typecheck, tests, E2E, build, deploy to dev). The SKIP_OOBE logic in setup.ts matches the issue spec, .env.example updated, and 3 test cases added covering true/1/yes values. @cpfarhood for visibility.

QA Approved: SKIP_OOBE implementation verified. All CI checks pass (lint, typecheck, tests, E2E, build, deploy to dev). The SKIP_OOBE logic in setup.ts matches the issue spec, .env.example updated, and 3 test cases added covering true/1/yes values. @cpfarhood for visibility.
groombook-engineer[bot] commented 2026-04-12 02:48:02 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing PR #267 — GRO-564 and GRO-565 commits have been separated into their own clean PRs. GRO-566 will be created separately.

Closing PR #267 — GRO-564 and GRO-565 commits have been separated into their own clean PRs. GRO-566 will be created separately.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
lint-roller-qa[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#267
Delete Branch "fix/gro-566-skip-oobe"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?