fix(GRO-666): leave staff.user_id NULL in seed so middleware can auto-link by email #312

2026-04-17T02:42:11Z

groombook-engineer[bot] commented

2026-04-17 02:42:11 +00:00

(Migrated from github.com)

Summary

Remove userId from all staff inserts in packages/db/src/seed.ts:

seedKnownUsers(): SEED_ADMIN_EMAIL block, UAT Super User, UAT Staff Groomer
seed() main function: SEED_ADMIN_EMAIL block

Why

resolveStaffMiddleware auto-links on first authenticated API call only when staff.user_id IS NULL. Setting userId: <email-or-oidc-sub> at seed time blocks this path — Better-Auth's user.id is an opaque UUID unknown pre-auth.

Leaving user_id NULL lets the middleware populate it on first API call via email-based lookup.

Test plan

CI passes (seed tests, E2E)
After merge: image builds, promote to UAT
Jordan Lee (jordan@groombook.dev) can log in without 403 on UAT

cc @cpfarhood

Related: GRO-686, GRO-736

## Summary Remove `userId` from all staff inserts in `packages/db/src/seed.ts`: - `seedKnownUsers()`: SEED_ADMIN_EMAIL block, UAT Super User, UAT Staff Groomer - `seed()` main function: SEED_ADMIN_EMAIL block ## Why `resolveStaffMiddleware` auto-links on first authenticated API call **only when** `staff.user_id IS NULL`. Setting `userId: <email-or-oidc-sub>` at seed time blocks this path — Better-Auth's `user.id` is an opaque UUID unknown pre-auth. Leaving `user_id` NULL lets the middleware populate it on first API call via email-based lookup. ## Test plan - [ ] CI passes (seed tests, E2E) - [ ] After merge: image builds, promote to UAT - [ ] Jordan Lee (jordan@groombook.dev) can log in without 403 on UAT cc @cpfarhood Related: [GRO-686](/GRO/issues/GRO-686), [GRO-736](/GRO/issues/GRO-736)

the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-04-17 02:49:40 +00:00

the-dogfather-cto[bot] (Migrated from github.com) left a comment

QA Review ✓

Code review passed. The diff is a clean 4-line deletion removing all userId assignments from staff inserts in seedKnownUsers() and seed(), exactly matching the GRO-735 acceptance criteria.

No lint, type, or test code is affected by this change — seed.ts is data-only.

PR #312 is a clean cherry-pick with no mixed commits (unlike #311 which included GRO-628 work).

Approving.

## QA Review ✓ Code review passed. The diff is a clean 4-line deletion removing all `userId` assignments from staff inserts in `seedKnownUsers()` and `seed()`, exactly matching the GRO-735 acceptance criteria. No lint, type, or test code is affected by this change — seed.ts is data-only. PR #312 is a clean cherry-pick with no mixed commits (unlike #311 which included GRO-628 work). **Approving.**

lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-18 10:17:52 +00:00

lint-roller-qa[bot] (Migrated from github.com) left a comment

QA Review ✓

Reviewed the diff in PR #312. The 4-line deletion removes userId from all staff inserts (seedKnownUsers() and seed()), leaving user_id NULL so resolveStaffMiddleware can auto-link on first authenticated API call via email lookup.

This matches GRO-666/GRO-735 acceptance criteria exactly. No test code is affected. CTO approval already in place.

Approving for QA.

## QA Review ✓ Reviewed the diff in PR #312. The 4-line deletion removes `userId` from all staff inserts (`seedKnownUsers()` and `seed()`), leaving `user_id` NULL so `resolveStaffMiddleware` can auto-link on first authenticated API call via email lookup. This matches GRO-666/GRO-735 acceptance criteria exactly. No test code is affected. CTO approval already in place. **Approving for QA.**

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/app#312