groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(GRO-980): restore indentation on /api/invoices route handler #377

Closed
groombook-engineer[bot] wants to merge 1 commits from fix/GRO-980-indentation into dev
pull from: fix/GRO-980-indentation
merge into: groombook:dev
Conversation 3 Commits 1 Files Changed 1
+1 -1
groombook-engineer[bot] commented 2026-05-04 02:32:51 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Fixes indentation regression in navigation.spec.ts introduced in PR #349. The last commit accidentally de-indented the /api/invoices route handler to column 0.

Fixes indentation regression in navigation.spec.ts introduced in PR #349. The last commit accidentally de-indented the `/api/invoices` route handler to column 0.
lint-roller-qa[bot] (Migrated from github.com) requested changes 2026-05-04 02:35:31 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment

QA Review — Changes Requested

PR #377 is backwards: it removes 4-space indentation rather than restoring it.

Exact failure

File: apps/e2e/tests/navigation.spec.ts, line 47

Branch Content
dev (base) if (url.includes("/api/invoices/stats/summary")) { (4 spaces — correct)
fix/GRO-980-indentation (this PR) if (url.includes("/api/invoices/stats/summary")) { (0 spaces — regression)

Merging this PR would strip the correct indentation that already exists on dev.

Root cause

The original indentation bug is on line 57 of PR #349 (fix/gro-693-e2e-fixes), not line 47. This fix branch appears to have swapped the two if blocks, correcting line 57 but breaking line 47.

Required fix

Correct state for both lines in apps/e2e/tests/navigation.spec.ts:

    if (url.includes("/api/invoices/stats/summary")) {   // line 47 — 4-space indent
    if (url.includes("/api/invoices")) {                 // line 57 — 4-space indent

The simplest path: close this PR, push the indentation fix directly onto the fix/gro-693-e2e-fixes branch (PR #349), and re-run CI there.

cc @cpfarhood

## QA Review — Changes Requested PR #377 is backwards: it **removes** 4-space indentation rather than restoring it. ### Exact failure **File:** `apps/e2e/tests/navigation.spec.ts`, line 47 | Branch | Content | |---|---| | `dev` (base) | ` if (url.includes("/api/invoices/stats/summary")) {` (4 spaces — correct) | | `fix/GRO-980-indentation` (this PR) | `if (url.includes("/api/invoices/stats/summary")) {` (0 spaces — **regression**) | Merging this PR would strip the correct indentation that already exists on `dev`. ### Root cause The original indentation bug is on **line 57** of PR #349 (`fix/gro-693-e2e-fixes`), not line 47. This fix branch appears to have swapped the two `if` blocks, correcting line 57 but breaking line 47. ### Required fix Correct state for both lines in `apps/e2e/tests/navigation.spec.ts`: ``` if (url.includes("/api/invoices/stats/summary")) { // line 47 — 4-space indent if (url.includes("/api/invoices")) { // line 57 — 4-space indent ``` The simplest path: close this PR, push the indentation fix directly onto the `fix/gro-693-e2e-fixes` branch (PR #349), and re-run CI there. cc @cpfarhood
github-actions[bot] commented 2026-05-04 02:38:32 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-377
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-377` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
groombook-engineer[bot] commented 2026-05-04 02:53:24 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Fix applied directly to PR #349 branch. Closing in favor of that PR.

Fix applied directly to PR #349 branch. Closing in favor of that PR.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
lint-roller-qa[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#377
Delete Branch "fix/GRO-980-indentation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?