groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(gro-47): customer portal confirm/cancel appointments #124

Closed
groombook-engineer[bot] wants to merge 5 commits from fleaflicker/gro47-confirm-cancel-clean into main
pull from: fleaflicker/gro47-confirm-cancel-clean
merge into: groombook:main
Conversation 10 Commits 5 Files Changed 5
+625 -435

5 Commits

Author SHA1 Message Date
Flea Flicker 208e1fb5bc fix(gro-47): add non-null assertions on Drizzle RETURNING results 
Drizzle's update().returning() types the array element as T | undefined.
After the if (!appt) guard, updated is still typed as possibly undefined
because RETURNING can succeed with no rows. Add ! assertions since
we already guard with the existence check.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-03-27 13:29:41 +00:00
Flea Flicker 80a0cd95a1 fix(gro-47): add missing afterEach to vitest import 
Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-03-27 12:59:28 +00:00
Flea Flicker cc579de792 test(gro-50): add ConfirmationSection UI component tests 
Add tests for the ConfirmationSection component:
- Renders correct badge for each confirmationStatus state
- Shows/hides Confirm button based on status
- Calls confirm API with correct headers
- Handles sessionId null case
- Shows error messages for 401/403/422 responses
- Shows loading state while confirming
- Shows success message briefly after confirm
- Does not call API if user cancels confirm dialog

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-03-27 06:48:11 +00:00
Flea Flicker 7f6b2fd485 fix(gro-50): add portal confirm/cancel tests and fix ConfirmationSection state 
- Add test coverage for POST /portal/appointments/:id/confirm endpoint
- Add test coverage for POST /portal/appointments/:id/cancel endpoint
- Fix ConfirmationSection not updating local status after successful confirm
- Remove unused onCancel prop from ConfirmationSection call site
- Fix Appointments.test.tsx missing confirmationStatus field

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-27 06:48:11 +00:00
Flea Flicker d742b48741 Implement confirm/cancel in customer portal (GRO-50) 
Backend:
- Add POST /api/portal/appointments/:id/confirm endpoint
  - Validates impersonation session auth and ownership
  - Rejects past/in-progress, non-pending, or already-cancelled/completed
  - Sets confirmationStatus="confirmed", confirmedAt, updatedAt
- Add POST /api/portal/appointments/:id/cancel endpoint
  - Same auth/ownership pattern
  - Rejects past/in-progress or already-cancelled/completed
  - Sets status="cancelled", confirmationStatus="cancelled", cancelledAt, updatedAt

Frontend (Appointments.tsx):
- Add confirmationStatus field to Appointment type and mock data
- Add ConfirmationSection component: shows status badge + confirm button
- Add CancelAppointmentButton: wires to cancel API with loading/error state
- Wire existing Cancel button to CancelAppointmentButton
- Show confirmation status badge in expanded view for upcoming appointments

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-03-27 06:48:11 +00:00