groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(portal): add onClick handler to Reschedule button (GRO-166) #143

Closed
groombook-engineer[bot] wants to merge 23 commits from fix/gro-166-reschedule-button-no-op into main
pull from: fix/gro-166-reschedule-button-no-op
merge into: groombook:main
Conversation 3 Commits 23 Files Changed 39
+14 -17
groombook-engineer[bot] commented 2026-03-28 04:16:13 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Add type="button" and onClick={() => alert("Rescheduling is coming soon!")} to Reschedule buttons in Dashboard.tsx and Appointments.tsx
  • The buttons previously had no click handler, making them no-ops when clicked

Test plan

  • Navigate to Customer Portal as Sarah Mitchell
  • Verify Reschedule button on Home page triggers alert
  • Verify Reschedule button on Appointments detail triggers alert
  • Verify page no longer goes blank on click

cc @cpfarhood

🤖 Generated with Claude Code

## Summary - Add `type="button"` and `onClick={() => alert("Rescheduling is coming soon!")}` to Reschedule buttons in `Dashboard.tsx` and `Appointments.tsx` - The buttons previously had no click handler, making them no-ops when clicked ## Test plan - [ ] Navigate to Customer Portal as Sarah Mitchell - [ ] Verify Reschedule button on Home page triggers alert - [ ] Verify Reschedule button on Appointments detail triggers alert - [ ] Verify page no longer goes blank on click cc @cpfarhood 🤖 Generated with [Claude Code](https://claude.com/claude-code)
cpfarhood (Migrated from github.com) reviewed 2026-03-28 04:16:13 +00:00
groombook-engineer[bot] commented 2026-03-28 04:17:09 +00:00 (Migrated from github.com)
Copy Link
Copy Source

PR ready for review. Reschedule button now shows an alert instead of causing a blank page. cc @cpfarhood

PR ready for review. Reschedule button now shows an alert instead of causing a blank page. cc @cpfarhood
groombook-engineer[bot] commented 2026-03-28 04:29:54 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing in favor of PR #142 which uses a better approach (disabled buttons with tooltip). My alert approach is less polished than the CTO's disabled-button fix.

Closing in favor of PR #142 which uses a better approach (disabled buttons with tooltip). My alert approach is less polished than the CTO's disabled-button fix.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
cpfarhood
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#143
Delete Branch "fix/gro-166-reschedule-button-no-op"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?