groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ci: update cd job to target dev overlay #156

Merged
groombook-engineer[bot] merged 2 commits from ci/update-cd-job-to-dev-overlay into main 2026-03-29 09:46:37 +00:00
Conversation 4 Commits 2 Files Changed 1
+14 -22
groombook-engineer[bot] commented 2026-03-29 08:02:20 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Replaced sed-based image tag updates on base manifests with yq targeting the dev overlay kustomization.yaml
  • cd job now updates apps/groombook/overlays/dev/kustomization.yaml instead of apps/groombook/base/
  • Dev infra PR auto-merges via --auto --merge (dev auto-deploy desired)

Changes

  • .github/workflows/ci.yml: Added yq install step; replaced image tag update logic; updated infra PR git add to target dev overlay; updated PR title template to chore: deploy ${TAG} to dev

cc @cpfarhood

## Summary - Replaced `sed`-based image tag updates on base manifests with `yq` targeting the dev overlay `kustomization.yaml` - `cd` job now updates `apps/groombook/overlays/dev/kustomization.yaml` instead of `apps/groombook/base/` - Dev infra PR auto-merges via `--auto --merge` (dev auto-deploy desired) ## Changes - `.github/workflows/ci.yml`: Added `yq` install step; replaced image tag update logic; updated infra PR `git add` to target dev overlay; updated PR title template to `chore: deploy ${TAG} to dev` cc @cpfarhood
github-actions[bot] commented 2026-03-29 08:07:58 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-156
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-156` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-03-29 09:02:54 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment

QA Review — APPROVED

Diff review: .github/workflows/ci.yml changes are surgical and correct:

  • ✅ Removes all sed-based base manifest updates
  • ✅ Adds yq install step + updates dev overlay images section via yq
  • ✅ Changes git add apps/groombook/base/ → git add apps/groombook/overlays/dev/
  • ✅ Updates infra PR title to chore: deploy ${TAG} to dev
  • ✅ Preserves --auto --merge for dev auto-deploy

CI: All checks pass — Lint, Test, E2E, Build, Build & Push, Deploy PR ✅

Acceptance criteria met:

  • cd job updates apps/groombook/overlays/dev/kustomization.yaml images section
  • cd job no longer modifies any files in apps/groombook/base/
  • Infra PR still auto-merges (dev auto-deploy)
  • PR targets main

Recommendation: Approve. Re-assign to CTO for final review and merge.

cc @cpfarhood

## QA Review — APPROVED **Diff review:** `.github/workflows/ci.yml` changes are surgical and correct: - ✅ Removes all sed-based base manifest updates - ✅ Adds yq install step + updates dev overlay `images` section via yq - ✅ Changes `git add apps/groombook/base/` → `git add apps/groombook/overlays/dev/` - ✅ Updates infra PR title to `chore: deploy ${TAG} to dev` - ✅ Preserves `--auto --merge` for dev auto-deploy **CI:** All checks pass — Lint, Test, E2E, Build, Build & Push, Deploy PR ✅ **Acceptance criteria met:** - [x] cd job updates `apps/groombook/overlays/dev/kustomization.yaml` images section - [x] cd job no longer modifies any files in `apps/groombook/base/` - [x] Infra PR still auto-merges (dev auto-deploy) - [x] PR targets main **Recommendation:** Approve. Re-assign to CTO for final review and merge. cc @cpfarhood
the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-03-29 09:05:06 +00:00
the-dogfather-cto[bot] (Migrated from github.com) left a comment

CTO Review — APPROVED

Diff is clean and surgical. All acceptance criteria verified:

  • cd job updates apps/groombook/overlays/dev/kustomization.yaml via yq (all 4 images)
  • cd job no longer touches apps/groombook/base/
  • Infra PR auto-merge preserved (--auto --merge)
  • PR title updated to chore: deploy ${TAG} to dev

CI all green. QA approved. Ship it.

## CTO Review — APPROVED Diff is clean and surgical. All acceptance criteria verified: - [x] cd job updates `apps/groombook/overlays/dev/kustomization.yaml` via yq (all 4 images) - [x] cd job no longer touches `apps/groombook/base/` - [x] Infra PR auto-merge preserved (`--auto --merge`) - [x] PR title updated to `chore: deploy ${TAG} to dev` CI all green. QA approved. Ship it.
github-actions[bot] commented 2026-03-29 09:46:18 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-156
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-156` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
lint-roller-qa[bot]
the-dogfather-cto[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#156
Delete Branch "ci/update-cd-job-to-dev-overlay"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?