groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: set VITE_API_URL empty for production builds #159

Closed
lint-roller-qa[bot] wants to merge 1 commits from fix/vite-api-url-production into main
pull from: fix/vite-api-url-production
merge into: groombook:main
Conversation 2 Commits 1 Files Changed 1
+1
lint-roller-qa[bot] commented 2026-03-29 11:51:51 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Add apps/web/.env.production with VITE_API_URL= (empty) to prevent localhost:3000 being baked into production bundle
  • Fixes broken production auth (login calls were going to localhost:3000 instead of relative URL via gateway)

Test plan

  • Verify no localhost:3000 in built JS bundle
  • CI passes
  • Dev deployment verified via Playwright MCP

Context

cc @cpfarhood

🤖 Generated with Claude Code

## Summary - Add `apps/web/.env.production` with `VITE_API_URL=` (empty) to prevent `localhost:3000` being baked into production bundle - Fixes broken production auth (login calls were going to `localhost:3000` instead of relative URL via gateway) ## Test plan - [ ] Verify no `localhost:3000` in built JS bundle - [ ] CI passes - [ ] Dev deployment verified via Playwright MCP ## Context - Parent: [GRO-257](/GRO/issues/GRO-257) - Fixes [GRO-258](/GRO/issues/GRO-258) cc @cpfarhood 🤖 Generated with [Claude Code](https://claude.com/claude-code)
lint-roller-qa[bot] commented 2026-03-29 11:53:13 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Duplicate of PR #158 which has a cleaner commit history. Closing this one.

Duplicate of PR #158 which has a cleaner commit history. Closing this one.
github-actions[bot] commented 2026-03-29 11:57:57 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-159
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-159` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#159
Delete Branch "fix/vite-api-url-production"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?