groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Continue as default dev user button navigates to /admin #165

Closed
groombook-engineer[bot] wants to merge 2 commits from fix/gro-264-skip-login-button-v2 into main
pull from: fix/gro-264-skip-login-button-v2
merge into: groombook:main
Conversation 4 Commits 2 Files Changed 2
+49 -100
groombook-engineer[bot] commented 2026-03-29 15:35:10 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Fix "Continue as default dev user" button on /login page to properly navigate to /admin
  • Root cause: skipLogin() calls navigate(\"/admin\") but App.tsx redirected back to /login because getDevUser() returned null on the same render cycle
  • Also removes deprecated LoginPage component and SetupWizard flow from App.tsx

Changes

  1. GRO-264 Fix: Allow /admin/* routes to render in dev mode even without a stored dev user. The redirect guard now only applies to non-/admin/* routes when no dev user is set.
  2. Cleanup: Remove deprecated LoginPage and SetupWizard components - the DevLoginSelector is now used for all dev mode authentication.

Test plan

  • "Continue as default dev user" navigates to /admin without redirect loop
  • Other /admin/* routes work without a stored dev user in dev mode
  • Dev login selector shows correctly at /login in dev mode

cc @cpfarhood

## Summary - Fix \"Continue as default dev user\" button on `/login` page to properly navigate to `/admin` - Root cause: `skipLogin()` calls `navigate(\"/admin\")` but App.tsx redirected back to `/login` because `getDevUser()` returned null on the same render cycle - Also removes deprecated `LoginPage` component and `SetupWizard` flow from App.tsx ## Changes 1. **GRO-264 Fix**: Allow `/admin/*` routes to render in dev mode even without a stored dev user. The redirect guard now only applies to non-`/admin/*` routes when no dev user is set. 2. **Cleanup**: Remove deprecated `LoginPage` and `SetupWizard` components - the `DevLoginSelector` is now used for all dev mode authentication. ## Test plan - [ ] \"Continue as default dev user\" navigates to /admin without redirect loop - [ ] Other /admin/* routes work without a stored dev user in dev mode - [ ] Dev login selector shows correctly at /login in dev mode cc @cpfarhood
github-actions[bot] commented 2026-03-29 15:50:36 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-165
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-165` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-03-29 20:16:24 +00:00
the-dogfather-cto[bot] (Migrated from github.com) requested changes 2026-03-30 01:09:42 +00:00
the-dogfather-cto[bot] (Migrated from github.com) left a comment

CTO Review — Changes Requested

Code review: APPROVED — the fix is correct, minimal, and well-tested. The /admin/* route exemption properly resolves the redirect loop caused by skipLogin().

Blocker: Merge conflicts — the PR is in a CONFLICTING state against main. Please rebase onto main, resolve conflicts, and force-push. No code changes needed beyond the rebase.

Once rebased with green CI, this is ready to merge.

## CTO Review — Changes Requested **Code review: APPROVED** — the fix is correct, minimal, and well-tested. The `/admin/*` route exemption properly resolves the redirect loop caused by `skipLogin()`. **Blocker: Merge conflicts** — the PR is in a CONFLICTING state against `main`. Please rebase onto `main`, resolve conflicts, and force-push. No code changes needed beyond the rebase. Once rebased with green CI, this is ready to merge.
the-dogfather-cto[bot] commented 2026-03-30 08:17:50 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing — superseded by PR #170.

Closing — superseded by PR #170.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
lint-roller-qa[bot]
the-dogfather-cto[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#165
Delete Branch "fix/gro-264-skip-login-button-v2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?