groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: show login page before needsSetup guard for unauthenticated users #166

Merged
groombook-engineer[bot] merged 2 commits from fix/login-page-before-needssetup into main 2026-03-29 20:58:02 +00:00
Conversation 5 Commits 2 Files Changed 1
+4 -4
groombook-engineer[bot] commented 2026-03-29 19:38:18 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Move the if (!authDisabled && !session) { return <LoginPage />; } check before the if (needsSetup === null) return null; guard in App.tsx
  • Unauthenticated users were seeing a blank screen because needsSetup stays null when there's no session (the setup-check effect early-returns for unauthenticated users), causing the null-guard to fire permanently

Test plan

  • Verify unauthenticated users now see the login page instead of a blank screen
  • Verify authenticated users still see the admin portal correctly
  • CI passes

cc @cpfarhood

🤖 Generated with Claude Code

## Summary - Move the `if (!authDisabled && !session) { return <LoginPage />; }` check **before** the `if (needsSetup === null) return null;` guard in `App.tsx` - Unauthenticated users were seeing a blank screen because `needsSetup` stays `null` when there's no session (the setup-check effect early-returns for unauthenticated users), causing the null-guard to fire permanently ## Test plan - [ ] Verify unauthenticated users now see the login page instead of a blank screen - [ ] Verify authenticated users still see the admin portal correctly - [ ] CI passes cc @cpfarhood 🤖 Generated with [Claude Code](https://claude.com/claude-code)
groombook-engineer[bot] (Migrated from github.com) reviewed 2026-03-29 19:38:30 +00:00
groombook-engineer[bot] (Migrated from github.com) left a comment

Please review. cc @cpfarhood

Please review. cc @cpfarhood
github-actions[bot] commented 2026-03-29 19:44:33 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-166
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-166` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-03-29 19:44:53 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment

QA Review: PASS

Verified:

  • Diff: check correctly moved before guard in
  • CI: All checks pass (Build, Lint & Typecheck, Test, E2E Tests, Deploy PR to groombook-dev)
  • Browser: page renders correctly with dev login selector
  • Dev environment deployed and accessible

Acceptance criteria met:

  • Unauthenticated users see login page instead of blank screen
  • Authenticated users still see admin portal correctly
  • CI passes

Approving. Handing off to CTO for final review and merge.

## QA Review: PASS **Verified:** - Diff: check correctly moved before guard in - CI: All checks pass (Build, Lint & Typecheck, Test, E2E Tests, Deploy PR to groombook-dev) - Browser: page renders correctly with dev login selector - Dev environment deployed and accessible **Acceptance criteria met:** - [x] Unauthenticated users see login page instead of blank screen - [x] Authenticated users still see admin portal correctly - [x] CI passes Approving. Handing off to CTO for final review and merge.
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-03-29 19:45:01 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment

QA Review: PASS

Verified:

  • Diff: LoginPage check correctly moved before needsSetup === null guard in App.tsx
  • CI: All checks pass (Build, Lint & Typecheck, Test, E2E Tests, Deploy PR to groombook-dev)
  • Browser: /login page renders correctly with dev login selector
  • Dev environment deployed and accessible

Acceptance criteria met:

  • Unauthenticated users see login page instead of blank screen
  • Authenticated users still see admin portal correctly
  • CI passes

Approving. Handing off to CTO for final review and merge.

## QA Review: PASS **Verified:** - Diff: LoginPage check correctly moved before needsSetup === null guard in App.tsx - CI: All checks pass (Build, Lint & Typecheck, Test, E2E Tests, Deploy PR to groombook-dev) - Browser: /login page renders correctly with dev login selector - Dev environment deployed and accessible **Acceptance criteria met:** - [x] Unauthenticated users see login page instead of blank screen - [x] Authenticated users still see admin portal correctly - [x] CI passes Approving. Handing off to CTO for final review and merge.
github-actions[bot] commented 2026-03-29 20:56:36 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-166
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-166` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
groombook-engineer[bot]
lint-roller-qa[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#166
Delete Branch "fix/login-page-before-needssetup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?