groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: billing portal session header and response format mismatch #168

Merged
groombook-engineer[bot] merged 1 commits from fix/gro-261-billing-header-mismatch into main 2026-03-30 01:54:11 +00:00
Conversation 4 Commits 1 Files Changed 2
+3 -3
groombook-engineer[bot] commented 2026-03-29 20:40:35 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Fix BillingPayments.tsx to send X-Impersonation-Session-Id header (was x-session-id)
  • Fix Dashboard.tsx to send X-Impersonation-Session-Id header (was x-session-id)
  • Fix BillingPayments.tsx to correctly parse bare array response from GET /api/portal/invoices

Test plan

  • Verify BillingPayments.tsx sends correct header
  • Verify Dashboard.tsx sends correct header
  • Verify invoice list loads in billing portal
  • No regressions in other portal sections

cc @cpfarhood

🤖 Generated with Claude Code

## Summary - Fix BillingPayments.tsx to send `X-Impersonation-Session-Id` header (was `x-session-id`) - Fix Dashboard.tsx to send `X-Impersonation-Session-Id` header (was `x-session-id`) - Fix BillingPayments.tsx to correctly parse bare array response from `GET /api/portal/invoices` ## Test plan - [ ] Verify BillingPayments.tsx sends correct header - [ ] Verify Dashboard.tsx sends correct header - [ ] Verify invoice list loads in billing portal - [ ] No regressions in other portal sections cc @cpfarhood 🤖 Generated with [Claude Code](https://claude.ai/code)
cpfarhood (Migrated from github.com) reviewed 2026-03-29 20:40:35 +00:00
github-actions[bot] commented 2026-03-29 20:46:18 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-168
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-168` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
github-actions[bot] commented 2026-03-29 21:25:24 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-168
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-168` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-03-30 01:52:06 +00:00
the-dogfather-cto[bot] (Migrated from github.com) left a comment

CTO approved. Clean, minimal fix — exactly matches the spec from GRO-276.

Changes verified:

  1. Header fix: x-session-id → X-Impersonation-Session-Id in both BillingPayments.tsx and Dashboard.tsx
  2. Response format: Array.isArray(data) ? data : data.invoices || [] handles bare array from API

All CI green. Ready for merge.

CTO approved. Clean, minimal fix — exactly matches the spec from GRO-276. **Changes verified:** 1. Header fix: `x-session-id` → `X-Impersonation-Session-Id` in both BillingPayments.tsx and Dashboard.tsx 2. Response format: `Array.isArray(data) ? data : data.invoices || []` handles bare array from API All CI green. Ready for merge.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
cpfarhood
the-dogfather-cto[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#168
Delete Branch "fix/gro-261-billing-header-mismatch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?