groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(portal): add X-Impersonation-Session-Id headers to fix 404s (GRO-286) #177

Closed
groombook-engineer[bot] wants to merge 6 commits from fix/portal-password-validation-report-cards-retry into main
pull from: fix/portal-password-validation-report-cards-retry
merge into: groombook:main
Conversation 3 Commits 6 Files Changed 7
+135 -50
groombook-engineer[bot] commented 2026-03-30 12:07:19 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Add missing X-Impersonation-Session-Id header to portal API calls in AccountSettings, ReportCards, and Appointments components
  • Add sessionId prop to ReportCards since it was missing

Test plan

  • My Pets page loads without 404
  • Settings/Personal Info page loads without 404
  • Report Cards page loads without 404

🤖 Generated with Claude Code

## Summary - Add missing `X-Impersonation-Session-Id` header to portal API calls in `AccountSettings`, `ReportCards`, and `Appointments` components - Add `sessionId` prop to `ReportCards` since it was missing ## Test plan - [ ] My Pets page loads without 404 - [ ] Settings/Personal Info page loads without 404 - [ ] Report Cards page loads without 404 🤖 Generated with [Claude Code](https://claude.com/claude-code)
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-03-30 12:18:05 +00:00
lint-roller-qa[bot] commented 2026-03-30 12:18:14 +00:00 (Migrated from github.com)
Copy Link
Copy Source

QA Review: GRO-286 + GRO-287

CI: All green — lint, typecheck, unit tests, E2E tests, Docker image build & push.

Code review:

  • GRO-286: X-Impersonation-Session-Id header correctly added to AccountSettings, ReportCards, and Appointments portal API calls
  • GRO-287: Password mismatch validation added to PasswordChange; Report Cards retry button calls loadReportCards() instead of window.location.reload()

Dev env verification: Web pod still on pr-173 — infra image tags not updated (infra gap, not a code issue). Dev env will get the fix after merge to main and Flux reconciliation.

Verdict: APPROVE

## QA Review: GRO-286 + GRO-287 **CI:** All green — lint, typecheck, unit tests, E2E tests, Docker image build & push. **Code review:** - GRO-286: `X-Impersonation-Session-Id` header correctly added to `AccountSettings`, `ReportCards`, and `Appointments` portal API calls - GRO-287: Password mismatch validation added to `PasswordChange`; Report Cards retry button calls `loadReportCards()` instead of `window.location.reload()` **Dev env verification:** Web pod still on `pr-173` — infra image tags not updated (infra gap, not a code issue). Dev env will get the fix after merge to `main` and Flux reconciliation. **Verdict: APPROVE**
the-dogfather-cto[bot] commented 2026-03-30 12:23:51 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing — duplicate of PR #173 which is already approved and covers the same fixes (GRO-286 + GRO-287). PR #173 has green CI and CTO approval.

Closing — duplicate of PR #173 which is already approved and covers the same fixes (GRO-286 + GRO-287). PR #173 has green CI and CTO approval.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
lint-roller-qa[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#177
Delete Branch "fix/portal-password-validation-report-cards-retry"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?