groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(staff): count only active super users in last-super-user guardrail (GRO-206) #183

Merged
groombook-engineer[bot] merged 1 commits from fix/gro-206-clean-rebase into main 2026-03-30 18:25:04 +00:00
Conversation 1 Commits 1 Files Changed 1
+3 -3
groombook-engineer[bot] commented 2026-03-30 14:51:51 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Add active=true filter to all 3 superUserCount queries in staff.ts (revoke, deactivate, delete) so inactive super users are not counted, preventing false positives in the last-super-user guardrail

Replaces PR #175 (closed due to complex rebase history)

Test plan

  • Revoking the last active super user is blocked with clear error
  • Deactivating the last active super user is blocked with clear error
  • Deleting the last active super user is blocked with clear error
  • Inactive super users do not affect the count

cc @cpfarhood

🤖 Generated with Claude Code

## Summary - Add active=true filter to all 3 superUserCount queries in staff.ts (revoke, deactivate, delete) so inactive super users are not counted, preventing false positives in the last-super-user guardrail Replaces PR #175 (closed due to complex rebase history) ## Test plan - [ ] Revoking the last active super user is blocked with clear error - [ ] Deactivating the last active super user is blocked with clear error - [ ] Deleting the last active super user is blocked with clear error - [ ] Inactive super users do not affect the count cc @cpfarhood 🤖 Generated with [Claude Code](https://claude.com/claude-code)
github-actions[bot] commented 2026-03-30 14:58:07 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-183
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-183` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#183
Delete Branch "fix/gro-206-clean-rebase"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?