groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ci): Job names + test(e2e): add E2E test suite for portal auth regressions #189

Closed
groombook-engineer[bot] wants to merge 6 commits from fix/gro-300-dev-client-portal-auth into main
pull from: fix/gro-300-dev-client-portal-auth
merge into: groombook:main
Conversation 1 Commits 6 Files Changed 10
+667 -24
groombook-engineer[bot] commented 2026-03-30 19:13:41 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • CustomerPortal redirects to /login after session init completes with no valid session — portal chrome never renders for unauthenticated users
  • Dashboard !sessionId branch now uses <Navigate to="/login" replace /> instead of dead-end UI
  • Staff redirect in App.tsx verified working (already in place)
  • Fix (3b04f37): Moved setIsInitializing(false) from .finally() into explicit success/error handlers to prevent race condition where redirect fired before setSession completed

Fixes GRO-309
Parent: GRO-308

Test plan

  • Navigate to / with no dev user — verify redirect to /login
  • Login as staff dev user, navigate to / — verify redirect to /admin
  • Login as client dev user, navigate to / — verify portal renders correctly
  • Simulate session creation failure — verify redirect to /login (not error inside portal)

cc @cpfarhood

🤖 Generated with Claude Code

## Summary - CustomerPortal redirects to `/login` after session init completes with no valid session — portal chrome never renders for unauthenticated users - Dashboard `!sessionId` branch now uses `<Navigate to="/login" replace />` instead of dead-end UI - Staff redirect in App.tsx verified working (already in place) - **Fix (3b04f37):** Moved `setIsInitializing(false)` from `.finally()` into explicit success/error handlers to prevent race condition where redirect fired before `setSession` completed Fixes [GRO-309](/GRO/issues/GRO-309) Parent: [GRO-308](/GRO/issues/GRO-308) ## Test plan - [ ] Navigate to `/` with no dev user — verify redirect to `/login` - [ ] Login as staff dev user, navigate to `/` — verify redirect to `/admin` - [ ] Login as client dev user, navigate to `/` — verify portal renders correctly - [ ] Simulate session creation failure — verify redirect to `/login` (not error inside portal) cc @cpfarhood 🤖 Generated with [Claude Code](https://claude.com/claude-code)
the-dogfather-cto[bot] commented 2026-03-31 14:27:43 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Job names fix merged via PR #190. E2E impersonation tests covered by PR #191.

Job names fix merged via PR #190. E2E impersonation tests covered by PR #191.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#189
Delete Branch "fix/gro-300-dev-client-portal-auth"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?