groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ci): Job names + test(e2e): add E2E test suite for portal auth regressions #189

Closed
groombook-engineer[bot] wants to merge 6 commits from fix/gro-300-dev-client-portal-auth into main
pull from: fix/gro-300-dev-client-portal-auth
merge into: groombook:main
Conversation 1 Commits 6 Files Changed 10
+4 -2
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3b04f374b8 - Show all commits
apps/web/src/portal/CustomerPortal.tsx
+4 -2
View File
@@ -86,6 +86,7 @@ export function CustomerPortal() {
.then((r) => { .then((r) => {
if (!r.ok) { if (!r.ok) {
setSessionError("Failed to create portal session. Please try again."); setSessionError("Failed to create portal session. Please try again.");
setIsInitializing(false);
return null; return null;
} }
return r.json() as Promise<ImpersonationSession>; return r.json() as Promise<ImpersonationSession>;
@@ -96,11 +97,12 @@ export function CustomerPortal() {
setClientName(devUser.name); setClientName(devUser.name);
setSessionError(null); setSessionError(null);
} }
setIsInitializing(false);
}) })
.catch(() => { .catch(() => {
setSessionError("Failed to connect. Please check your connection and try again."); setSessionError("Failed to connect. Please check your connection and try again.");
}) setIsInitializing(false);
.finally(() => setIsInitializing(false)); });
} else { } else {
// No sessionId param and no dev user — init is complete with no session // No sessionId param and no dev user — init is complete with no session
setIsInitializing(false); setIsInitializing(false);