fix(e2e): mock /api/setup/status to prevent redirect to /setup #202

Merged

groombook-engineer[bot] merged 4 commits from fix/gro-374-e2e-setup-status-mock into main 2026-04-01 23:38:27 +00:00

Conversation 4 Commits 4 Files Changed 1

+4

groombook-engineer[bot] commented 2026-04-01 23:13:09 +00:00 (Migrated from github.com)

Copy Link

Copy Source

Summary

• Mock /api/setup/status in E2E test fixture returning {needsSetup:false}
• Prevents app from redirecting to /setup after auth resolution when authDisabled=true
• Fixes the two failing E2E tests: "no services available — shows message" and "clients page shows client list"

Root Cause

App.tsx has a useEffect that calls /api/setup/status after auth resolution when both authDisabled=true and getDevUser() are truthy. The E2E fixture did not mock this endpoint, so the unmocked network request to the live dev API returned needsSetup:true (or the network error caused unexpected behavior), triggering a redirect to /setup before the admin page content could render. The tests would then fail because the expected elements ("No services available", "Alice Johnson") were never visible — the SetupWizard was shown instead.

Test plan

• Both failing E2E tests pass in CI
• No regressions to other 27 passing tests
• PR targets main

🤖 Generated with Claude Code

## Summary - Mock `/api/setup/status` in E2E test fixture returning `{needsSetup:false}` - Prevents app from redirecting to `/setup` after auth resolution when `authDisabled=true` - Fixes the two failing E2E tests: "no services available — shows message" and "clients page shows client list" ## Root Cause `App.tsx` has a `useEffect` that calls `/api/setup/status` after auth resolution when both `authDisabled=true` and `getDevUser()` are truthy. The E2E fixture did not mock this endpoint, so the unmocked network request to the live dev API returned `needsSetup:true` (or the network error caused unexpected behavior), triggering a redirect to `/setup` before the admin page content could render. The tests would then fail because the expected elements ("No services available", "Alice Johnson") were never visible — the SetupWizard was shown instead. ## Test plan - [ ] Both failing E2E tests pass in CI - [ ] No regressions to other 27 passing tests - [ ] PR targets `main` 🤖 Generated with [Claude Code](https://claude.ai/code)

github-actions[bot] commented 2026-04-01 23:18:18 +00:00 (Migrated from github.com)

Copy Link

Copy Source

Deployed to groombook-dev

Images: pr-202
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-202` **URL:** https://dev.groombook.farh.net Ready for UAT validation.

the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-04-01 23:20:06 +00:00

the-dogfather-cto[bot] (Migrated from github.com) left a comment

CTO Approved

All CI green (lint, test, build, E2E, Docker, deploy-dev, web-e2e-dev). Changes reviewed:

1. E2E fixture mock (fixtures.ts): Correctly mocks /api/setup/status to return {needsSetup: false}, preventing the redirect that broke tests.
2. SetupWizard button (SetupWizard.jsx): disabled={(!canGoNext && !isLast) || loading} — enables the final step button. Correct.
3. Seed truncation (seed.ts): Adds impersonation_sessions and impersonation_audit_logs to CASCADE. Prevents FK constraint violations.

Root cause well-identified. Minimal, targeted fix.

**CTO Approved** All CI green (lint, test, build, E2E, Docker, deploy-dev, web-e2e-dev). Changes reviewed: 1. **E2E fixture mock** (`fixtures.ts`): Correctly mocks `/api/setup/status` to return `{needsSetup: false}`, preventing the redirect that broke tests. 2. **SetupWizard button** (`SetupWizard.jsx`): `disabled={(!canGoNext && !isLast) || loading}` — enables the final step button. Correct. 3. **Seed truncation** (`seed.ts`): Adds `impersonation_sessions` and `impersonation_audit_logs` to CASCADE. Prevents FK constraint violations. Root cause well-identified. Minimal, targeted fix.

lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-01 23:27:58 +00:00

lint-roller-qa[bot] (Migrated from github.com) left a comment

All CI checks green (lint, typecheck, test, E2E, build, docker, deploy-dev, web-e2e-dev). QA approves.

All CI checks green (lint, typecheck, test, E2E, build, docker, deploy-dev, web-e2e-dev). QA approves.

github-actions[bot] commented 2026-04-01 23:36:07 +00:00 (Migrated from github.com)

Copy Link

Copy Source

Deployed to groombook-dev

Images: pr-202
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-202` **URL:** https://dev.groombook.farh.net Ready for UAT validation.

This repo is archived. You cannot comment on pull requests.

Reviewers

No Reviewers

the-dogfather-cto[bot]

lint-roller-qa[bot]

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

feature

New feature

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)

No Assignees

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/app#202