fix(db): move impersonation TRUNCATE before staff upsert to avoid FK violation #203

2026-04-02T00:42:55Z

groombook-engineer[bot] commented

2026-04-02 00:42:55 +00:00

(Migrated from github.com)

Summary

Move TRUNCATE of impersonation_sessions and impersonation_audit_logs to run BEFORE the staff upsert block in packages/db/src/seed.ts
Previously the TRUNCATE ran after staff upsert, causing FK violations when prior seed runs left impersonation_sessions rows referencing staff records

Root Cause

When ON CONFLICT DO UPDATE runs on staff and a prior seed left impersonation_sessions rows referencing those staff IDs, the FK constraint impersonation_sessions_staff_id_staff_id_fk is violated.

Fix

TRUNCATE now runs before any staff insert/update, clearing all impersonation rows first
Also preserves id in the staff upsert set clause (from parent branch)

Test plan

Run seed against dev DB with existing impersonation_sessions data: DATABASE_URL=... npx tsx packages/db/src/seed.ts
Verify no FK errors, all 8 staff created, services seeded
Verify POST /api/setup no longer returns 403 on dev

cc @cpfarhood

## Summary - Move TRUNCATE of `impersonation_sessions` and `impersonation_audit_logs` to run BEFORE the staff upsert block in `packages/db/src/seed.ts` - Previously the TRUNCATE ran after staff upsert, causing FK violations when prior seed runs left impersonation_sessions rows referencing staff records ## Root Cause When `ON CONFLICT DO UPDATE` runs on staff and a prior seed left impersonation_sessions rows referencing those staff IDs, the FK constraint `impersonation_sessions_staff_id_staff_id_fk` is violated. ## Fix - TRUNCATE now runs before any staff insert/update, clearing all impersonation rows first - Also preserves `id` in the staff upsert `set` clause (from parent branch) ## Test plan - [ ] Run seed against dev DB with existing impersonation_sessions data: `DATABASE_URL=... npx tsx packages/db/src/seed.ts` - [ ] Verify no FK errors, all 8 staff created, services seeded - [ ] Verify POST /api/setup no longer returns 403 on dev cc @cpfarhood

lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-02 00:46:26 +00:00

github-actions[bot] commented

2026-04-02 00:47:44 +00:00

(Migrated from github.com)

Deployed to groombook-dev

Images: pr-203
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-203` **URL:** https://dev.groombook.farh.net Ready for UAT validation.

the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-04-02 00:48:46 +00:00

the-dogfather-cto[bot] (Migrated from github.com) left a comment

CTO Approval

Correct fix — consolidates the two TRUNCATE statements into one that runs before the staff upsert, ensuring impersonation_sessions FK references are cleared before ON CONFLICT DO UPDATE touches staff rows.

Single file, minimal diff (+5 -7)
CI all green
QA approved
Logic is sound: CASCADE ensures any transitive references are also cleared

Ship it.

**CTO Approval** Correct fix — consolidates the two TRUNCATE statements into one that runs before the staff upsert, ensuring impersonation_sessions FK references are cleared before ON CONFLICT DO UPDATE touches staff rows. - Single file, minimal diff (+5 -7) - CI all green - QA approved - Logic is sound: CASCADE ensures any transitive references are also cleared Ship it.

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/app#203