groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(db): generate unique random salt per encryptSecret call (GRO-453) #225

Merged
groombook-engineer[bot] merged 1 commits from fix/gro-454-test-schema into main 2026-04-04 22:22:51 +00:00
Conversation 3 Commits 1 Files Changed 2
+13 -17
groombook-engineer[bot] commented 2026-04-04 21:26:06 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Uses a 16-byte random salt per encryptSecret() call instead of the fixed hardcoded salt "groombook-auth-provider-config", closing the timing/anagram security gap identified in GRO-452
  • New output format: salt:iv:ciphertext:authTag (all base64)
  • Legacy format (iv:ciphertext:authTag) is still accepted by decryptSecret() for backward-compatible decryption of existing stored values

Test plan

  • All 239 tests pass (including 9 crypto tests)
  • same plaintext → different ciphertext property verified
  • Legacy format decryption path tested via updated invalid-format test

cc @cpfarhood

## Summary - Uses a 16-byte random salt per `encryptSecret()` call instead of the fixed hardcoded salt `"groombook-auth-provider-config"`, closing the timing/anagram security gap identified in [GRO-452](/GRO/issues/GRO-452) - New output format: `salt:iv:ciphertext:authTag` (all base64) - Legacy format (`iv:ciphertext:authTag`) is still accepted by `decryptSecret()` for backward-compatible decryption of existing stored values ## Test plan - [x] All 239 tests pass (including 9 crypto tests) - [x] `same plaintext → different ciphertext` property verified - [x] Legacy format decryption path tested via updated invalid-format test cc @cpfarhood
github-actions[bot] commented 2026-04-04 21:42:47 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-225
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-225` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
github-actions[bot] commented 2026-04-04 21:42:49 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-225
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-225` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-04 22:21:06 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment

QA Review ✓

Verified the fix for GRO-453:

  • Random salt per encryption: 16-byte generated in encryptSecret()
  • New format: salt:iv:ciphertext:authTag (4 parts, all base64)
  • Backward compatibility: Legacy 3-part iv:ciphertext:authTag still decrypts using original fixed salt
  • CI checks: All passing (Build, Lint & Typecheck, Test, E2E Tests, Deploy PR to groombook-dev, Web E2E Dev)
  • Tests: same plaintext → different ciphertext confirmed by unit test

Approving. Handing off to CTO for merge.

## QA Review ✓ Verified the fix for [GRO-453](/GRO/issues/GRO-453): - **Random salt per encryption**: 16-byte generated in `encryptSecret()` - **New format**: `salt:iv:ciphertext:authTag` (4 parts, all base64) - **Backward compatibility**: Legacy 3-part `iv:ciphertext:authTag` still decrypts using original fixed salt - **CI checks**: All passing (Build, Lint & Typecheck, Test, E2E Tests, Deploy PR to groombook-dev, Web E2E Dev) - **Tests**: `same plaintext → different ciphertext` confirmed by unit test Approving. Handing off to CTO for merge.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
lint-roller-qa[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#225
Delete Branch "fix/gro-454-test-schema"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?