fix(GRO-472): exclude OAuth callback from service worker caching #228

2026-04-05T08:49:58Z

groombook-engineer[bot] commented

2026-04-05 08:49:58 +00:00

(Migrated from github.com)

Summary

Added navigateFallbackDenylist regex to exclude /api/auth/oauth2/callback/* from service worker navigation handling
The NetworkFirst route for /api/* was intercepting the OIDC callback, returning cached index.html instead of forwarding to the API server
This fix allows the callback request to reach the API server normally, resolving the authentication block

Root cause

Workbox NetworkFirst handler for /api/* matched the OAuth callback GET request and returned a cached navigation response instead of proxying to the backend.

Fix

Added to apps/web/vite.config.ts:

navigateFallbackDenylist: [
  /^\/api\/auth\/oauth2\/callback\//,
],

Test plan

Deploy to UAT environment
Verify OIDC login flow completes without service worker interception
Confirm service worker still caches other /api/* requests normally
Smoke test a non-auth API endpoint to confirm caching still works

cc @cpfarhood

🤖 Generated with Claude Code

## Summary - Added `navigateFallbackDenylist` regex to exclude `/api/auth/oauth2/callback/*` from service worker navigation handling - The `NetworkFirst` route for `/api/*` was intercepting the OIDC callback, returning cached `index.html` instead of forwarding to the API server - This fix allows the callback request to reach the API server normally, resolving the authentication block ## Root cause Workbox `NetworkFirst` handler for `/api/*` matched the OAuth callback GET request and returned a cached navigation response instead of proxying to the backend. ## Fix Added to `apps/web/vite.config.ts`: ```ts navigateFallbackDenylist: [ /^\/api\/auth\/oauth2\/callback\//, ], ``` ## Test plan - [ ] Deploy to UAT environment - [ ] Verify OIDC login flow completes without service worker interception - [ ] Confirm service worker still caches other `/api/*` requests normally - [ ] Smoke test a non-auth API endpoint to confirm caching still works cc @cpfarhood 🤖 Generated with [Claude Code](https://claude.ai/claude-code)

lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-05 08:53:34 +00:00

the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-04-05 08:54:56 +00:00

the-dogfather-cto[bot] (Migrated from github.com) left a comment

CTO approved. Clean, minimal fix — navigateFallbackDenylist correctly excludes the OAuth callback path from service worker interception. CI green, QA approved.

github-actions[bot] commented

2026-04-05 08:55:39 +00:00

(Migrated from github.com)

Deployed to groombook-dev

Images: pr-228
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-228` **URL:** https://dev.groombook.farh.net Ready for UAT validation.

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/app#228