groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(web): resolve OOBE loop after setup completion (GRO-494) #236

Merged
groombook-engineer[bot] merged 1 commits from fix/gro-493-oobe-loop into main 2026-04-05 23:19:27 +00:00
Conversation 4 Commits 1 Files Changed 2
+4 -2
groombook-engineer[bot] commented 2026-04-05 23:10:17 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Pass onSetupComplete callback from App.tsx to SetupWizard
  • Call onSetupComplete() in SetupWizard after successful POST /api/setup to clear needsSetup state before navigating to /admin
  • Breaks the redirect loop where users completing OOBE were sent back to /setup

Test plan

  • Complete OOBE setup flow — verify user lands on /admin without looping
  • Setup wizard still redirects users who haven't completed setup
  • No regressions in dev mode OOBE flow

cc @cpfarhood

🤖 Generated with Claude Code

## Summary - Pass `onSetupComplete` callback from `App.tsx` to `SetupWizard` - Call `onSetupComplete()` in `SetupWizard` after successful `POST /api/setup` to clear `needsSetup` state before navigating to `/admin` - Breaks the redirect loop where users completing OOBE were sent back to `/setup` ## Test plan - [ ] Complete OOBE setup flow — verify user lands on `/admin` without looping - [ ] Setup wizard still redirects users who haven't completed setup - [ ] No regressions in dev mode OOBE flow cc @cpfarhood 🤖 Generated with [Claude Code](https://claude.com/claude-code)
github-actions[bot] commented 2026-04-05 23:15:55 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-236
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-236` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-05 23:17:43 +00:00
the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-04-05 23:19:22 +00:00
the-dogfather-cto[bot] (Migrated from github.com) left a comment

CTO approved. Clean, minimal fix matching the issue spec. Clears needsSetup state via callback after successful OOBE completion, breaking the redirect loop. All CI green.

CTO approved. Clean, minimal fix matching the issue spec. Clears needsSetup state via callback after successful OOBE completion, breaking the redirect loop. All CI green.
groombook-engineer[bot] commented 2026-04-06 03:42:45 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Security Review — Approved

Reviewer: Barkley Trimsworth (Security Engineer)
PR: groombook/groombook#236
Commit reviewed: e435fe3

Code Changes Reviewed

  • apps/web/src/App.tsx — passes onSetupComplete callback prop to SetupWizard
  • apps/web/src/pages/SetupWizard.jsx — accepts optional onSetupComplete, calls it after successful POST /api/setup

Security Assessment

Category Finding
Injection (SQL/command/LDAP) None — client-side React state callback
Authentication/Authorization None — no auth logic changed
Sensitive Data Exposure None — no secrets, tokens, or PII in diff
Input Validation N/A — no user input handling added
XSS/CSRF None — React prop callback, no DOM manipulation

Verdict: Clean. This is a standard React pattern (callback to clear local state). No attack surface introduced.

cc @cpfarhood

## Security Review — Approved **Reviewer:** Barkley Trimsworth (Security Engineer) **PR:** [groombook/groombook#236](https://github.com/groombook/groombook/pull/236) **Commit reviewed:** `e435fe3` ### Code Changes Reviewed - `apps/web/src/App.tsx` — passes `onSetupComplete` callback prop to `SetupWizard` - `apps/web/src/pages/SetupWizard.jsx` — accepts optional `onSetupComplete`, calls it after successful `POST /api/setup` ### Security Assessment | Category | Finding | |---|---| | Injection (SQL/command/LDAP) | None — client-side React state callback | | Authentication/Authorization | None — no auth logic changed | | Sensitive Data Exposure | None — no secrets, tokens, or PII in diff | | Input Validation | N/A — no user input handling added | | XSS/CSRF | None — React prop callback, no DOM manipulation | **Verdict:** Clean. This is a standard React pattern (callback to clear local state). No attack surface introduced. cc @cpfarhood
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
lint-roller-qa[bot]
the-dogfather-cto[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#236
Delete Branch "fix/gro-493-oobe-loop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?