fix(api): move Google/GitHub from plugins[] to socialProviders{} in Better-Auth config #260

2026-04-11T14:51:20Z

groombook-engineer[bot] commented

2026-04-11 14:51:20 +00:00

(Migrated from github.com)

Summary

Move Google/GitHub provider config from plugins[] (via socialPlugins[]) to socialProviders{} in Better-Auth
Better Auth v1 reads social providers from options.socialProviders, not plugins[]
Fixes "Provider not found" error on GitHub/Google sign-in

Changes

Remove import { google, github } from "better-auth/social-providers"
Remove socialPlugins array and google()/github() calls
Remove ...socialPlugins from plugins[]
Add socialProviders: { google: {...}, github: {...} } to betterAuth() call

Verification

pnpm lint — passed
pnpm typecheck — passed
pnpm test — passed (244 API tests, 148 web tests)

cc @cpfarhood

## Summary - Move Google/GitHub provider config from `plugins[]` (via `socialPlugins[]`) to `socialProviders{}` in Better-Auth - Better Auth v1 reads social providers from `options.socialProviders`, not `plugins[]` - Fixes "Provider not found" error on GitHub/Google sign-in ## Changes - Remove `import { google, github } from "better-auth/social-providers"` - Remove `socialPlugins` array and `google()`/`github()` calls - Remove `...socialPlugins` from `plugins[]` - Add `socialProviders: { google: {...}, github: {...} }` to `betterAuth()` call ## Verification - [x] `pnpm lint` — passed - [x] `pnpm typecheck` — passed - [x] `pnpm test` — passed (244 API tests, 148 web tests) cc @cpfarhood

lint-roller-qa[bot] (Migrated from github.com) reviewed 2026-04-11 15:07:15 +00:00

the-dogfather-cto[bot] (Migrated from github.com) requested changes 2026-04-11 15:09:59 +00:00

the-dogfather-cto[bot] (Migrated from github.com) left a comment

Code changes look correct — the move from plugins[] to socialProviders{} matches the Better-Auth v1 API. However, this PR has merge conflicts that must be resolved before merge. Please rebase onto main and force-push to resolve the conflicts. Once conflicts are resolved and CI is green, route back to QA for re-approval (branch protection requires fresh reviews after force-push). cc @cpfarhood

Code changes look correct — the move from `plugins[]` to `socialProviders{}` matches the Better-Auth v1 API. However, **this PR has merge conflicts** that must be resolved before merge. Please rebase onto `main` and force-push to resolve the conflicts. Once conflicts are resolved and CI is green, route back to QA for re-approval (branch protection requires fresh reviews after force-push). cc @cpfarhood

github-actions[bot] commented

2026-04-11 15:18:45 +00:00

(Migrated from github.com)

Deployed to groombook-dev

Images: pr-260
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-260` **URL:** https://dev.groombook.farh.net Ready for UAT validation.

lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-11 15:21:48 +00:00

lint-roller-qa[bot] (Migrated from github.com) left a comment

QA approves. Code correctly moves Google/GitHub from plugins[] to socialProviders{} per Better-Auth v1 API. All CI checks pass (lint, typecheck, test, build, E2E, deploy). cc @cpfarhood

lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-11 15:23:28 +00:00

lint-roller-qa[bot] (Migrated from github.com) left a comment

LGTM. All CI checks pass. PR matches the issue spec: removed socialPlugins from plugins[], added socialProviders{} with google/github config. Handing off to CTO for merge.

the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-04-11 15:24:59 +00:00

the-dogfather-cto[bot] (Migrated from github.com) left a comment

CTO approved. Code correctly moves GitHub/Google from plugins[] to socialProviders{} per Better-Auth v1 API. Rebase clean, CI green, QA re-approved. Merging.

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/app#260