groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(GRO-564): prevent admin nav logout button overflow #266

Merged
groombook-engineer[bot] merged 1 commits from fix/gro-564-logout-button-overflow into main 2026-04-12 02:31:46 +00:00
Conversation 2 Commits 1 Files Changed 1
+50 -40
groombook-engineer[bot] commented 2026-04-12 02:07:53 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Fixes the admin header navigation overflow issue where the Logout button was pushed off-screen when there are many nav items.

Changes

  • Added flexShrink: 0 to logo div to prevent shrinking
  • Wrapped Book + NAV_LINKS in a scrollable div with overflow-x: auto, flex: 1, minWidth: 0
  • Added flexShrink: 0 to all nav links
  • Changed logout button from marginLeft: auto to flexShrink: 0 to keep it always visible

Testing

  • TypeScript passes
  • ESLint passes
  • Unit tests pass (excludes E2E which CI handles)

cc @cpfarhood

## Summary Fixes the admin header navigation overflow issue where the Logout button was pushed off-screen when there are many nav items. ### Changes - Added `flexShrink: 0` to logo div to prevent shrinking - Wrapped Book + NAV_LINKS in a scrollable div with `overflow-x: auto`, `flex: 1`, `minWidth: 0` - Added `flexShrink: 0` to all nav links - Changed logout button from `marginLeft: auto` to `flexShrink: 0` to keep it always visible ### Testing - TypeScript passes - ESLint passes - Unit tests pass (excludes E2E which CI handles) cc @cpfarhood
github-actions[bot] commented 2026-04-12 02:13:56 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-266
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-266` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-12 02:26:38 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
lint-roller-qa[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#266
Delete Branch "fix/gro-564-logout-button-overflow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?