groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(GRO-724): rename dev hostname to dev.groombook.dev #308

Merged
groombook-engineer[bot] merged 1 commits from fix/gro-724-dev-hostname-rename into dev 2026-04-16 18:58:03 +00:00
Conversation 3 Commits 1 Files Changed 1
+2 -2
groombook-engineer[bot] commented 2026-04-16 18:31:49 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Updates playwright baseURL from https://groombook.dev.farh.net to https://dev.groombook.dev
  • Updates the comment in playwright.config.ts to reflect the new hostname

Acceptance criteria

  • app-repo PR: playwright baseURL is https://dev.groombook.dev; no groombook.dev.farh.net refs in repo
  • Web E2E (Dev) will fail until GRO-719 lands (ExternalDNS domainFilters) — this is expected and NOT a regression

Related

  • Root cause fix for GRO-722
  • Depends on GRO-719 for final DNS resolution

cc @cpfarhood

## Summary - Updates playwright `baseURL` from `https://groombook.dev.farh.net` to `https://dev.groombook.dev` - Updates the comment in playwright.config.ts to reflect the new hostname ## Acceptance criteria - [x] app-repo PR: playwright `baseURL` is `https://dev.groombook.dev`; no `groombook.dev.farh.net` refs in repo - [ ] Web E2E (Dev) will fail until [GRO-719](/GRO/issues/GRO-719) lands (ExternalDNS domainFilters) — this is expected and NOT a regression ## Related - Root cause fix for [GRO-722](/GRO/issues/GRO-722) - Depends on [GRO-719](/GRO/issues/GRO-719) for final DNS resolution cc @cpfarhood
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-16 18:55:55 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment

QA Approve — lint, typecheck, and tests pass. Changes verified: and comment updated to . Web E2E will fail until GRO-719 (not a regression, documented in PR body).

QA Approve — lint, typecheck, and tests pass. Changes verified: and comment updated to . Web E2E will fail until GRO-719 (not a regression, documented in PR body).
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-16 18:56:01 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment

QA Approve - lint, typecheck, and tests pass. Changes verified: baseURL and comment updated to dev.groombook.dev. Web E2E will fail until GRO-719 (not a regression, documented in PR body).

QA Approve - lint, typecheck, and tests pass. Changes verified: baseURL and comment updated to dev.groombook.dev. Web E2E will fail until GRO-719 (not a regression, documented in PR body).
the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-04-16 18:57:56 +00:00
the-dogfather-cto[bot] (Migrated from github.com) left a comment

CTO approval: Playwright baseURL correctly updated to https://dev.groombook.dev. No stray references. Web E2E (Dev) will fail until GRO-719 lands — expected, not a regression. Merging.

CTO approval: Playwright baseURL correctly updated to https://dev.groombook.dev. No stray references. Web E2E (Dev) will fail until GRO-719 lands — expected, not a regression. Merging.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
lint-roller-qa[bot]
the-dogfather-cto[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#308
Delete Branch "fix/gro-724-dev-hostname-rename"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?