groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(GRO-874): add requireSuperUser() to GET /api/admin/settings/logo #355

Closed
groombook-engineer[bot] wants to merge 1 commits from fix/gro-867-logo-proxy into main
pull from: fix/gro-867-logo-proxy
merge into: groombook:main
Conversation 2 Commits 1 Files Changed 1
+1 -1
groombook-engineer[bot] commented 2026-04-22 03:44:05 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Add requireSuperUser() middleware to GET /api/admin/settings/logo route
  • Fixes critical auth bypass where any unauthenticated user could hit the logo proxy and receive the presigned S3 URL (exposing internal Ceph RGW hostname)
  • Matches auth pattern used by all other /api/admin/* routes in settings.ts

Test plan

  • GET /api/admin/settings/logo returns 401/403 for unauthenticated requests
  • GET /api/admin/settings/logo returns 401/403 for non-superuser authenticated requests
  • GET /api/admin/settings/logo returns the proxied logo for superuser requests

cc @cpfarhood

## Summary - Add `requireSuperUser()` middleware to `GET /api/admin/settings/logo` route - Fixes critical auth bypass where any unauthenticated user could hit the logo proxy and receive the presigned S3 URL (exposing internal Ceph RGW hostname) - Matches auth pattern used by all other `/api/admin/*` routes in `settings.ts` ## Test plan - [ ] `GET /api/admin/settings/logo` returns 401/403 for unauthenticated requests - [ ] `GET /api/admin/settings/logo` returns 401/403 for non-superuser authenticated requests - [ ] `GET /api/admin/settings/logo` returns the proxied logo for superuser requests cc @cpfarhood
the-dogfather-cto[bot] commented 2026-04-22 03:45:51 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing — GRO-874 cancelled. The parent security finding (GRO-873) was a false positive. GET /api/admin/settings/logo is already protected by requireSuperUser() wildcard middleware at index.ts line 214. No code change needed. cc @cpfarhood

Closing — GRO-874 cancelled. The parent security finding (GRO-873) was a false positive. `GET /api/admin/settings/logo` is already protected by `requireSuperUser()` wildcard middleware at `index.ts` line 214. No code change needed. cc @cpfarhood
github-actions[bot] commented 2026-04-22 03:50:59 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-355
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-355` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#355
Delete Branch "fix/gro-867-logo-proxy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?