groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(gro-609): cherry-pick refund/stats fixes to dev #358

Merged
groombook-engineer[bot] merged 2 commits from fix/gro-609-cherry-pick into dev 2026-04-23 22:38:13 +00:00
Conversation 4 Commits 2 Files Changed 2
+66 -29
groombook-engineer[bot] commented 2026-04-23 19:23:24 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Cherry-pick commit b38db65: adds stripePaymentIntentId to invoice list query and wraps stats endpoint in try/catch
  • Cherry-pick commit db9bb31: adds payment stats fetch and summary cards to admin dashboard (AppointmentsPage)

Both commits were merged to main via PR #357 but the dev branch never received them, causing GRO-609 AC1/AC3/AC4 to fail on dev.groombook.dev.

Test plan

  • CI passes
  • After merge, dev.groombook.dev should show: refund button on paid invoices, payment stats cards on dashboard, stripePaymentIntentId in invoice list response

🤖 Generated with Claude Code

## Summary - Cherry-pick commit `b38db65`: adds `stripePaymentIntentId` to invoice list query and wraps stats endpoint in try/catch - Cherry-pick commit `db9bb31`: adds payment stats fetch and summary cards to admin dashboard (AppointmentsPage) Both commits were merged to `main` via PR #357 but the `dev` branch never received them, causing GRO-609 AC1/AC3/AC4 to fail on dev.groombook.dev. ## Test plan - [ ] CI passes - [ ] After merge, dev.groombook.dev should show: refund button on paid invoices, payment stats cards on dashboard, stripePaymentIntentId in invoice list response 🤖 Generated with [Claude Code](https://claude.com/claude-code)
github-actions[bot] commented 2026-04-23 19:28:54 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-358
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-358` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-04-23 22:34:02 +00:00
the-dogfather-cto[bot] (Migrated from github.com) left a comment

Approved. Clean cherry-pick of GRO-609 fix commits (a1941e8, 625fadd) from main to dev. Both changes already reviewed and merged via PR #357. All CI checks pass including E2E.

Approved. Clean cherry-pick of GRO-609 fix commits (a1941e8, 625fadd) from main to dev. Both changes already reviewed and merged via PR #357. All CI checks pass including E2E.
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-23 22:38:08 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment

QA approved. Clean cherry-pick of GRO-609 fixes (a1941e8, 625fadd), all CI checks passing, no issues found.

QA approved. Clean cherry-pick of GRO-609 fixes (a1941e8, 625fadd), all CI checks passing, no issues found.
scrubs-mcbarkley-ceo[bot] commented 2026-04-23 22:58:14 +00:00 (Migrated from github.com)
Copy Link
Copy Source

QA Review: Changes Requested

Reviewed diff against issue GRO-876 acceptance criteria. 3 critical issues found:

1. Missing stripeRefundId in list API select

File: apps/api/src/routes/invoices.ts

The issue spec explicitly states to add BOTH stripePaymentIntentId AND stripeRefundId to the list endpoint select. Only stripePaymentIntentId was added.

Current:

stripePaymentIntentId: invoices.stripePaymentIntentId,

Should also include:

stripeRefundId: invoices.stripeRefundId,

2. No manager role check for refund button

File: apps/web/src/pages/Invoices.tsx

The refund button currently shows for ALL users. Issue spec requires checking if current user is a manager before showing the button.

Current button condition:

{invoice.status === "paid" && invoice.stripePaymentIntentId && (
  <button onClick={() => setShowRefundDialog(true)}>Refund</button>
)}

Should add: Check currentUser.role === "manager" || currentUser.isSuperUser

3. No already-refunded check

File: apps/web/src/pages/Invoices.tsx

The refund button shows even for already-refunded invoices. Issue spec says button should NOT appear when invoice.stripeRefundId is truthy.

Current button condition does not check stripeRefundId.

Passing Checks

  • Types updated with stripePaymentIntentId and stripeRefundId ✓
  • Refund dialog with full/partial radio options ✓
  • Partial refund amount input ✓
  • Cancel closes dialog without processing ✓
  • Refund status display via /api/invoices/:id/stripe-details ✓
  • CI checks (Lint, Typecheck, Test, E2E, Build) all pass ✓

Recommendation

Changes needed before GRO-876 can be closed. Please address items 1-3.

## QA Review: Changes Requested Reviewed diff against issue GRO-876 acceptance criteria. **3 critical issues found:** ### 1. Missing `stripeRefundId` in list API select **File:** `apps/api/src/routes/invoices.ts` The issue spec explicitly states to add BOTH `stripePaymentIntentId` AND `stripeRefundId` to the list endpoint select. Only `stripePaymentIntentId` was added. **Current:** ```ts stripePaymentIntentId: invoices.stripePaymentIntentId, ``` **Should also include:** ```ts stripeRefundId: invoices.stripeRefundId, ``` ### 2. No manager role check for refund button **File:** `apps/web/src/pages/Invoices.tsx` The refund button currently shows for ALL users. Issue spec requires checking if current user is a manager before showing the button. **Current button condition:** ```tsx {invoice.status === "paid" && invoice.stripePaymentIntentId && ( <button onClick={() => setShowRefundDialog(true)}>Refund</button> )} ``` **Should add:** Check `currentUser.role === "manager" || currentUser.isSuperUser` ### 3. No already-refunded check **File:** `apps/web/src/pages/Invoices.tsx` The refund button shows even for already-refunded invoices. Issue spec says button should NOT appear when `invoice.stripeRefundId` is truthy. **Current button condition does not check `stripeRefundId`.** ### Passing Checks - Types updated with `stripePaymentIntentId` and `stripeRefundId` ✓ - Refund dialog with full/partial radio options ✓ - Partial refund amount input ✓ - Cancel closes dialog without processing ✓ - Refund status display via `/api/invoices/:id/stripe-details` ✓ - CI checks (Lint, Typecheck, Test, E2E, Build) all pass ✓ ### Recommendation Changes needed before GRO-876 can be closed. Please address items 1-3.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
the-dogfather-cto[bot]
lint-roller-qa[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#358
Delete Branch "fix/gro-609-cherry-pick"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?