groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(auth): override Better Auth sign-in rate limit defaults #383

Closed
groombook-engineer[bot] wants to merge 5 commits from fix/gro-1021-auth-rate-limit into dev
pull from: fix/gro-1021-auth-rate-limit
merge into: groombook:dev
Conversation 3 Commits 5 Files Changed 3
+8 -1

5 Commits

Author SHA1 Message Date
Chris Farhood 2883287785 fix(api): regenerate pnpm-lock.yaml without uuid deps 
- Remove stale uuid@11.1.1 and @types/uuid@10.0.0 entries
- Resolves QA concern about stale lockfile after outbound.ts removal

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-05 03:32:30 +00:00
Chris Farhood 5bb10743ab fix(auth): correct indentation in both rateLimit blocks 
- First block: customRules at 10-space indent (inside rateLimit at 8)
- Second block: same 10-space indent structure
- Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-04 21:28:59 +00:00
Chris Farhood 28b3caccfe fix(auth): override Better Auth sign-in rate limit defaults 
QA fixes:
- Fix indentation in first rateLimit block (10-space indent)
- Remove out-of-scope files (outbound.ts, outbound.test.ts)
- Remove uuid/@types/uuid dependencies added for out-of-scope files
- Add cc @cpfarhood to PR description
 2026-05-04 21:26:15 +00:00
Chris Farhood 57fe69eaf7 fix(auth): override Better Auth sign-in rate limit defaults 
Override Better Auth default rate limits for /sign-in/* and /sign-up/*
paths by adding customRules to both rateLimit blocks in auth.ts:
- /sign-in/social: max 10, window 60
- /sign-in/email: max 10, window 60
- /sign-up/email: max 5, window 60
- /get-session: false (unchanged)

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-04 21:20:26 +00:00
Chris Farhood 7e83db479c feat(GRO-984): outbound SMS persistence 
- Add sendMessage() to outbound.ts with opt-in check, find/create conversation, queued→sent/failed transitions
- Add unit tests for success, opt-out suppression, missing tenant phone
- Add uuid and @types/uuid to package.json dependencies
- sms.ts unchanged (already Telnyx transport only on dev)

PR for GRO-1016 (replacement for #379)
Closes GRO-984

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-04 17:45:56 +00:00