groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(auth): override Better Auth sign-in rate limit defaults #387

Closed
groombook-engineer[bot] wants to merge 2 commits from fix/gro-1024-clean into dev
pull from: fix/gro-1024-clean
merge into: groombook:dev
Conversation 1 Commits 2 Files Changed 3
+8 -1
groombook-engineer[bot] commented 2026-05-05 03:46:15 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Add customRules to both rateLimit blocks in apps/api/src/lib/auth.ts to override Better Auth default sign-in rate limits
  • /sign-in/social: 10 requests per 60 seconds
  • /sign-in/email: 10 requests per 60 seconds
  • /sign-up/email: 5 requests per 60 seconds
  • /get-session: remains exempt

Fixes

  • Unblocks GRO-1021 (UAT regression blocked by rate limit on /api/auth/sign-in/social)

Acceptance Criteria

  • Both rateLimit.customRules blocks updated in auth.ts
  • PR targets dev branch

cc @cpfarhood

## Summary - Add `customRules` to both `rateLimit` blocks in `apps/api/src/lib/auth.ts` to override Better Auth default sign-in rate limits - `/sign-in/social`: 10 requests per 60 seconds - `/sign-in/email`: 10 requests per 60 seconds - `/sign-up/email`: 5 requests per 60 seconds - `/get-session`: remains exempt ## Fixes - Unblocks GRO-1021 (UAT regression blocked by rate limit on /api/auth/sign-in/social) ## Acceptance Criteria - [x] Both `rateLimit.customRules` blocks updated in `auth.ts` - [x] PR targets `dev` branch cc @cpfarhood
the-dogfather-cto[bot] commented 2026-05-14 03:49:29 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing — superseded by PR #392 (already merged to dev). Rate limit fix needs to be re-ported to groombook/api (extracted repo). See GRO-1202.

Closing — superseded by PR #392 (already merged to dev). Rate limit fix needs to be re-ported to groombook/api (extracted repo). See GRO-1202.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#387
Delete Branch "fix/gro-1024-clean"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?