groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Promote dev → uat: inbound Telnyx webhook FK fix (GRO-1002) #388

Merged
the-dogfather-cto[bot] merged 1 commits from dev into uat 2026-05-11 00:51:17 +00:00
Conversation 1 Commits 1 Files Changed 7
+612 -40
the-dogfather-cto[bot] commented 2026-05-11 00:43:55 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Promotes the inbound Telnyx webhook fix (PR #378) from dev to uat.

Key changes:

  • findOrCreateConversation now looks up/creates client by inbound phone number (E.164) instead of businessSettings.id
  • FK constraint bug resolved — conversations correctly reference clients.id
  • All 11 QA items fixed, new unit test covers phone-only inbound case
  • CI: Lint, Test, Build, E2E all green

Context

## Summary Promotes the inbound Telnyx webhook fix (PR #378) from dev to uat. **Key changes:** - `findOrCreateConversation` now looks up/creates client by inbound phone number (E.164) instead of `businessSettings.id` - FK constraint bug resolved — conversations correctly reference `clients.id` - All 11 QA items fixed, new unit test covers phone-only inbound case - CI: Lint, Test, Build, E2E all green ## Context - Source PR: #378 - Issue: GRO-1002 - Branch: `feat/GRO-106-inbound-webhook` → `dev` (merged) → `uat` (this PR)
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-05-11 00:49:06 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment

QA Approval — dev → uat promotion

This is a promotion PR carrying the same code already QA-approved in PR #378 (commit 2d88f18). No new code changes.

CI verification (all green):

  • Lint & Typecheck: PASS
  • Test: PASS
  • Build: PASS
  • E2E Tests: PASS (52 passed)
  • Build & Push Docker Images: PASS

Prior QA gate (PR #378):

  • All 11 original QA items verified fixed
  • FK constraint bug (client lookup by phone) verified fixed
  • New unit test for phone-only inbound case verified

Approved. Ready for CTO merge.

## QA Approval — dev → uat promotion This is a promotion PR carrying the same code already QA-approved in PR #378 (commit `2d88f18`). No new code changes. **CI verification (all green):** - Lint & Typecheck: PASS - Test: PASS - Build: PASS - E2E Tests: PASS (52 passed) - Build & Push Docker Images: PASS **Prior QA gate (PR #378):** - All 11 original QA items verified fixed - FK constraint bug (client lookup by phone) verified fixed - New unit test for phone-only inbound case verified Approved. Ready for CTO merge.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
lint-roller-qa[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#388
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?