groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix API crash: reorder Dockerfile to copy dist before pnpm install #45

Merged
ghost merged 1 commits from fix/dockerfile-layer-order into main 2026-03-18 03:44:39 +00:00
Conversation 0 Commits 1 Files Changed 1
+4 -10
ghost commented 2026-03-18 03:20:42 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Reorder Dockerfile runner stage to copy compiled dist files and package.json from the builder stage before running pnpm install --frozen-lockfile --prod
  • Previous fix (PR #44) added correct exports fields but didn't address the layer ordering issue

Problem

API pods crash with ERR_UNKNOWN_FILE_EXTENSION: ".ts" because pnpm install --prod creates workspace symlinks (node_modules/@groombook/db → packages/db/) before the dist/ output exists. Node.js then falls back to resolving .ts source files which can't be executed without a transpiler.

Fix

Copy the compiled dist/ directories and updated package.json files from the builder stage first, then run pnpm install --prod. This ensures workspace symlinks point to directories that already contain the compiled JS output.

Test plan

  • CI passes (lint, typecheck, test, build)
  • Docker image builds successfully
  • API pods start without ERR_UNKNOWN_FILE_EXTENSION crash

🤖 Generated with Claude Code

## Summary - Reorder Dockerfile runner stage to copy compiled dist files and package.json from the builder stage **before** running `pnpm install --frozen-lockfile --prod` - Previous fix (PR #44) added correct `exports` fields but didn't address the layer ordering issue ## Problem API pods crash with `ERR_UNKNOWN_FILE_EXTENSION: ".ts"` because `pnpm install --prod` creates workspace symlinks (`node_modules/@groombook/db` → `packages/db/`) before the `dist/` output exists. Node.js then falls back to resolving `.ts` source files which can't be executed without a transpiler. ## Fix Copy the compiled `dist/` directories and updated `package.json` files from the builder stage first, then run `pnpm install --prod`. This ensures workspace symlinks point to directories that already contain the compiled JS output. ## Test plan - [ ] CI passes (lint, typecheck, test, build) - [ ] Docker image builds successfully - [ ] API pods start without `ERR_UNKNOWN_FILE_EXTENSION` crash 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#45
Delete Branch "fix/dockerfile-layer-order"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?