groombook/web
13
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(App.tsx): check user role before redirecting to /admin #29

Closed
The Dogfather wants to merge 3 commits from ccfa5281-2076-40c2-87a9-bf2dbcf98d22/gro-1822-role-based-redirect into dev
pull from: ccfa5281-2076-40c2-87a9-bf2dbcf98d22/gro-1822-role-based-redirect
merge into: groombook:dev
Conversation 1 Commits 3 Files Changed 3
+14 -2
The Dogfather commented 2026-05-27 00:53:53 +00:00
Member
Copy Link
Copy Source

Summary

  • Staff users (role !== customer, injected via Authentik OIDC genericOAuth) continue to redirect to /admin
  • Customer users (role === customer) see the customer portal at / instead of being blocked
  • Impersonation flow via ?sessionId= preserved and unaffected
  • Dev mode (authDisabled=true) unchanged

Test plan

  • Login via Authentik as a customer account → verify / shows the customer portal (no redirect to /admin)
  • Login via Authentik as a staff account → verify / redirects to /admin
  • Append ?sessionId= to any URL → verify impersonation works
  • Disable auth (authDisabled=true) → verify dev login selector still works

Acceptance criteria

  • Customer SSO login → portal at / (no redirect to /admin)
  • Staff SSO login → admin panel at /admin (redirect works)
  • Impersonation flow with ?sessionId= still works
  • Dev mode unaffected (authDisabled=true)

cc @cpfarhood

## Summary - Staff users (role !== customer, injected via Authentik OIDC genericOAuth) continue to redirect to /admin - Customer users (role === customer) see the customer portal at / instead of being blocked - Impersonation flow via ?sessionId= preserved and unaffected - Dev mode (authDisabled=true) unchanged ## Test plan - [ ] Login via Authentik as a customer account → verify / shows the customer portal (no redirect to /admin) - [ ] Login via Authentik as a staff account → verify / redirects to /admin - [ ] Append ?sessionId=<impersonation-id> to any URL → verify impersonation works - [ ] Disable auth (authDisabled=true) → verify dev login selector still works ## Acceptance criteria - [x] Customer SSO login → portal at / (no redirect to /admin) - [x] Staff SSO login → admin panel at /admin (redirect works) - [x] Impersonation flow with ?sessionId= still works - [x] Dev mode unaffected (authDisabled=true) cc @cpfarhood
The Dogfather added 1 commit 2026-05-27 00:53:54 +00:00
fix(App.tsx): check user role before redirecting to /admin
CI / Test (pull_request) Successful in 22s
Details
CI / Lint & Typecheck (pull_request) Successful in 26s
Details
CI / Build & Push Docker Image (pull_request) Successful in 45s
Details
505904d8bd 
- Staff users (role !== "customer") continue to redirect to /admin
- Customer users (role === "customer") see the portal at / instead
- Impersonation flow via ?sessionId= remains unaffected
- Dev mode (authDisabled=true) unchanged

Refs: GRO-1822
Flea Flicker added 1 commit 2026-05-27 00:54:08 +00:00
docs(UAT_PLAYBOOK.md): add TC-WEB-SSO-ROLE-* test cases for GRO-1822
CI / Test (pull_request) Successful in 15s
Details
CI / Lint & Typecheck (pull_request) Successful in 17s
Details
CI / Build & Push Docker Image (pull_request) Successful in 34s
Details
4213c1f2e7 
Add section 5.4.3 covering role-based redirect after SSO login:
- Customer SSO → portal at / (not redirected to /admin)
- Staff SSO → redirect to /admin
- Impersonation bypass via ?sessionId= preserved
- Dev mode unaffected

Refs: GRO-1822
Flea Flicker added 1 commit 2026-05-27 02:20:46 +00:00
fix: add skipWaiting/clientsClaim to VitePWA workbox config
CI / Test (pull_request) Successful in 13s
Details
CI / Lint & Typecheck (pull_request) Successful in 25s
Details
CI / Build & Push Docker Image (pull_request) Successful in 50s
Details
85294b108d 
Root cause: SW remained in waiting phase after redeploy, serving stale
precached assets. Without skipWaiting/clientsClaim the old SW persisted
and controlled the page even after a new SW was installed.

Fixes blank-page regression where React never mounted on login.
The Dogfather commented 2026-05-29 08:35:18 +00:00
Author
Member
Copy Link
Copy Source

Closing as superseded.

The role-based redirect fix for GRO-1822 was merged to dev via PR #30. The current dev branch already contains the staff/customer redirect guard in src/App.tsx:

const isStaff = session?.user && (session.user as any).role === "staff";
if (!authDisabled && session && !location.pathname.startsWith("/admin") && !searchParams.has("sessionId") && isStaff) {
  return <Navigate to="/admin" replace />;
}

Deployment to UAT tracked under GRO-1824 (done). Closed as part of GRO-1847 hygiene sweep.

Closing as superseded. The role-based redirect fix for [GRO-1822](/GRO/issues/GRO-1822) was merged to `dev` via PR #30. The current `dev` branch already contains the staff/customer redirect guard in `src/App.tsx`: ```tsx const isStaff = session?.user && (session.user as any).role === "staff"; if (!authDisabled && session && !location.pathname.startsWith("/admin") && !searchParams.has("sessionId") && isStaff) { return <Navigate to="/admin" replace />; } ``` Deployment to UAT tracked under [GRO-1824](/GRO/issues/GRO-1824) (done). Closed as part of [GRO-1847](/GRO/issues/GRO-1847) hygiene sweep.
The Dogfather closed this pull request 2026-05-29 08:35:25 +00:00
Some checks are pending
CI / Test (pull_request) Successful in 13s
Details
CI / Lint & Typecheck (pull_request) Successful in 25s
Details
CI / Build & Push Docker Image (pull_request) Successful in 50s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/web#29
Delete Branch "ccfa5281-2076-40c2-87a9-bf2dbcf98d22/gro-1822-role-based-redirect"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?