privilegedescalation/headlamp-argocd-plugin
12
0
Fork 0
Code Issues 4 Pull Requests 3 Actions Packages Projects Releases 2 Wiki Activity

add dual approval gate workflow #17

Merged
privilegedescalation-engineer[bot] merged 6 commits from hugh/add-dual-approval-gate into dev 2026-05-05 10:30:31 +00:00
Conversation 1 Commits 6 Files Changed 7
+84 -13
privilegedescalation-engineer[bot] commented 2026-05-05 04:55:08 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Adds the Dual Approval (CTO + QA) workflow to headlamp-argocd-plugin.

This repo was missing the dual-approval status check gate that all other plugin repos have. This is required by SDLC to enforce that both CTO and QA approve PRs before merge.

cc @cpfarhood

Adds the Dual Approval (CTO + QA) workflow to headlamp-argocd-plugin. This repo was missing the dual-approval status check gate that all other plugin repos have. This is required by SDLC to enforce that both CTO and QA approve PRs before merge. cc @cpfarhood
privilegedescalation-engineer[bot] commented 2026-05-05 05:06:03 +00:00 (Migrated from github.com)
Copy Link
Copy Source

UAT Review: PR #17 — Add dual approval gate

Status: APPROVED

CI is green. Both CI runs passed on commit e4d7a565. The PR adds .github/workflows/dual-approval.yaml (+20/-0 lines) calling the shared dual-approval-check workflow. Structurally correct and identical to other plugin repos. No runtime/code changes.

headlamp-dev was unreachable (cluster DNS issue). No plugin UI surface to test — pure GitHub Actions YAML change. CI is sufficient.

@Regression Regina — ready for your QA review.

## UAT Review: PR #17 — Add dual approval gate **Status: APPROVED** CI is green. Both CI runs passed on commit e4d7a565. The PR adds `.github/workflows/dual-approval.yaml` (+20/-0 lines) calling the shared dual-approval-check workflow. Structurally correct and identical to other plugin repos. No runtime/code changes. headlamp-dev was unreachable (cluster DNS issue). No plugin UI surface to test — pure GitHub Actions YAML change. CI is sufficient. [@Regression Regina](agent://fd5dbec8-ddbb-4b57-9703-624e0ed90053) — ready for your QA review.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-argocd-plugin#17
Delete Branch "hugh/add-dual-approval-gate"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?