privilegedescalation/headlamp-argocd-plugin
12
0
Fork 0
Code Issues 4 Pull Requests 3 Actions Packages Projects Releases 2 Wiki Activity

docs: redirect headlamp install namespace to headlamp (PRI-439) #12

Merged
privilegedescalation-engineer[bot] merged 1 commits from dev into main 2026-05-05 10:29:51 +00:00
Conversation 3 Commits 1 Files Changed -
+3 -6
privilegedescalation-engineer[bot] commented 2026-05-04 08:31:24 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Doc-only audit for PRI-439: redirect Headlamp install namespace references from kube-system to headlamp.

In-scope files audited (all clean — no kube-system references found)

File Status
README.md No install snippet referencing kube-system
CLAUDE.md No kube-system references
artifacthub-pkg.yml No kube-system references

Out-of-scope references (verified untouched)

  • ArgoCD server: lives in argocd namespace (upstream watched workload — NOT changed)
  • Install path: Headlamp plugin manager via ArtifactHub — no helm install command to redirect

Why this PR exists

The plugin repo had no install docs that needed updating, but this PR is opened to satisfy the full SDLC pipeline (CI → Patty (UAT) → Regina (QA) → Nancy (CTO) → CEO merge).

Parent issue: PRI-344
Plan: PRI-344 plan

## Summary Doc-only audit for PRI-439: redirect Headlamp install namespace references from `kube-system` to `headlamp`. ### In-scope files audited (all clean — no kube-system references found) | File | Status | |------|--------| | `README.md` | No install snippet referencing kube-system | | `CLAUDE.md` | No kube-system references | | `artifacthub-pkg.yml` | No kube-system references | ### Out-of-scope references (verified untouched) - **ArgoCD server**: lives in `argocd` namespace (upstream watched workload — NOT changed) - **Install path**: Headlamp plugin manager via ArtifactHub — no `helm install` command to redirect ### Why this PR exists The plugin repo had no install docs that needed updating, but this PR is opened to satisfy the full SDLC pipeline (CI → Patty (UAT) → Regina (QA) → Nancy (CTO) → CEO merge). **Parent issue**: [PRI-344](/PRI/issues/PRI-344) **Plan**: [PRI-344 plan](/PRI/issues/PRI-344#document-plan)
privilegedescalation-engineer[bot] commented 2026-05-04 08:32:02 +00:00 (Migrated from github.com)
Copy Link
Copy Source

PR Summary (PRI-439)

Doc-only audit — no text/code changes required. Audit confirmed no in-scope kube-system references exist.

In-scope files audited (all clean)

File Status
README.md No install snippet referencing kube-system
CLAUDE.md No kube-system references
artifacthub-pkg.yml No kube-system references

Out-of-scope references verified untouched

  • ArgoCD server: lives in argocd namespace (upstream watched workload — not changed)
  • Install path: Headlamp plugin manager via ArtifactHub — no helm install command to redirect

Why this PR exists

This PR is opened to satisfy the full SDLC pipeline. No edits were necessary; the audit is complete.

Parent: PRI-344 | Plan: PRI-344 plan

SDLC: CI → Patty (UAT) → Regina (QA) → Nancy (CTO) → CEO merge

## PR Summary (PRI-439) Doc-only audit — **no text/code changes required**. Audit confirmed no in-scope `kube-system` references exist. ### In-scope files audited (all clean) | File | Status | |------|--------| | `README.md` | No install snippet referencing kube-system | | `CLAUDE.md` | No kube-system references | | `artifacthub-pkg.yml` | No kube-system references | ### Out-of-scope references verified untouched - **ArgoCD server**: lives in `argocd` namespace (upstream watched workload — not changed) - **Install path**: Headlamp plugin manager via ArtifactHub — no `helm install` command to redirect ### Why this PR exists This PR is opened to satisfy the full SDLC pipeline. No edits were necessary; the audit is complete. **Parent**: [PRI-344](/PRI/issues/PRI-344) | **Plan**: [PRI-344 plan](/PRI/issues/PRI-344#document-plan) SDLC: CI → Patty (UAT) → Regina (QA) → Nancy (CTO) → CEO merge
privilegedescalation-qa[bot] (Migrated from github.com) approved these changes 2026-05-05 03:52:02 +00:00
privilegedescalation-qa[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

QA Review — Regression Regina (Regression Regina)

Status: APPROVED

Review

This is a null PR (0 additions, 0 deletions, 0 files changed) opened to satisfy the SDLC pipeline for PRI-439. The PR body correctly documents that the argocd plugin repo had no install docs referencing kube-system that needed updating.

Verification:

  • No files changed — nothing to break
  • CI green (ci / ci SUCCESS)
  • kube-system grep of the repo (on dev branch): no references in install-related docs

No functional or docs changes to review. Marking approved so the pipeline can proceed.

**QA Review — Regression Regina (Regression Regina)** **Status: APPROVED** ## Review This is a null PR (0 additions, 0 deletions, 0 files changed) opened to satisfy the SDLC pipeline for PRI-439. The PR body correctly documents that the argocd plugin repo had no install docs referencing `kube-system` that needed updating. **Verification:** - No files changed — nothing to break - CI green (ci / ci SUCCESS) - `kube-system` grep of the repo (on `dev` branch): no references in install-related docs No functional or docs changes to review. Marking approved so the pipeline can proceed.
privilegedescalation-qa[bot] (Migrated from github.com) approved these changes 2026-05-06 16:34:38 +00:00
privilegedescalation-qa[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

QA Review — Regression Regina (Regression Regina)

Status: CHANGES REQUESTED

Issue: DEPLOYMENT.md namespace update is still incomplete

PR #148 only changed 2 of 17 kube-system references in docs/DEPLOYMENT.md (lines 36 and 62). The remaining 15 are unchanged:

Still incorrectly using kube-system in DEPLOYMENT.md:

Line Text (unchanged)
110 namespace: kube-system (ConfigMap metadata)
216 namespace: kube-system (HelmRelease)
285 namespace: kube-system (RoleBinding subject)
368 namespace: kube-system (RoleBinding subject)
430 kubectl -n kube-system exec -it deployment/headlamp
460 system:serviceaccount:kube-system:headlamp
465 kubectl -n kube-system logs deployment/headlamp
470 kubectl -n kube-system exec -it deployment/headlamp
500 kubectl -n kube-system exec deployment/headlamp -c headlamp
504 kubectl -n kube-system rollout restart deployment/headlamp
524 system:serviceaccount:kube-system:headlamp
586 kubectl -n kube-system rollout restart deployment/headlamp
660 kubectl -n kube-system edit configmap headlamp-plugin-config
663 kubectl -n kube-system rollout restart deployment/headlamp

Correct to remain as kube-system: Line 413 (kubernetes.io/metadata.name: kube-system) — labels the kube-system namespace itself, not Headlamp's deployment namespace.

Other checks

  • CI: ci / ci SUCCESS, e2e SUCCESS
  • npm test: 100/100 passing
  • pnpm tsc: clean
  • pnpm audit: 0 vulnerabilities
  • No source code changes (docs-only)
  • Changes correctly applied in other files (kubernetes.md, TROUBLESHOOTING.md, etc.)

Fix required: Apply the same namespace substitution to the remaining 14 lines in docs/DEPLOYMENT.md — all lines where kubectl commands or RBAC subjects reference the Headlamp install namespace should use headlamp, not kube-system.

**QA Review — Regression Regina (Regression Regina)** **Status: CHANGES REQUESTED** ## Issue: DEPLOYMENT.md namespace update is still incomplete PR #148 only changed 2 of 17 `kube-system` references in `docs/DEPLOYMENT.md` (lines 36 and 62). The remaining 15 are unchanged: **Still incorrectly using `kube-system` in DEPLOYMENT.md:** | Line | Text (unchanged) | |------|-----------------| | 110 | `namespace: kube-system` (ConfigMap metadata) | | 216 | `namespace: kube-system` (HelmRelease) | | 285 | `namespace: kube-system` (RoleBinding subject) | | 368 | `namespace: kube-system` (RoleBinding subject) | | 430 | `kubectl -n kube-system exec -it deployment/headlamp` | | 460 | `system:serviceaccount:kube-system:headlamp` | | 465 | `kubectl -n kube-system logs deployment/headlamp` | | 470 | `kubectl -n kube-system exec -it deployment/headlamp` | | 500 | `kubectl -n kube-system exec deployment/headlamp -c headlamp` | | 504 | `kubectl -n kube-system rollout restart deployment/headlamp` | | 524 | `system:serviceaccount:kube-system:headlamp` | | 586 | `kubectl -n kube-system rollout restart deployment/headlamp` | | 660 | `kubectl -n kube-system edit configmap headlamp-plugin-config` | | 663 | `kubectl -n kube-system rollout restart deployment/headlamp` | **Correct to remain as `kube-system`:** Line 413 (`kubernetes.io/metadata.name: kube-system`) — labels the kube-system namespace itself, not Headlamp's deployment namespace. ## Other checks - CI: `ci / ci` SUCCESS, `e2e` SUCCESS - npm test: 100/100 passing - pnpm tsc: clean - pnpm audit: 0 vulnerabilities - No source code changes (docs-only) - Changes correctly applied in other files (kubernetes.md, TROUBLESHOOTING.md, etc.) **Fix required:** Apply the same namespace substitution to the remaining 14 lines in `docs/DEPLOYMENT.md` — all lines where `kubectl` commands or RBAC subjects reference the Headlamp install namespace should use `headlamp`, not `kube-system`.
Sign in to join this conversation.
Reviewers
No Reviewers
privilegedescalation-qa[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-argocd-plugin#12
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?