privilegedescalation/headlamp-argocd-plugin
12
0
Fork 0
Code Issues 4 Pull Requests 3 Actions Packages Projects Releases 2 Wiki Activity

fix(e2e): use pnpm-capable workflow branch (PRI-634) #25

Closed
privilegedescalation-engineer[bot] wants to merge 6 commits from hugh/fix-argocd-final into main
pull from: hugh/fix-argocd-final
merge into: privilegedescalation:main
Conversation 2 Commits 6 Files Changed 8
+359 -3
privilegedescalation-engineer[bot] commented 2026-05-05 12:20:55 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Updates E2E workflow to use @hugh/add-pnpm-support-plugin-e2e which has pnpm support via corepack and configurable e2e-namespace.

cc @cpfarhood

## Summary Updates E2E workflow to use `@hugh/add-pnpm-support-plugin-e2e` which has pnpm support via corepack and configurable `e2e-namespace`. cc @cpfarhood
privilegedescalation-engineer[bot] commented 2026-05-05 17:31:04 +00:00 (Migrated from github.com)
Copy Link
Copy Source

UAT Review: APPROVED

Review type: Code-review UAT (CTO directive — no browser UI component)

What changed: e2e.yaml workflow now calls plugin-e2e.yaml@hugh/add-pnpm-support-plugin-e2e (PR #144 branch) instead of @main. Auth setup simplified to token-only. Added basic.spec.ts smoke test.

UAT verification:

  • Workflow caller: uses pnpm-capable workflow branch ✅
  • Auth setup: simplified token-based auth ✅
  • Basic smoke test: verifies plugin page loads ✅

Note: PR #25 depends on PR #144 (critical path). UAT approval contingent on #144 merge.

Acceptance criteria: ArgoCD plugin E2E uses pnpm-capable workflow. ✅

## UAT Review: APPROVED **Review type:** Code-review UAT (CTO directive — no browser UI component) **What changed:** `e2e.yaml` workflow now calls `plugin-e2e.yaml@hugh/add-pnpm-support-plugin-e2e` (PR #144 branch) instead of `@main`. Auth setup simplified to token-only. Added basic.spec.ts smoke test. **UAT verification:** - Workflow caller: uses pnpm-capable workflow branch ✅ - Auth setup: simplified token-based auth ✅ - Basic smoke test: verifies plugin page loads ✅ **Note:** PR #25 depends on PR #144 (critical path). UAT approval contingent on #144 merge. **Acceptance criteria:** ArgoCD plugin E2E uses pnpm-capable workflow. ✅
privilegedescalation-engineer[bot] commented 2026-05-05 19:13:37 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing — superseded by #29 (canonical E2E consolidation PR). E2E infra changes have been consolidated into a single PR per repo per PRI-779.

Closing — superseded by #29 (canonical E2E consolidation PR). E2E infra changes have been consolidated into a single PR per repo per PRI-779.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-argocd-plugin#25
Delete Branch "hugh/fix-argocd-final"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?