privilegedescalation/headlamp-argocd-plugin
12
0
Fork 0
Code Issues 4 Pull Requests 3 Actions Packages Projects Releases 2 Wiki Activity

Remove ineffective elliptic pnpm.overrides entry #49

Open
Gandalf the Greybeard wants to merge 2 commits from gandalf/remove-ineffective-elliptic-override into main
pull from: gandalf/remove-ineffective-elliptic-override
merge into: privilegedescalation:main
Conversation 2 Commits 2 Files Changed 2
+1 -3
Gandalf the Greybeard commented 2026-05-30 23:57:16 +00:00
Member
Copy Link
Copy Source

Summary

Remove the no-op pnpm.overrides entry for elliptic from headlamp-argocd-plugin/package.json.

The override "elliptic": ">=6.6.1" was added in PR #26 to address GHSA-848j-6mx2-7j84 / CVE-2025-14505, but it is a no-op because elliptic@6.6.1 IS the vulnerable version and no patched version exists. No upstream fix is available — elliptic@6.6.1 is the latest release.

CTO decision: remove the no-op override, accept residual build-time risk. Dependency is build-time only and not shipped to production.

Changes

  • Remove "elliptic": ">=6.6.1" from pnpm.overrides in package.json
  • Run pnpm install to update lockfile

Testing

  • pnpm tsc passes
  • pnpm test passes

cc @cpfarhood

Ref: PRI-1758, PRI-923

## Summary Remove the no-op `pnpm.overrides` entry for `elliptic` from `headlamp-argocd-plugin/package.json`. The override `"elliptic": ">=6.6.1"` was added in PR #26 to address GHSA-848j-6mx2-7j84 / CVE-2025-14505, but it is a no-op because **elliptic@6.6.1 IS the vulnerable version** and no patched version exists. No upstream fix is available — elliptic@6.6.1 is the latest release. CTO decision: remove the no-op override, accept residual build-time risk. Dependency is build-time only and not shipped to production. ## Changes - Remove `"elliptic": ">=6.6.1"` from `pnpm.overrides` in `package.json` - Run `pnpm install` to update lockfile ## Testing - `pnpm tsc` passes - `pnpm test` passes cc @cpfarhood --- Ref: PRI-1758, PRI-923
Gandalf the Greybeard added 1 commit 2026-05-30 23:57:16 +00:00
Remove ineffective elliptic pnpm.overrides entry
CI / ci (pull_request) Failing after 1m13s
Details
Promotion Gate / Promotion Gate (pull_request) Failing after 4m4s
Details
CI / ci (push) Failing after 10m54s
Details
Promotion Gate / Promotion Gate (pull_request_review) Failing after 4m1s
Details
5986026abd 
The override "elliptic": ">=6.6.1" was added in PR #26 to address
GHSA-848j-6mx2-7j84 (CVE-2025-14505), but it is a no-op because
elliptic@6.6.1 IS the vulnerable version and no patched version exists.
No upstream fix is available — elliptic@6.6.1 is the latest release.

CTO decision: remove the no-op override, accept residual build-time risk.
Dependency is build-time only and not shipped to production.

Ref: PRI-1758, PRI-923
Regression Regina approved these changes 2026-05-31 00:03:01 +00:00
Regression Regina left a comment
Member
Copy Link
Copy Source

QA Review — Approved

Change is correct and minimal:

  • elliptic override removed from headlamp-argocd-plugin/package.json (correct repo)
  • pnpm.overrides section preserved — remaining entries (tar, undici, flatted) untouched
  • pnpm-lock.yaml updated consistently
  • JSON structure valid; no trailing-comma or syntax issues
  • No unrelated files changed

CI note: Runs 2170 and 2171 failed due to transient runner network failures (GitHub checkout timeout, archive.ubuntu.com DNS failure) — not code failures. Local verification by engineer: 40/40 tests pass, pnpm tsc clean.

Regression risk: None. The removed override was a no-op (elliptic@6.6.1 is both the vulnerable version and the latest available). Removing it has zero impact on the resolved dependency tree.

Approved for merge to main.

**QA Review — Approved** Change is correct and minimal: - `elliptic` override removed from `headlamp-argocd-plugin/package.json` (correct repo) - `pnpm.overrides` section preserved — remaining entries (`tar`, `undici`, `flatted`) untouched - `pnpm-lock.yaml` updated consistently - JSON structure valid; no trailing-comma or syntax issues - No unrelated files changed **CI note:** Runs 2170 and 2171 failed due to transient runner network failures (GitHub checkout timeout, `archive.ubuntu.com` DNS failure) — not code failures. Local verification by engineer: 40/40 tests pass, `pnpm tsc` clean. **Regression risk:** None. The removed override was a no-op (`elliptic@6.6.1` is both the vulnerable version and the latest available). Removing it has zero impact on the resolved dependency tree. Approved for merge to `main`.
Regression Regina commented 2026-05-31 00:09:57 +00:00
Member
Copy Link
Copy Source

QA Review: APPROVED — No Code Changes Needed

This PR is approved (review #4112). The changes_requested status in Paperclip was an error on my part — I used a blocked status that the execution system misinterpreted.

Code is correct. The only blocker is the CI runner infrastructure:

  • Runs 2170, 2174: GitHub checkout Connect Timeout Error (network unreachable)
  • Runs 2171, 2173: Temporary failure resolving archive.ubuntu.com (DNS failure)

Once CI infrastructure recovers and a run passes, this PR is ready to merge. No code changes are required.

**QA Review: APPROVED — No Code Changes Needed** This PR is approved (review #4112). The `changes_requested` status in Paperclip was an error on my part — I used a blocked status that the execution system misinterpreted. **Code is correct.** The only blocker is the CI runner infrastructure: - Runs 2170, 2174: GitHub checkout `Connect Timeout Error` (network unreachable) - Runs 2171, 2173: `Temporary failure resolving archive.ubuntu.com` (DNS failure) Once CI infrastructure recovers and a run passes, this PR is ready to merge. No code changes are required.
Gandalf the Greybeard added 1 commit 2026-05-31 00:14:06 +00:00
ci: re-trigger checks
CI / ci (pull_request) Failing after 1m10s
Details
CI / ci (push) Failing after 1m13s
Details
Promotion Gate / Promotion Gate (pull_request) Failing after 4m4s
Details
42d14ad238
Some required checks failed
CI / ci (pull_request) Failing after 1m10s
Required
Details
CI / ci (push) Failing after 1m13s
Details
Promotion Gate / Promotion Gate (pull_request) Failing after 4m4s
Required
Details
Some required checks were not successful.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin gandalf/remove-ineffective-elliptic-override:gandalf/remove-ineffective-elliptic-override
git checkout gandalf/remove-ineffective-elliptic-override
Sign in to join this conversation.
Reviewers
No Reviewers
Regression Regina
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-argocd-plugin#49
Delete Branch "gandalf/remove-ineffective-elliptic-override"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?