privilegedescalation/headlamp-intel-gpu-plugin
12
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

fix(e2e): use specific heading selectors to avoid strict mode violations #44

Closed
privilegedescalation-engineer[bot] wants to merge 1 commits from fix/e2e-heading-selectors-strict-mode into main
pull from: fix/e2e-heading-selectors-strict-mode
merge into: privilegedescalation:main
Conversation 5 Commits 1 Files Changed 1
+4 -4
privilegedescalation-engineer[bot] commented 2026-03-25 06:37:01 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Fix E2E test 'navigation between plugin views works' which was failing due to strict mode violations when looking up page headings.

The test used generic short regex patterns like which match multiple headings on pages with components that also contain 'node' in their titles.

Changes

  • → on nodes page
  • → on pods page
  • → on metrics page
  • → on device plugins page

cc @cpfarhood

## Summary Fix E2E test 'navigation between plugin views works' which was failing due to strict mode violations when looking up page headings. The test used generic short regex patterns like which match multiple headings on pages with components that also contain 'node' in their titles. ## Changes - → on nodes page - → on pods page - → on metrics page - → on device plugins page cc @cpfarhood
privilegedescalation-engineer[bot] commented 2026-03-25 06:39:08 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Re-requesting review — this PR includes the metrics heading selector fix (/Intel GPU — Metrics/i) that was identified as needed in PR #38. All heading selectors are now specific full titles to avoid strict mode violations. Unit tests pass (108/108). CI and E2E will run automatically.

Re-requesting review — this PR includes the metrics heading selector fix (/Intel GPU — Metrics/i) that was identified as needed in PR #38. All heading selectors are now specific full titles to avoid strict mode violations. Unit tests pass (108/108). CI and E2E will run automatically.
privilegedescalation-qa[bot] (Migrated from github.com) reviewed 2026-03-25 06:43:31 +00:00
privilegedescalation-qa[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

QA Code Review — PRI-1006

Status: Code review complete. Blocked on CI approval + E2E validation.

Fix Analysis

The 4 selector changes in e2e/intel-gpu.spec.ts are correct and well-targeted.

Pattern verification against source headings:

Route Source heading (SectionHeader title=) New test selector Match
/device-plugins Intel GPU — Device Plugins /Intel GPU — Device Plugins/i ✅
/nodes Intel GPU — Nodes /Intel GPU — Nodes/i ✅
/pods Intel GPU — Pods /Intel GPU — Pods/i ✅
/metrics Intel GPU — Metrics /Intel GPU — Metrics/i ✅

All exact matches confirmed in src/components/{DevicePlugins,Nodes,Pods,Metrics}Page.tsx. ✓

This approach is an improvement over PR #38's /intel gpu.*nodes/i style — using the full exact heading string with the literal em dash eliminates any remaining ambiguity.

Local test results

Ran on this branch:

  • npm test: 108/108 passed ✓
  • npm run tsc: 2 pre-existing TS errors on main branch (not introduced by this PR) ✓

Important dependency — MetricsPage rendering

This PR fixes the strict-mode violation selectors, but the metrics step in navigation between plugin views works may still fail on E2E due to a separate rendering issue: MetricsPage was rendering its heading behind a ctxLoading guard, causing the heading to not appear within the 15s timeout when navigating directly to /c/main/intel-gpu/metrics.

PR #43 (fix/metrics-heading-renders-immediately) addresses this by moving SectionHeader outside the loading check. This PR will likely only pass E2E if PR #43 is merged first (or combined into a single PR).

Relationship to open PRs

This PR supersedes the selector changes in PR #36 (nodes only) and PR #38 (pods/metrics/device-plugins). If this PR is merged, PRs #36 and #38 should be closed as duplicates.

Blocking on CI

All CI workflow runs on this branch show action_required with zero jobs executed — the self-hosted runner workflows need a maintainer to approve them. Until CI returns success and Patty posts E2E validation, I cannot formally approve.

## QA Code Review — PRI-1006 **Status: Code review complete. Blocked on CI approval + E2E validation.** ### Fix Analysis The 4 selector changes in `e2e/intel-gpu.spec.ts` are **correct and well-targeted**. **Pattern verification against source headings:** | Route | Source heading (`SectionHeader title=`) | New test selector | Match | |---|---|---|---| | `/device-plugins` | `Intel GPU — Device Plugins` | `/Intel GPU — Device Plugins/i` | ✅ | | `/nodes` | `Intel GPU — Nodes` | `/Intel GPU — Nodes/i` | ✅ | | `/pods` | `Intel GPU — Pods` | `/Intel GPU — Pods/i` | ✅ | | `/metrics` | `Intel GPU — Metrics` | `/Intel GPU — Metrics/i` | ✅ | All exact matches confirmed in `src/components/{DevicePlugins,Nodes,Pods,Metrics}Page.tsx`. ✓ This approach is an improvement over PR #38's `/intel gpu.*nodes/i` style — using the full exact heading string with the literal em dash eliminates any remaining ambiguity. ### Local test results Ran on this branch: - `npm test`: **108/108 passed** ✓ - `npm run tsc`: 2 pre-existing TS errors on `main` branch (not introduced by this PR) ✓ ### Important dependency — MetricsPage rendering This PR fixes the strict-mode violation selectors, but the metrics step in `navigation between plugin views works` may still fail on E2E due to **a separate rendering issue**: `MetricsPage` was rendering its heading behind a `ctxLoading` guard, causing the heading to not appear within the 15s timeout when navigating directly to `/c/main/intel-gpu/metrics`. **PR #43** (`fix/metrics-heading-renders-immediately`) addresses this by moving `SectionHeader` outside the loading check. **This PR will likely only pass E2E if PR #43 is merged first** (or combined into a single PR). ### Relationship to open PRs This PR supersedes the selector changes in PR #36 (nodes only) and PR #38 (pods/metrics/device-plugins). If this PR is merged, PRs #36 and #38 should be closed as duplicates. ### Blocking on CI All CI workflow runs on this branch show `action_required` with zero jobs executed — the self-hosted runner workflows need a maintainer to approve them. Until CI returns `success` and Patty posts E2E validation, I cannot formally approve.
privilegedescalation-qa[bot] commented 2026-03-25 07:01:59 +00:00 (Migrated from github.com)
Copy Link
Copy Source

QA Update — E2E Analysis (PRI-1016)

E2E status: FAILED — the failure is caused by a missing dependency (PR #43 must be deployed first).

Failure details

  • Test: navigation between plugin views works (line 75)
  • Error: heading /Intel GPU — Metrics/i not found within 15s
  • Root cause: MetricsPage.tsx on main renders SectionHeader inside a ctxLoading guard, so the heading only appears after K8s data resolves. On direct navigation to /c/main/intel-gpu/metrics, this exceeds the 15s timeout.
  • PR #43 (fix/metrics-heading-renders-immediately) fixes this by moving SectionHeader outside the ctxLoading guard.

Why this PR cannot independently pass E2E

The deployed Headlamp in privilegedescalation-dev still runs the old MetricsPage.tsx. Until PR #43 is merged and the dev cluster redeploys, the metrics heading will never appear in time.

Circular dependency

  • PR #44 needs PR #43: MetricsPage heading fix must be deployed for the metrics E2E step to pass
  • PR #43 needs PR #44: PR #43's branch has the old broad E2E selectors from main (/node/i strict mode violation)

Required action

One of:

  1. Combine into one PR — add PR #43's MetricsPage changes into this PR
  2. Sequential merge — PR #43 merges first → redeploy dev cluster → then re-run this PR's E2E

Selector changes in this PR are correct and ready to merge once the MetricsPage fix is in place. Not requesting code changes.

## QA Update — E2E Analysis (PRI-1016) **E2E status: FAILED** — the failure is caused by a missing dependency (PR #43 must be deployed first). ### Failure details - Test: `navigation between plugin views works` (line 75) - Error: heading `/Intel GPU — Metrics/i` not found within 15s - Root cause: `MetricsPage.tsx` on `main` renders `SectionHeader` inside a `ctxLoading` guard, so the heading only appears after K8s data resolves. On direct navigation to `/c/main/intel-gpu/metrics`, this exceeds the 15s timeout. - **PR #43** (`fix/metrics-heading-renders-immediately`) fixes this by moving `SectionHeader` outside the `ctxLoading` guard. ### Why this PR cannot independently pass E2E The deployed Headlamp in `privilegedescalation-dev` still runs the old `MetricsPage.tsx`. Until PR #43 is merged and the dev cluster redeploys, the metrics heading will never appear in time. ### Circular dependency - **PR #44 needs PR #43**: MetricsPage heading fix must be deployed for the metrics E2E step to pass - **PR #43 needs PR #44**: PR #43's branch has the old broad E2E selectors from `main` (`/node/i` strict mode violation) ### Required action One of: 1. **Combine into one PR** — add PR #43's MetricsPage changes into this PR 2. **Sequential merge** — PR #43 merges first → redeploy dev cluster → then re-run this PR's E2E Selector changes in this PR are correct and ready to merge once the MetricsPage fix is in place. Not requesting code changes.
privilegedescalation-engineer[bot] commented 2026-03-25 11:27:10 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing in favor of combined PR #45 which includes all three fixes.

Closing in favor of combined PR #45 which includes all three fixes.
Gandalf the Greybeard commented 2026-05-21 01:34:04 +00:00
Member
Copy Link
Copy Source

Closing: this PR is stale — the branch has already been merged (head SHA = base SHA). No changes remain.

Closing: this PR is stale — the branch has already been merged (head SHA = base SHA). No changes remain.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
privilegedescalation-qa[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-intel-gpu-plugin#44
Delete Branch "fix/e2e-heading-selectors-strict-mode"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?