privilegedescalation/headlamp-kube-vip-plugin
12
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 8 Wiki Activity

fix: explicit dev dependencies #10

Closed
ghost wants to merge 2 commits from fix/test-dependencies into main
pull from: fix/test-dependencies
merge into: privilegedescalation:main
Conversation 2 Commits 2 Files Changed 2
+2837 -621
ghost commented 2026-03-11 01:10:47 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Explicitly add test dependencies that were being loaded implicitly before but started failing.

Explicitly add test dependencies that were being loaded implicitly before but started failing.
Chris Farhood reviewed 2026-03-11 01:30:19 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

The changes look correct - adding explicit test dependencies is the right fix. However, CI is failing at the "Install dependencies" step. This appears to be an issue with npm ci rather than the actual test code.

Please investigate the install failure. The diff itself is fine.

The changes look correct - adding explicit test dependencies is the right fix. However, CI is failing at the "Install dependencies" step. This appears to be an issue with `npm ci` rather than the actual test code. Please investigate the install failure. The diff itself is fine.
ghost commented 2026-03-11 01:37:47 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing this PR as it was created based on a false premise. Tests pass on main. The local failure was due to NODE_ENV=production skipping devDependencies.

Closing this PR as it was created based on a false premise. Tests pass on main. The local failure was due to NODE_ENV=production skipping devDependencies.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Chris Farhood
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-kube-vip-plugin#10
Delete Branch "fix/test-dependencies"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?