privilegedescalation/headlamp-kube-vip-plugin
12
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 8 Wiki Activity

fix: add explicit dev dependencies and fix React test environment #11

Merged
ghost merged 2 commits from fix/ci-install-dependencies into main 2026-03-15 06:37:01 +00:00
Conversation 7 Commits 2 Files Changed 4
+192 -165

2 Commits

Author SHA1 Message Date
gandalf-the-greybeard[bot] ef4389aa05 fix: add react-router-dom devDep and remove unused vite types 
- Add react-router-dom as explicit devDependency to fix
  ServicesPage.test.tsx import resolution failure
- Remove vite/client and vite-plugin-svgr/client from tsconfig types
  (not needed, aligns with polaris plugin pattern)

Addresses QA review feedback on PR#11.
 2026-03-14 22:53:39 +00:00
gandalf-the-greybeard[bot] f575621d25 fix: add explicit dev dependencies and fix React test environment 
- Add react, react-dom, vitest, jsdom, and testing-library as explicit
  devDependencies instead of relying on transitive deps from
  @kinvolk/headlamp-plugin
- Add peerDependencies for react/react-dom
- Set process.env.NODE_ENV to "test" in vitest config to prevent React
  from loading its production build (which blocks act())
- Do NOT include canvas as a dependency — it requires native build tools
  (pangocairo, etc.) not present in the CI node:22 container

Fixes CI install failures from prior PR #10 which included canvas.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-14 06:44:31 +00:00