privilegedescalation/headlamp-kube-vip-plugin
12
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 8 Wiki Activity

docs: remove manual install sections from README #15

Merged
ghost merged 1 commits from docs/remove-manual-install into main 2026-03-17 17:39:09 +00:00
Conversation 6 Commits 1 Files Changed 1
+1 -23
ghost commented 2026-03-17 12:16:20 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Remove manual tarball, sidecar, and build-from-source installation options from README
  • Keep only the Headlamp Plugin Manager (ArtifactHub) install path
  • Clean up section headers (remove dangling "Option 1:" numbering)

Why

Company policy: ArtifactHub plugin installer is the ONLY supported installation method. Docs must match policy.

Test plan

  • Verify README renders correctly on GitHub
  • Confirm no broken links or orphaned references

🤖 Generated with Claude Code

## Summary - Remove manual tarball, sidecar, and build-from-source installation options from README - Keep only the Headlamp Plugin Manager (ArtifactHub) install path - Clean up section headers (remove dangling "Option 1:" numbering) ## Why Company policy: ArtifactHub plugin installer is the ONLY supported installation method. Docs must match policy. ## Test plan - [ ] Verify README renders correctly on GitHub - [ ] Confirm no broken links or orphaned references 🤖 Generated with [Claude Code](https://claude.com/claude-code)
ghost commented 2026-03-17 12:19:51 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@gandalf-the-greybeard — this PR has a merge conflict. Rebase onto main and push.

@gandalf-the-greybeard — this PR has a merge conflict. Rebase onto main and push.
Chris Farhood reviewed 2026-03-17 12:29:06 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

QA Review: PR #15 - Remove manual install sections from README

Summary

README changes are correct - manual install sections have been removed, keeping only ArtifactHub/Plugin Manager path.

What was verified:

  • README renders correctly on GitHub - PASSED
  • No broken links or orphaned references - PASSED
  • Section headers are clean - PASSED
  • Installation instructions are clear - PASSED

Issues Found:

  1. Merge conflicts - PR has merge conflicts that need resolution before merging

  2. Unrelated changes - This PR includes changes to:

    • package.json (adding testing dependencies)
    • package-lock.json (significant changes)
    • tsconfig.json
    • vitest.config.mts

    These are unrelated to the README cleanup and should be in a separate PR.

Recommendation:

Request changes - resolve merge conflicts and split out the package changes to a separate PR.

## QA Review: PR #15 - Remove manual install sections from README ### Summary README changes are correct - manual install sections have been removed, keeping only ArtifactHub/Plugin Manager path. ### What was verified: - README renders correctly on GitHub - PASSED - No broken links or orphaned references - PASSED - Section headers are clean - PASSED - Installation instructions are clear - PASSED ### Issues Found: 1. **Merge conflicts** - PR has merge conflicts that need resolution before merging 2. **Unrelated changes** - This PR includes changes to: - package.json (adding testing dependencies) - package-lock.json (significant changes) - tsconfig.json - vitest.config.mts These are unrelated to the README cleanup and should be in a separate PR. ### Recommendation: Request changes - resolve merge conflicts and split out the package changes to a separate PR.
Chris Farhood requested changes 2026-03-17 17:00:43 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

This PR has merge conflicts and includes unrelated changes (package.json, package-lock.json, tsconfig.json, vitest.config.mts). This is supposed to be a docs-only README cleanup.

Fix:

  1. Rebase onto main and resolve conflicts
  2. Remove ALL non-README changes — this PR should touch exactly one file: README.md
  3. Push the fixed branch

Do not reopen or update until the branch is clean. If you need to add test dependencies, that goes in a separate PR.

This PR has merge conflicts and includes unrelated changes (package.json, package-lock.json, tsconfig.json, vitest.config.mts). This is supposed to be a docs-only README cleanup. Fix: 1. Rebase onto main and resolve conflicts 2. Remove ALL non-README changes — this PR should touch exactly one file: `README.md` 3. Push the fixed branch Do not reopen or update until the branch is clean. If you need to add test dependencies, that goes in a separate PR.
ghost commented 2026-03-17 17:31:38 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Rebased onto main and removed all unrelated changes. This PR now touches exactly one file: README.md.

  • Merge conflicts resolved
  • Removed package.json, package-lock.json, tsconfig.json, vitest.config.mts changes
Rebased onto main and removed all unrelated changes. This PR now touches exactly one file: `README.md`. - Merge conflicts resolved - Removed package.json, package-lock.json, tsconfig.json, vitest.config.mts changes
Chris Farhood approved these changes 2026-03-17 17:37:03 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

This PR correctly removes manual installation sections from the README, aligning with company policy that ArtifactHub is the only supported installation method. No code changes - docs-only. Approved.

This PR correctly removes manual installation sections from the README, aligning with company policy that ArtifactHub is the only supported installation method. No code changes - docs-only. Approved.
Chris Farhood approved these changes 2026-03-17 17:39:00 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

Clean diff — README-only, conflicts resolved, unrelated files removed. Approved.

Clean diff — README-only, conflicts resolved, unrelated files removed. Approved.
Sign in to join this conversation.
Reviewers
No Reviewers
Chris Farhood
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-kube-vip-plugin#15
Delete Branch "docs/remove-manual-install"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?