privilegedescalation/headlamp-kube-vip-plugin
12
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 8 Wiki Activity

fix: add npm overrides for tar and undici security advisories #17

Merged
ghost merged 2 commits from fix/dep-security-overrides-tar-undici into main 2026-03-18 23:14:07 +00:00
Conversation 3 Commits 2 Files Changed 2
+7 -3
ghost commented 2026-03-18 22:55:45 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Adds npm overrides for tar (^7.5.11) and undici (^7.24.3) to package.json
  • These overrides address CVE security advisories in transitive dependencies pulled in via @kinvolk/headlamp-plugin
  • Since we don't control the direct dependency versions in @kinvolk/headlamp-plugin, npm overrides ensure the resolved versions of tar and undici are patched against known vulnerabilities

Test plan

  • Verify npm install completes without errors
  • Verify npm ls tar and npm ls undici show the overridden versions
  • Verify npm audit no longer flags tar or undici advisories
## Summary - Adds npm `overrides` for `tar` (^7.5.11) and `undici` (^7.24.3) to `package.json` - These overrides address CVE security advisories in transitive dependencies pulled in via `@kinvolk/headlamp-plugin` - Since we don't control the direct dependency versions in `@kinvolk/headlamp-plugin`, npm overrides ensure the resolved versions of `tar` and `undici` are patched against known vulnerabilities ## Test plan - [ ] Verify `npm install` completes without errors - [ ] Verify `npm ls tar` and `npm ls undici` show the overridden versions - [ ] Verify `npm audit` no longer flags `tar` or `undici` advisories
Chris Farhood approved these changes 2026-03-18 23:01:02 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

QA Review: ✅ Tests pass, TypeScript check passes, npm overrides for tar (7.5.11) and undici (7.24.4) are correctly applied. The security advisories are addressed.

QA Review: ✅ Tests pass, TypeScript check passes, npm overrides for tar (7.5.11) and undici (7.24.4) are correctly applied. The security advisories are addressed.
ghost commented 2026-03-18 23:03:08 +00:00 (Migrated from github.com)
Copy Link
Copy Source

CI is failing — npm ci blows up because package-lock.json wasn't regenerated after adding the overrides.

Invalid: lock file's undici@7.24.1 does not satisfy undici@7.24.4

Hugh, run npm install on this branch, commit the updated lockfile, and push. I'll merge once CI is green.

CI is failing — `npm ci` blows up because `package-lock.json` wasn't regenerated after adding the overrides. ``` Invalid: lock file's undici@7.24.1 does not satisfy undici@7.24.4 ``` Hugh, run `npm install` on this branch, commit the updated lockfile, and push. I'll merge once CI is green.
Chris Farhood approved these changes 2026-03-18 23:09:27 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

CI green. Security overrides verified. Merging.

CI green. Security overrides verified. Merging.
Sign in to join this conversation.
Reviewers
No Reviewers
Chris Farhood
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-kube-vip-plugin#17
Delete Branch "fix/dep-security-overrides-tar-undici"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?