privilegedescalation/headlamp-polaris-plugin
Archived
12
0
Fork 0
Code Issues 4 Pull Requests 3 Actions Packages Projects Releases 50 Wiki Activity

refactor: precompute resource counts and add return type annotation

Browse Source 
Avoid recalculating per-resource counts 3x per table row by precomputing
them into a Map. Add explicit ResultCounts return type to resourceCounts.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Chris Farhood
2026-02-06 23:38:10 -05:00
parent 40df014b6b
commit 1b86407d8b
1 changed files with 21 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/NamespaceDetailView.tsx
+21 -15
View File
@@ -13,6 +13,7 @@ import {
countResultsForItems,
filterResultsByNamespace,
Result,
ResultCounts,
} from '../api/polaris';
import { usePolarisDataContext } from '../api/PolarisDataContext';
@@ -22,9 +23,8 @@ function scoreStatus(score: number): 'success' | 'warning' | 'error' {
return 'error';
}
function resourceCounts(result: Result) {
const counts = countResultsForItems([result]);
return counts;
function resourceCounts(result: Result): ResultCounts {
return countResultsForItems([result]);
}
export default function NamespaceDetailView() {
@@ -69,6 +69,15 @@ export default function NamespaceDetailView() {
const score = computeScore(counts);
const status = scoreStatus(score);
const countsPerResource = new Map<string, ResultCounts>();
for (const r of results) {
countsPerResource.set(`${r.Namespace}/${r.Kind}/${r.Name}`, resourceCounts(r));
}
function getResourceCounts(row: Result): ResultCounts {
return countsPerResource.get(`${row.Namespace}/${row.Kind}/${row.Name}`) ?? resourceCounts(row);
}
return (
<>
<SectionHeader title={`Polaris — ${namespace}`} />
@@ -104,24 +113,21 @@ export default function NamespaceDetailView() {
{ label: 'Kind', getter: (row: Result) => row.Kind },
{
label: 'Pass',
getter: (row: Result) => {
const c = resourceCounts(row);
return <StatusLabel status="success">{c.pass}</StatusLabel>;
},
getter: (row: Result) => (
<StatusLabel status="success">{getResourceCounts(row).pass}</StatusLabel>
),
},
{
label: 'Warning',
getter: (row: Result) => {
const c = resourceCounts(row);
return <StatusLabel status="warning">{c.warning}</StatusLabel>;
},
getter: (row: Result) => (
<StatusLabel status="warning">{getResourceCounts(row).warning}</StatusLabel>
),
},
{
label: 'Danger',
getter: (row: Result) => {
const c = resourceCounts(row);
return <StatusLabel status="error">{c.danger}</StatusLabel>;
},
getter: (row: Result) => (
<StatusLabel status="error">{getResourceCounts(row).danger}</StatusLabel>
),
},
]}
data={results}